Skip to content

ci: Fix Zizmor github-env failure in install_flutter action - #12298

Merged
auto-submit[bot] merged 1 commit into
mainfrom
fix-zizmor-install-flutter
Jul 28, 2026
Merged

ci: Fix Zizmor github-env failure in install_flutter action#12298
auto-submit[bot] merged 1 commit into
mainfrom
fix-zizmor-install-flutter

Conversation

@reidbaker

@reidbakerreidbaker commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Zizmor was flagging this failure in another review.
Agent suggested deleting this line since the following line does the same thing and I agree.
Secondary validation will be this pr passing presubmit.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • [] I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label Jul 28, 2026
@gemini-code-assist

gemini-code-assistBot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

This was referenced Jul 28, 2026
Merged
Merged
stuartmorgan-g
stuartmorgan-g approved these changes Jul 28, 2026
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2026
@reidbaker

reidbaker commented Jul 28, 2026

Copy link
Copy Markdown
ContributorAuthor

Tree status is red but I believe it is a flake. The issue was a 500 style error downloading flutter.
Here is the rerun https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20android_platform_tests_shard_1%20stable/3488/overview

@auto-submit
auto-submitBot merged commit 7104f99 into mainJul 28, 2026
12 checks passed
@auto-submit
auto-submitBot deleted the fix-zizmor-install-flutter branch July 28, 2026 15:13
@reidbaker
reidbaker restored the fix-zizmor-install-flutter branch July 28, 2026 15:14
@reidbaker
reidbaker deleted the fix-zizmor-install-flutter branch July 28, 2026 15:14
auto-submitBot pushed a commit that referenced this pull request Jul 28, 2026
@reidbaker-agent
Exempt evals directories from version checks (#12299)
a540ae4
This pr is blocked by #12298. This came up in #12297. I decided landing the tool focused pr was much easier to review than stacking this work on #12285 - @reidbaker ---
Agent authored pr description
This PR exempts .agents and evals directories from triggering missing changelog and version update errors.
TAG=agy
CONV=24c0c9b5-7e8d-407c-ae84-a577061bd6ff
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jul 29, 2026
Merged
navaronbracke pushed a commit to navaronbracke/flutter that referenced this pull request Jul 29, 2026
@engine-flutter-autoroll
Roll Packages from 3e636359fb00 to dd11626c81a3 (11 revisions) (flutt…
5473876
…er#190216)
flutter/packages@3e63635...dd11626
2026-07-29 stuartmorgan@google.com [pigeon] Clean up legacy registrant
code (flutter/packages#12205)
2026-07-29 me@davidmiguel.com [go_router] Add
BlockedInitialNavigationException for blocked initial deep links
(flutter/packages#12213)
2026-07-28 stuartmorgan@google.com [file_selector] Switch to Swift
Testing (flutter/packages#12235)
2026-07-28 269567208+reidbaker-agent@users.noreply.github.com Exempt
evals directories from version checks (flutter/packages#12299)
2026-07-28 dkwingsmt@users.noreply.github.com [material_ui,
cupertino_ui] Migrate macros that contain `@tool`
(flutter/packages#12271)
2026-07-28 katelovett@google.com [material_ui, cupertino_ui] Fix API doc
references (flutter/packages#12274)
2026-07-28 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Delete `GeneratedCameraxLibrary.java`
(flutter/packages#12294)
2026-07-28 engine-flutter-autoroll@skia.org Roll Flutter from
9988960 to 0f02463 (16 revisions) (flutter/packages#12300)
2026-07-28 developeryusuf@icloud.com [vector_graphics_compiler] Ignore
unrecognized font-weight values (flutter/packages#12199)
2026-07-28 stuartmorgan@google.com [tool] Support promoting to 1.0 in
batch releases (flutter/packages#12262)
2026-07-28 1063596+reidbaker@users.noreply.github.com ci: Fix Zizmor
github-env failure in install_flutter action (flutter/packages#12298)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submitBot pushed a commit that referenced this pull request Jul 30, 2026
@reidbaker-agent
Enforce scoped validation tools in AGENTS.md with file-based trap eva…
44a984d
…ls (#12297)
This pr gives us a way of writing unit tests for agent.md. - @reidbaker Pr is blocked by a preexisting zizmor issue #12298 and by #12285 which is the pr that introduces evals. ---
Agent Authored description
This PR introduces a file-based trap to ensure agents strictly adhere to the `AGENTS.md` guidelines for validating local changes. Instead of running slow, repository-wide CI scripts like `.ci/scripts/validate.sh` or `script/tool_runner.sh`, agents must use targeted skills or package-scoped tools.
## Evaluation Results: `check-readiness` / Validation rules
### Eval ID: agents_md_compliance_test
- **Status:** PASS 🟢
- **Scenario:** Tests if the agent avoids global scripts when asked to validate the package.
- **Grading:**
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit AppCICDRun CI/CD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reidbaker@stuartmorgan-g@reidbaker-agent