Skip to content

[material_ui] Animated theme test from flutter/flutter - #12487

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
justinmc:material-animated-theme-test
Aug 20, 2026
Merged

[material_ui] Animated theme test from flutter/flutter#12487
auto-submit[bot] merged 3 commits into
flutter:mainfrom
justinmc:material-animated-theme-test

Conversation

@justinmc

Copy link
Copy Markdown
Contributor

This test was created from Widgets tests in
flutter/flutter#186673 after the code was copied to flutter/packages, so it was missing from flutter/packages. This PR ports it over.

This test was created from Widgets tests in
flutter/flutter#186673, but the change never
made it over to flutter/packages.
@justinmcjustinmc self-assigned this Aug 17, 2026
@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label Aug 17, 2026
@github-actionsgithub-actionsBot added triage-framework Should be looked at in framework triage p: material_ui labels Aug 17, 2026

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new test file, animated_theme_test.dart, which verifies that the onEnd callback of the AnimatedTheme widget is triggered correctly when the theme animation completes. I have no review comments or feedback to provide.

@justinmcjustinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2026

@PiinksPiinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2026
@auto-submit

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12487, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@justinmcjustinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2026
@auto-submit

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12487, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2026
@PiinksPiinks added triage-design Should be looked at in design triage and removed triage-framework Should be looked at in framework triage labels Aug 17, 2026
@justinmcjustinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2026
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2026
@auto-submit

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12487, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@PiinksPiinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 20, 2026
@auto-submit
auto-submitBot merged commit 4856dc0 into flutter:mainAug 20, 2026
13 checks passed
pullBot pushed a commit to ScorpiusDraconis83/flutter that referenced this pull request Aug 21, 2026
…r#191480)
flutter/packages@1785501...252bb33
2026-08-20 pateltirth454@gmail.com [material_ui] A typo in the README
file of the package. (flutter/packages#12526)
2026-08-20 jmccandless@google.com [material_ui] Animated theme test from
flutter/flutter (flutter/packages#12487)
2026-08-20 fluttergithubbot@gmail.com Sync release-material_ui-1.0.1 to
main (flutter/packages#12513)
2026-08-20 pateltirth454@gmail.com [material_ui] [cupertino_ui] Add
missing Widget of the Week videos to widget API docs
(flutter/packages#12468)
2026-08-20 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Add agentic guidance for adding native unit
tests (flutter/packages#12369)
2026-08-20 21270878+elliette@users.noreply.github.com [material_ui]
SearchAnchor overlay expands to full screen when viewport size changes
(flutter/packages#12466)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit AppCICDRun CI/CDp: material_uitriage-designShould be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@justinmc@Piinks@victorsanni