Skip to content

[material_ui] A typo in the README file of the package. - #12526

Merged
auto-submit[bot] merged 2 commits into
mainfrom
fix/191416
Aug 20, 2026
Merged

[material_ui] A typo in the README file of the package.#12526
auto-submit[bot] merged 2 commits into
mainfrom
fix/191416

Conversation

@piedcipher

@piedcipherpiedcipher commented Aug 20, 2026

Copy link
Copy Markdown
Member

Fixesflutter/flutter#191416

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩↩2

@flutter-dashboardflutter-dashboardBot added the CICD Run CI/CD label Aug 20, 2026
@flutter-dashboard

flutter-dashboardBot commented Aug 20, 2026

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@piedcipherpiedcipher self-assigned this Aug 20, 2026
@github-actionsgithub-actionsBot added p: material_ui triage-design Should be looked at in design triage labels Aug 20, 2026
@piedcipher
piedcipher requested a review from PiinksAugust 20, 2026 20:01
gemini-code-assist[bot]
gemini-code-assistBot reviewed Aug 20, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a typo in the README.md file for the material_ui package, changing localizationDelegates to localizationsDelegates, and adds a pending changelog entry. Feedback was provided to format the pending changelog entry as a plain text sentence without leading bullet points and to capitalize 'README' in all caps.

Comment threadpackages/material_ui/pending_changelogs/change_2026_08_21_material_dep_typo.yaml
Comment on lines +1 to +3
changelog: |
- Fix Typo in Readme
version: patch

@gemini-code-assistgemini-code-assistBotAug 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In flutter/packages, pending changelog entries are typically written as plain text sentences without leading bullet points (e.g., - ), as the release tooling automatically formats them into the final CHANGELOG.md. Additionally, "README" should be capitalized in all caps.

changelog: Fixes a typo in the README.version: patch

@PiinksPiinksAug 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is bad advice.

Piinks
Piinks approved these changes Aug 20, 2026
View reviewed changes

@PiinksPiinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PiinksPiinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 20, 2026
@stuartmorgan-g

stuartmorgan-g commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

FWIW, we generally want to fix typos in README code by adopting excerpts to prevent the entire class of problems, rather than fixing the one-off instance of the typo.

@auto-submit
auto-submitBot merged commit 252bb33 into mainAug 20, 2026
12 checks passed
@auto-submit
auto-submitBot deleted the fix/191416 branch August 20, 2026 22:16
@kjxbyz

kjxbyz commented Aug 21, 2026

Copy link
Copy Markdown

adopting excerpts

@stuartmorgan-g What does this mean? Could you explain it in detail?

@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Aug 21, 2026
Merged
pullBot pushed a commit to ScorpiusDraconis83/flutter that referenced this pull request Aug 21, 2026
@engine-flutter-autoroll
Roll Packages from 1785501174f3 to 252bb33ad366 (6 revisions) (flutte…
4df8f73
…r#191480)
flutter/packages@1785501...252bb33
2026-08-20 pateltirth454@gmail.com [material_ui] A typo in the README
file of the package. (flutter/packages#12526)
2026-08-20 jmccandless@google.com [material_ui] Animated theme test from
flutter/flutter (flutter/packages#12487)
2026-08-20 fluttergithubbot@gmail.com Sync release-material_ui-1.0.1 to
main (flutter/packages#12513)
2026-08-20 pateltirth454@gmail.com [material_ui] [cupertino_ui] Add
missing Widget of the Week videos to widget API docs
(flutter/packages#12468)
2026-08-20 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Add agentic guidance for adding native unit
tests (flutter/packages#12369)
2026-08-20 21270878+elliette@users.noreply.github.com [material_ui]
SearchAnchor overlay expands to full screen when viewport size changes
(flutter/packages#12466)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@piedcipher

piedcipher commented Aug 24, 2026

Copy link
Copy Markdown
MemberAuthor

adopting excerpts

@stuartmorgan-g What does this mean? Could you explain it in detail?

https://github.com/flutter/website/blob/main/packages/excerpter/README.md

@stuartmorgan-g

stuartmorgan-g commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

We don't use that package in this repo any more. I'm referring to https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#readme-code

See also flutter/flutter#102679

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PiinksPiinksPiinks approved these changes
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@piedcipherpiedcipher

Labels

autosubmitMerge PR when tree becomes green via auto submit AppCICDRun CI/CDp: material_uitriage-designShould be looked at in design triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A typo in the README file of the material_ui package.

4 participants

@piedcipher@stuartmorgan-g@kjxbyz@Piinks