Skip to content

fix: [go_router] Extra parameter is always null in route level redirect callback - #2308

Closed
Semapl3 wants to merge 9 commits into
flutter:mainfrom
Semapl3:main
Closed

fix: [go_router] Extra parameter is always null in route level redirect callback#2308
Semapl3 wants to merge 9 commits into
flutter:mainfrom
Semapl3:main

Conversation

@Semapl3

@Semapl3Semapl3 commented Jul 5, 2022•
edited by chunhtai
Loading

Copy link
Copy Markdown
Contributor

@flutter-dashboard

flutter-dashboardBot commented Jul 5, 2022

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla

google-claBot commented Jul 5, 2022

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@DamienMrtl

DamienMrtl commented Jul 8, 2022

Copy link
Copy Markdown

Please allow this merge it fixes a regression

chunhtai
chunhtai reviewed Jul 22, 2022
View reviewed changes

@chunhtaichunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Semapl3 Thanks for the fix, can you add a test to make sure we don't accidentally revert it?

@Semapl3
feat: add testflutter/flutter#106164
dbbc5a5
@Semapl3
Merge remote-tracking branch 'origin_of/main'
4ff6ebe
# Conflicts:
#	packages/go_router/CHANGELOG.md
#	packages/go_router/lib/src/go_route_information_parser.dart
#	packages/go_router/pubspec.yaml
@Semapl3
fix: after merge
75aa2d9
@Semapl3

Semapl3 commented Jul 22, 2022

Copy link
Copy Markdown
ContributorAuthor

@chunhtai, fixed for 4.2.1 and test ready. Check please

chunhtai
chunhtai reviewed Jul 22, 2022
View reviewed changes
Comment threadpackages/go_router/CHANGELOG.md Outdated
Comment threadpackages/go_router/test/go_router_test.dart
Comment threadpackages/go_router/test/go_router_test.dart
chunhtai
chunhtai approved these changes Aug 1, 2022
View reviewed changes

@chunhtaichunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it looks like there is a merge conflict, please rebase off the latest main branch

@chunhtai
chunhtai requested a review from johnpryanAugust 1, 2022 17:40
@chunhtai

chunhtai commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

cc john for secondary review

@johnpryan

johnpryan commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

It looks like this is breaking tests in go_router_builder

@Semapl3Semapl3 mentioned this pull request Aug 2, 2022
Merged
@Semapl3

Semapl3 commented Aug 2, 2022

Copy link
Copy Markdown
ContributorAuthor

#2404

@Semapl3Semapl3 closed this Aug 2, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnpryanjohnpryanjohnpryan approved these changes
@chunhtaichunhtaichunhtai approved these changes

Assignees

No one assigned

Labels

needs testsp: go_router

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[go_router] Extra parameter is always null in route level redirect callback

4 participants

@Semapl3@DamienMrtl@chunhtai@johnpryan