Skip to content

fix: [go_router] Extra parameter is always null in route level redirect callback - #2404

Merged
johnpryan merged 10 commits into
flutter:mainfrom
Semapl3:fix
Aug 2, 2022
Merged

fix: [go_router] Extra parameter is always null in route level redirect callback#2404
johnpryan merged 10 commits into
flutter:mainfrom
Semapl3:fix

Conversation

@Semapl3

Copy link
Copy Markdown
Contributor

repeat (#2308)

Semapl3 added 10 commits July 5, 2022 22:31
# Conflicts:
#	packages/go_router/CHANGELOG.md
#	packages/go_router/lib/src/go_route_information_parser.dart
#	packages/go_router/pubspec.yaml
# Conflicts:
#	packages/go_router/CHANGELOG.md
#	packages/go_router/pubspec.yaml

@chunhtaichunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai
chunhtai requested a review from johnpryanAugust 2, 2022 15:35
@johnpryan
johnpryan merged commit bf82745 into flutter:mainAug 2, 2022
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…ct callback (flutter#2404)
* fix: [go_router] Extra parameter is always null in route level redirect callback #106164
flutter/flutter#106164
* fix: version
* fix: changelog
* fix: that was a typo
* fix: That was a typo
* feat: add test flutter/flutter#106164
* fix: after merge
* feat: add test, check call redirect
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
…ct callback (flutter#2404)
* fix: [go_router] Extra parameter is always null in route level redirect callback #106164
flutter/flutter#106164
* fix: version
* fix: changelog
* fix: that was a typo
* fix: That was a typo
* feat: add test flutter/flutter#106164
* fix: after merge
* feat: add test, check call redirect
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Semapl3@johnpryan@chunhtai