Skip to content

[go_router] Fixes crashes when popping navigators manually - #2952

Merged
chunhtai merged 3 commits into
flutter:mainfrom
chunhtai:issues/116784
Jan 4, 2023
Merged

[go_router] Fixes crashes when popping navigators manually#2952
chunhtai merged 3 commits into
flutter:mainfrom
chunhtai:issues/116784

Conversation

@chunhtai

@chunhtaichunhtai commented Dec 15, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

fixesflutter/flutter#116784
fixesflutter/flutter#116769
fixesflutter/flutter#117431

The issue is that the app bar will pop the root navigator and skipping the navigator in the shellroute, and the goRouter only expect the RouteMatchList to be popped start from the last RouteMatch. This pr fixes it so that it can handle the case where developer may manually pop any navigator.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

chunhtai
chunhtai commented Dec 15, 2022
View reviewed changes
Comment threadpackages/go_router/lib/src/delegate.dart Outdated

@chunhtaichunhtaiDec 15, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We missed this when we refactor the pop. PopNavigatorRouterDelegateMixin is no longer needed since we override poproute directly

@chunhtaichunhtai mentioned this pull request Dec 21, 2022
Closed
11 tasks
leehack
leehack reviewed Dec 21, 2022
View reviewed changes
Comment threadpackages/go_router/test/go_router_test.dart Outdated

@leehackleehackDec 21, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a test case that pop multiple times?
I think this PR would fix flutter/flutter#117431 but just want to make sure of it.

I added a test case for it in this PR: #2989 but since it's close, I'd like to add it in this PR at least.

@chunhtaichunhtaiDec 21, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added on pop twice

@leehackleehackDec 21, 2022•
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ;)
I have no right to approve the PR but everything looks good to me.

@leehack

leehack commented Dec 21, 2022

Copy link
Copy Markdown

#2989 could be added to the issue list since it's a potential fix for it as well.

@chunhtai

chunhtai commented Dec 21, 2022

Copy link
Copy Markdown
ContributorAuthor

looks like this is blocked on #2977

@devberkaydevberkay mentioned this pull request Dec 25, 2022
Closed
@devberkay

devberkay commented Dec 25, 2022

Copy link
Copy Markdown

This issue is also fixed with this pr.

@chunhtai
chunhtai merged commit 3ef0f63 into flutter:mainJan 4, 2023
@tolotolo mentioned this pull request Jan 9, 2023
Closed
11 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@chunhtai
[go_router] Fixes crashes when popping navigators manually (flutter#2952
5e02143
)
* [go_router] Fixes crashes when popping navigators manually
* rename
* add additional test case
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@chunhtai
[go_router] Fixes crashes when popping navigators manually (flutter#2952
4949ce4
)
* [go_router] Fixes crashes when popping navigators manually
* rename
* add additional test case
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnpryanjohnpryanjohnpryan approved these changes
@leehackleehackAwaiting requested review from leehack

Assignees

No one assigned

Labels

p: go_router

Projects

None yet

Milestone

No milestone

4 participants

@chunhtai@leehack@devberkay@johnpryan