Skip to content

[go_router_builder] Update to go_router 6 - #2977

Merged
chunhtai merged 3 commits into
flutter:mainfrom
ValentinVignal:go-router-builder/go-router-6
Jan 4, 2023
Merged

[go_router_builder] Update to go_router 6#2977
chunhtai merged 3 commits into
flutter:mainfrom
ValentinVignal:go-router-builder/go-router-6

Conversation

@ValentinVignal

@ValentinVignalValentinVignal commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

List which issues are fixed by this PR. You must list at least one issue.

No issue but this is a follow up to #2848

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above. I listed the related PR instead
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard

flutter-dashboardBot commented Dec 20, 2022

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@ValentinVignal

ValentinVignal commented Dec 20, 2022

Copy link
Copy Markdown
ContributorAuthor

I believe this PR can have a test exemption? Am I correct?

@chunhtai

chunhtai commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

This migrates go_router_builder due to go_router v6 breaking changes. The existing test should be good enough.

chunhtai
chunhtai reviewed Dec 20, 2022
View reviewed changes

@chunhtaichunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to regenerate the example/ in order to pass the ci

@ValentinVignal

ValentinVignal commented Dec 20, 2022

Copy link
Copy Markdown
ContributorAuthor

You will need to regenerate the example/ in order to pass the ci

I didn't modify any code of go_router_builder so the generated files shouldn't have changed, right? 🤔 Anyway, I tried re-generated them and I don't have any changes.
Plus, on dart_unit_tests CHANNEL:stable, the fails on /example/test/ensure_build_test.dart. The differences are on the pubspec.yaml so I'm not sure I understand what is happening 🤔 (The test is passing on my local)

@chunhtai

chunhtai commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

ah it is the path override that causes the test to fail, it is not related to this change, sorry about the confusion. I will put up a pr to fix it.

@chunhtai

chunhtai commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

This should fix it #2984

@chunhtaichunhtai mentioned this pull request Dec 20, 2022
Merged
11 tasks
@Hixie

Hixie commented Dec 20, 2022

Copy link
Copy Markdown
Contributor

test-exempt: rolling dependencies

@chunhtai

chunhtai commented Dec 21, 2022

Copy link
Copy Markdown
Contributor

The pr was merged. Can you rebase off the main branch and see if that fixes ci

@chunhtaichunhtai mentioned this pull request Dec 21, 2022
Merged
11 tasks
@ValentinVignal
ValentinVignalforce-pushed the go-router-builder/go-router-6 branch from 81d8dad to b88d526CompareDecember 21, 2022 18:08
@chunhtai

chunhtai commented Dec 21, 2022

Copy link
Copy Markdown
Contributor

it looks like your branch is still missing the latest commit 73637b8

@ValentinVignal
ValentinVignalforce-pushed the go-router-builder/go-router-6 branch from b88d526 to c5863d1CompareDecember 21, 2022 20:34
chunhtai
chunhtai approved these changes Dec 21, 2022
View reviewed changes

@chunhtaichunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtaichunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 21, 2022
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 21, 2022
@auto-submit

auto-submitBot commented Dec 21, 2022

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages, pr: 2977, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit

auto-submitBot commented Dec 21, 2022

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages, pr: 2977, due to Validations Fail.

@chunhtaichunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 22, 2022
@ValentinVignalValentinVignal mentioned this pull request Dec 23, 2022
Merged
11 tasks
@chunhtai
chunhtai merged commit 5773a70 into flutter:mainJan 4, 2023
@ClaireDavisClaireDavis mentioned this pull request Jan 25, 2023
Closed
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@ValentinVignal
[go_router_builder] Update togo_router6 (flutter#2977)
11cbe5f
* 📝 Update the documentation to go_router 6
* ♻️ Update the example to use go_router 6
* ⬆️ Upgrade go_router_builder version
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@ValentinVignal
[go_router_builder] Update togo_router6 (flutter#2977)
44cac7f
* 📝 Update the documentation to go_router 6
* ♻️ Update the example to use go_router 6
* ⬆️ Upgrade go_router_builder version
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnpryanjohnpryanjohnpryan approved these changes
@chunhtaichunhtaichunhtai approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appneeds testsp: go_router_builder

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ValentinVignal@chunhtai@Hixie@johnpryan