Skip to content

[flutter_adaptive_scaffold] Change selectedIndex on standardNavigationRail to allow null value. - #3088

Merged
auto-submit[bot] merged 12 commits into
flutter:mainfrom
joshryandavis:make-adaptive-rail-index-nullable
Jan 25, 2023
Merged

[flutter_adaptive_scaffold] Change selectedIndex on standardNavigationRail to allow null value.#3088
auto-submit[bot] merged 12 commits into
flutter:mainfrom
joshryandavis:make-adaptive-rail-index-nullable

Conversation

@joshryandavis

@joshryandavisjoshryandavis commented Jan 25, 2023

Copy link
Copy Markdown
Contributor

Changed selectedIndex on standardNavigationRail to allow a null value to be set so that the NavRail can show nothing as being selected. The selectedIndex value is passed to NavigationRail which already permits null.

Fixes: #118888

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard

flutter-dashboardBot commented Jan 25, 2023

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@joshryandavis
joshryandavis marked this pull request as draft January 25, 2023 10:44
@joshryandavis
joshryandavis marked this pull request as ready for review January 25, 2023 11:23
@joshryandavis

joshryandavis commented Jan 25, 2023

Copy link
Copy Markdown
ContributorAuthor

I've added a test for the change.

gspencergoog
gspencergoog requested changes Jan 25, 2023
View reviewed changes
Comment threadpackages/flutter_adaptive_scaffold/CHANGELOG.md Outdated
Comment threadpackages/flutter_adaptive_scaffold/lib/src/adaptive_scaffold.dart Outdated
Comment threadpackages/flutter_adaptive_scaffold/CHANGELOG.md Outdated
joshryandavisand others added 3 commits January 25, 2023 20:42
@joshryandavis@gspencergoog
Update packages/flutter_adaptive_scaffold/CHANGELOG.md
de99a64
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
@joshryandavis@gspencergoog
Update packages/flutter_adaptive_scaffold/lib/src/adaptive_scaffold.dart
093011e
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
@joshryandavis@gspencergoog
Update packages/flutter_adaptive_scaffold/CHANGELOG.md
ccb6745
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
@gspencergooggspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 25, 2023
@auto-submit
auto-submitBot merged commit add4d18 into flutter:mainJan 25, 2023
@joshryandavis
joshryandavis deleted the make-adaptive-rail-index-nullable branch January 25, 2023 23:20
sybrands-place pushed a commit to sybrands-place/packages that referenced this pull request Jan 30, 2023
Jeremy
Merge branch 'main' into null_status_retriable
577bbb1
* main: (479 commits)
removes raw ArrayLists (flutter#3101)
Roll Flutter from c9affdb to 27f8ebd (15 revisions) (flutter#3098)
[ci] Fix the new LUCI iOS build-all tasks (flutter#3099)
[pigeon] [ObjC] Removes unused GetNullableObject function (flutter#3100)
[pigeon] Swift host error handling (flutter#3084)
Roll Flutter from a815ee6 to c9affdb (23 revisions) (flutter#3093)
[ci] Enable min SDK version checks (flutter#3095)
[pigeon] Fix C++ config handling (flutter#3094)
[ci] Add LUCI version of iOS build-all (flutter#3096)
[pigeon] Adds SwiftFunction annotation (flutter#2304)
[flutter_adaptive_scaffold] Change `selectedIndex` on `standardNavigationRail` to allow null value. (flutter#3088)
[pigeon] requires analyzer 5.2.0 (flutter#3090)
Roll Flutter from c35efda to a815ee6 (22 revisions) (flutter#3089)
[ci] Update legacy Flutter version tests (flutter#3087)
Roll Flutter (stable) from 135454a to b06b8b2 (2551 revisions) (flutter#3086)
[flutter_adaptive_scaffold] Fix leading and trailing Navigation Rail Widgets (flutter#3080)
Roll Flutter from bd7bee0 to c35efda (24 revisions) (flutter#3085)
[pigeon] Minor C++ output adjustments (flutter#3083)
[pigeon] Updates writeScoped and addScoped to disallow symbol-less use. (flutter#3081)
Roll Flutter from f33e8d3 to bd7bee0 (5 revisions) (flutter#3082)
...
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@joshryandavis@gspencergoog
[flutter_adaptive_scaffold] Change selectedIndex on `standardNaviga…
5c0faf9
…tionRail` to allow null value. (flutter#3088)
* changed selectedIndex on standardNavigationRail to allow null value
* Update CHANGELOG.md
* increase version number
* Update CHANGELOG.md
* Update CHANGELOG.md
* change index types from int to int?
* add test for slectedIndex can be set to null
* Update CHANGELOG.md
* index types set to int? and ensure BottomNavigationRail currentIndex isn't null
* Update packages/flutter_adaptive_scaffold/CHANGELOG.md
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
* Update packages/flutter_adaptive_scaffold/lib/src/adaptive_scaffold.dart
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
* Update packages/flutter_adaptive_scaffold/CHANGELOG.md
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@joshryandavis@gspencergoog
[flutter_adaptive_scaffold] Change selectedIndex on `standardNaviga…
64b2db3
…tionRail` to allow null value. (flutter#3088)
* changed selectedIndex on standardNavigationRail to allow null value
* Update CHANGELOG.md
* increase version number
* Update CHANGELOG.md
* Update CHANGELOG.md
* change index types from int to int?
* add test for slectedIndex can be set to null
* Update CHANGELOG.md
* index types set to int? and ensure BottomNavigationRail currentIndex isn't null
* Update packages/flutter_adaptive_scaffold/CHANGELOG.md
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
* Update packages/flutter_adaptive_scaffold/lib/src/adaptive_scaffold.dart
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
* Update packages/flutter_adaptive_scaffold/CHANGELOG.md
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domesticmousedomesticmousedomesticmouse approved these changes
@gspencergooggspencergooggspencergoog approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: flutter_adaptive_scaffold

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AdaptiveScaffold.standardNavigationRail selectedIndex not nullable unlike normal NavigationRail

3 participants

@joshryandavis@domesticmouse@gspencergoog