Skip to content

[pigeon] Fix C++ config handling - #3094

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
stuartmorgan-g:pigeon-cpp-config
Jan 27, 2023
Merged

[pigeon] Fix C++ config handling#3094
auto-submit[bot] merged 3 commits into
flutter:mainfrom
stuartmorgan-g:pigeon-cpp-config

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Removes experimental_ from the serialized names of the C++ pigeon configuration options, so that setting them in a @ConfigurePigeon annotation works. This matches the other experimental generators, where the command line flag has the marking, but not the options structure.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 26, 2023
@auto-submit
auto-submitBot merged commit f324abb into flutter:mainJan 27, 2023
sybrands-place pushed a commit to sybrands-place/packages that referenced this pull request Jan 30, 2023
* main: (479 commits)
removes raw ArrayLists (flutter#3101)
Roll Flutter from c9affdb to 27f8ebd (15 revisions) (flutter#3098)
[ci] Fix the new LUCI iOS build-all tasks (flutter#3099)
[pigeon] [ObjC] Removes unused GetNullableObject function (flutter#3100)
[pigeon] Swift host error handling (flutter#3084)
Roll Flutter from a815ee6 to c9affdb (23 revisions) (flutter#3093)
[ci] Enable min SDK version checks (flutter#3095)
[pigeon] Fix C++ config handling (flutter#3094)
[ci] Add LUCI version of iOS build-all (flutter#3096)
[pigeon] Adds SwiftFunction annotation (flutter#2304)
[flutter_adaptive_scaffold] Change `selectedIndex` on `standardNavigationRail` to allow null value. (flutter#3088)
[pigeon] requires analyzer 5.2.0 (flutter#3090)
Roll Flutter from c35efda to a815ee6 (22 revisions) (flutter#3089)
[ci] Update legacy Flutter version tests (flutter#3087)
Roll Flutter (stable) from 135454a to b06b8b2 (2551 revisions) (flutter#3086)
[flutter_adaptive_scaffold] Fix leading and trailing Navigation Rail Widgets (flutter#3080)
Roll Flutter from bd7bee0 to c35efda (24 revisions) (flutter#3085)
[pigeon] Minor C++ output adjustments (flutter#3083)
[pigeon] Updates writeScoped and addScoped to disallow symbol-less use. (flutter#3081)
Roll Flutter from f33e8d3 to bd7bee0 (5 revisions) (flutter#3082)
...
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
* Fix config names
* Version bump
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
* Fix config names
* Version bump
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: pigeon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@stuartmorgan-g@tarrinneal