Uh oh!
There was an error while loading. Please reload this page.
[video_player] synchronize isPlaying state - #3261
Conversation
hellohuanlin
commented
Feb 22, 2023
Feel free to request review again when my comments in the original PR is addressed. |
maRci002
commented
Feb 22, 2023
I've addressed your comments but removing those two
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
My understanding is that what you changed is the standard approach in 1p plugins. IIRC I have seen similar practice in other plugins. Without that overrides, the dependency would be the previously published version |
hellohuanlin
commented
Feb 23, 2023
I stamped the iOS part. you probably wanna add back the reviewers for android/web. |
maRci002
commented
Feb 23, 2023
How can add back the reviewers? |
ditman
left a comment
There was a problem hiding this comment.
The web bits look good to me, this is a big update for the player, thanks for doing it!
Uh oh!
There was an error while loading. Please reload this page.
camsim99
left a comment
There was a problem hiding this comment.
The Android parts look good to me!
This PR made me realize the lack of test coverage on the Android native parts, so you could add a test for this change, but definitely not blocking for this PR. More-so a note to self :)
BraveEvidence
commented
Mar 15, 2023
This will help https://www.youtube.com/watch?v=IMQdSTlTXjA |
maRci002
commented
Mar 16, 2023
In my opinion this PR is ready
|
gmackall
commented
Mar 23, 2023
Is this PR missing anything in order to be able to merge? |
tarrinneal
commented
Mar 23, 2023
Seems ready to me. |
[video_player] synchronize isPlaying state
[video_player] synchronize isPlaying state
[video_player] synchronize isPlaying state
This was the original PR: flutter-team-archive/plugins#7198
Resolvesflutter/flutter#49081.
Resolvesflutter/flutter#120872.
This PR synchronizes
isPlayingstate between native and dart code, for example if a headset is unplugged or a phone call interrupts the video.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.