[video_player_platform_interface] synchronize isPlaying state

[maRci002]

This PR is part of #3261

This is why this part is created: https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I listed at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

[bparrishMines]

@stuartmorgan It looks like this is causing analyze errors because of the enum change. Based on flutter/flutter#89866 (comment), should this temporarily add

// ignore: missing_enum_constant_in_switch

to the implementation packages.

[stuartmorgan-g]

Yes, since there's no impact from not handling it (as it's just example code), just ignoring it in this PR and then removing the ignores in the second and third PRs is the best option.

[bparrishMines]

@maRci002 As mentioned above, can you add // ignore: missing_enum_constant_in_switch to the implementations where you are seeing the analyzer test fail?

[maRci002]

@bparrishMines I've added // ignore: missing_enum_constant_in_switch to avoid analyzer fails.

Now I've some errors in the CHANGELOG in the following packages: video_player / video_player_android / video_player_avfoundation. I think I should not make changes in the CHANGELOG since I just added lint ignore and #3261 will remove them.

[stuartmorgan-g]

Overriding version and changelog checks: the changes are // ignores, which are exempt.

[stuartmorgan-g]

This will need to wait for #3417 to land and then be re-merged, to avoid breaking post-submit.

[maRci002]

@stuartmorgan I've re-merged the newest main.

video_player / video_player_android / video_player_avfoundation packages throws:

Dart changes are not allowed to other packages in video_player in the same PR as changes to public Dart code in video_player_platform_interface, as this can cause accidental breaking changes to be missed by automated checks. Please split the changes to these two packages into separate PRs.

If you believe that this is a false positive, please file a bug.

This is the disadvantage of: flutter/flutter#89866 (comment)

[stuartmorgan-g]

I expected that, but misremembered and thought we had a way to override it in presubmit (which is why I suggested waiting rather than splitting it initially, sorry about that).

I filed flutter/flutter#122390 for the false positive, but for now you can just split the ignores into a new PR. We can get that landed quickly, unblocking this one.

[maRci002]

I filed flutter/flutter#122390 for the false positive, but for now you can just split the ignores into a new PR. We can get that landed quickly, unblocking this one.

I created the ignore PR: #3435, when it is merged, then I will update this branch and remove the ignores in this PR however I won't be able to do that so I'll remove the ignores in #3261 PR.

[stuartmorgan-g]

Removing the overrides since those changes will be moving to the other PR.

[maRci002]

I have updated this PR to not touch ignores meanwhile updated #3261 to remove lint checks.

[BraveEvidence]

This will help https://www.youtube.com/watch?v=IMQdSTlTXjA

[stuartmorgan-g]

LGTM

[bparrishMines]

LGTM