Skip to content

Add flutter_lints package - #343

Merged
goderbauer merged 8 commits into
flutter:masterfrom
goderbauer:flutter_lints
May 5, 2021
Merged

Add flutter_lints package#343
goderbauer merged 8 commits into
flutter:masterfrom
goderbauer:flutter_lints

Conversation

@goderbauer

Copy link
Copy Markdown
Member

@goderbauer

Copy link
Copy Markdown
MemberAuthor

@@ -0,0 +1,17 @@
# Recomended lints for Flutter apps, packages, and plugins.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=> Recommended

Comment threadpackages/flutter_lints/pubspec.yaml Outdated
@@ -0,0 +1,13 @@
name: flutter_lints
description: Recommended lints for Flutter apps, packages, and plugins

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End with a period?

=>

Recommended lints for Flutter apps, packages, and plugins.

Comment threadpackages/flutter_lints/pubspec.yaml Outdated
description: Recommended lints for Flutter apps, packages, and plugins
version: 0.1.0
homepage: https://github.com/flutter/packages/tree/master/packages/flutter_lints
publish_to: none

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to remove this?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultimately, yes. However, while I pull in the "lints" dependency directly from github below, there's a lint telling me that I need this. 😝

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha!

@goderbauer
goderbauer requested a review from devoncarewMay 5, 2021 20:07

@devoncarewdevoncarew left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pq
pq approved these changes May 5, 2021

@pqpq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎

dependencies:
lints: # TODO(goderbauer): depend on released version before releasing the package
git: https://github.com/dart-lang/lints.git
lints: ^1.0.0-dev.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@goderbauer
goderbauer merged commit b17875f into flutter:masterMay 5, 2021
@goderbauer
goderbauer deleted the flutter_lints branch May 5, 2021 23:54
austinstoker pushed a commit to austinstoker/packages that referenced this pull request Apr 29, 2022
stuartmorgan-g pushed a commit that referenced this pull request Oct 31, 2024
* Transform clip path when applied to a group
Fix#136, #343, #566
* Golden test added
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@goderbauer@pq@devoncarew