[animations] Set FadeScaleTransitionConfiguration to configuration default value

[mono0926]

showModal works well with configuration: const FadeScaleTransitionConfiguration() for typical use cases.

#124 made it possible to set FadeScaleTransitionConfiguration to configuration default value.
With this change, showModal can be just as easy to handle as showDialog.

[shihaohong]

Hi, thank you for the PR! I have some comments about some of the changes, but the bigger task would be to write unit tests to ensure that the default configuration used is respected.

[shihaohong]

Specify in the API documentation for showModal that FadeScaleTransitionConfiguration will be used by default if it not specified.

[shihaohong]

You need to add new tests to packages/animations/test/modal.dart ensuring that configuration is FadeScaleTransitionConfiguration by default.

What I would do is call showModal without specifying a configuration, but making sure that the animations forwards and reverse are the ones for FadeScaleTransitionConfiguration. Another thing that would be good to test here is that the barrier properties for FadeScaleTransitionConfiguration are used as well.

You can use some of the existing tests in that test file and the tests from packages/animations/test/fade_scale_transition_test.dart to guide you.

[mono0926]

Thanks, I've added the tests: b158029

[shihaohong]

I would not take this line out of the test, since we still want to explicitly test that when FadeScaleTransitionConfiguration is used, we have the expected behavior. For example, if the default configuration for showModal were to ever change, this test would break

[mono0926]

Okay, I'll revert this 👍

[shihaohong]

Ditto

[shihaohong]

Ditto

[shihaohong]

Ditto

[shihaohong]

Ditto

[shihaohong]

I think we can just leave this here, but it's up to you if this becomes the default behavior

[mono0926]

Thanks, I think the sample code should be simple, so omitting default value is better 🤔

[mono0926]

@shihaohong

Thanks for the polite review. I've reflected the points you've made, so please review it again 🙏

[shihaohong]

Sorry for the delay in my code review, I've been busy with some other work lately and had not had the chance to look at the animations library PRs.

The changes look good! Just a small nit on the API documentation :)

[shihaohong]

We usually specify the default at the end of the API doc. Could you shift this to be the last line? Thank you!

[mono0926]

@shihaohong

Thanks for the review again 🙏

But, I don't understand what change is desired 🤔

I think current default position is same as like this:

packages/packages/animations/lib/src/modal.dart

Lines 157 to 167 in f5411da

	/// A configuration object containing the properties needed to implement a
	/// modal route.
	///
	/// The `barrierDismissible` argument is used to determine whether this route
	/// can be dismissed by tapping the modal barrier. This argument defaults
	/// to true. If `barrierDismissible` is true, a non-null `barrierLabel` must be
	/// provided.
	///
	/// The `barrierLabel` argument is the semantic label used for a dismissible
	/// barrier. This argument defaults to "Dismiss".
	abstractclassModalConfiguration {

---

Could you suggest the change by using multi-line code suggestions?

[mono0926]

@shihaohong

Thanks for the suggestion 🙏
I reflect it: 0bd1dcf

[shihaohong]

LGTM! Thank you for working on this!