Skip to content

[camera] MediaSettings parameter for createCameraWithSettings - #3586

Merged
auto-submit[bot] merged 159 commits into
flutter:mainfrom
mtbo-org:main
May 6, 2024
Merged

[camera] MediaSettings parameter for createCameraWithSettings#3586
auto-submit[bot] merged 159 commits into
flutter:mainfrom
mtbo-org:main

Conversation

@PROGrand

@PROGrandPROGrand commented Mar 29, 2023•
edited by stuartmorgan-g
Loading

Copy link
Copy Markdown
Contributor

This PR is for enabling fps and bitrate control of recorded video.
Allow users to more control over recorded video size.
CameraPlatform.createCameraWithSettings is added, leaving original CameraPlatform.createCamera commented as deprecated. So this is not breaking change.
Tested on a set of mobile devices.
Web support depends on browser (perfect with Firefox).

Fixesflutter/flutter#54339

@PROGrandPROGrand reopened this Mar 29, 2023
@PROGrandPROGrand mentioned this pull request Mar 29, 2023
Closed
@PROGrand

PROGrand commented Mar 29, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

This is main PR. Platform interface's PR is here: #3615

hellohuanlin
hellohuanlin reviewed Mar 30, 2023
View reviewed changes

@hellohuanlinhellohuanlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. This is very nice feature to have. Can you share a video capture after this change?

Comment threadpackages/camera/camera/CHANGELOG.md Outdated
Comment threadpackages/camera/camera/README.md Outdated
Comment threadpackages/camera/camera/example/integration_test/camera_test.dart Outdated
Comment threadpackages/camera/camera/example/pubspec.yaml Outdated
Comment threadpackages/camera/camera/pubspec.yaml Outdated
Comment threadpackages/camera/camera_avfoundation/ios/Classes/FLTCam.m Outdated
Comment threadpackages/camera/camera_avfoundation/ios/Classes/FLTCam.m Outdated
Comment threadpackages/camera/camera_avfoundation/ios/Classes/FLTCam.m Outdated
Comment threadpackages/camera/camera_avfoundation/ios/Classes/FLTCam.m Outdated
stuartmorgan-g
stuartmorgan-g requested changes Apr 17, 2024
View reviewed changes
Comment threadpackages/camera/camera/README.md Outdated
<?code-excerpt "readme_full_example.dart (FullAppExample)"?>
```dart
import 'package:camera/camera.dart';
import 'package:camera_platform_interface/camera_platform_interface.dart';

@stuartmorgan-gstuartmorgan-gApr 17, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still here.

Comment threadpackages/camera/camera/example/lib/readme_full_example.dart Outdated

// #docregion FullAppExample
import 'package:camera/camera.dart';
import 'package:camera_platform_interface/camera_platform_interface.dart';

@stuartmorgan-gstuartmorgan-gApr 17, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

Comment threadpackages/camera/camera/README.md Outdated
Comment threadpackages/camera/camera/example/pubspec.yaml Outdated
Comment threadpackages/camera/camera/lib/src/camera_controller.dart Outdated
Comment on lines +237 to +244
CameraController(
CameraDescription description,
this.resolutionPreset, {
this.enableAudio = true,
ResolutionPreset resolutionPreset, {
bool enableAudio = true,
this.imageFormatGroup,
}) : mediaSettings = MediaSettings(
resolutionPreset: resolutionPreset, enableAudio: enableAudio),
super(CameraValue.uninitialized(description));

@stuartmorgan-gstuartmorgan-gApr 17, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hasn't been addressed.

@PROGrand

PROGrand commented Apr 17, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@stuartmorgan
#3586 (comment)

Sorry, what did you mean?

@stuartmorgan-g

stuartmorgan-g commented Apr 19, 2024

Copy link
Copy Markdown
Collaborator

@stuartmorgan#3586 (comment)

Sorry, what did you mean?

#3586 (comment)

@PROGrand

PROGrand commented Apr 20, 2024

Copy link
Copy Markdown
ContributorAuthor

@stuartmorgan
Unwrapped media settings class into parameters and added to CameraController constructor as optionals. Is it acceptable?

stuartmorgan-g
stuartmorgan-g approved these changes May 6, 2024
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request May 6, 2024
Merged
@reidbakerreidbaker mentioned this pull request Jul 2, 2024
Closed
11 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@ditmanditmanditman approved these changes
@bparrishMinesbparrishMinesbparrishMines approved these changes
@hellohuanlinhellohuanlinhellohuanlin approved these changes
@cbrackencbrackenAwaiting requested review from cbracken
@tarrinnealtarrinnealAwaiting requested review from tarrinneal
@camsim99camsim99Awaiting requested review from camsim99

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appfederated: all_changesPR that contains changes for all packages for a federated plugin changep: camera

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[camera] Support custom frame rate and bit rate

12 participants

@PROGrand@hellohuanlin@reidbaker@stuartmorgan-g@gmackall@ebjorklund01@deucks@yassinekassis@evaboen@ditman@bparrishMines@camsim99