[camera] CameraPlatform.createCameraWithSettings by PROGrand · Pull Request #3615 · flutter/packages

PROGrand · 2023-04-01T09:26:26Z

Platform interface of federated plugin

This is the platform-interface part of camera PR #3586.

App-facing change

Previously, CameraController was unable to setup fps and bitrates, allowing only resolution settings like this:

controller =CameraController(_cameras[0], ResolutionPreset.max);

This PR gives additional functionality to set fps and bitrates via withSettings:

controller =CameraController.withSettings(
_cameras[0],
mediaSettings:constMediaSettings(
resolutionPreset:ResolutionPreset.low,
fps:15,
videoBitrate:200000,
audioBitrate:32000,
enableAudio:true,
),
);

Android, iOS, etc.

All platforms must implement CameraPlatform.createCameraWithSettings in addition to CameraPlatform.createCamera, providing platform specific code for fps and `bitrate' platform:

Future<int> createCamera(
CameraDescription cameraDescription,
CameraDescription cameraDescription,
ResolutionPreset? resolutionPreset, {
ResolutionPreset? resolutionPreset, {
bool enableAudio =false,
bool enableAudio =false,
}) {
}) =>throwUnimplementedError('createCamera() is not implemented.');
createCameraWithSettings(
cameraDescription,
MediaSettings(
resolutionPreset: resolutionPreset,
enableAudio: enableAudio,
),
);
/// Creates an uninitialized camera instance and returns the cameraId.Future<int> createCameraWithSettings(
CameraDescription cameraDescription,
MediaSettings? mediaSettings,
) {
throwUnimplementedError('createCameraWithSettings() is not implemented.');
}
}

bparrishMines · 2023-04-05T00:40:10Z

This looks like a change that needs to follow https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins. This PR doesn't indicate how Android, iOS, and the app-facing package will use this new feature.

PROGrand · 2023-04-05T14:34:49Z

@bparrishMines

Updated PR description.

This is second PR (according to https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins).

First PR is here: #3586.

Can you please review #3586 ?

xjosk · 2023-04-21T23:24:48Z

hello, how is it going with this feature? i'd like to add it to my current app, i'm looking forward to it

stuartmorgan-g · 2023-05-16T19:50:29Z

Update from triage: this is waiting for the sub-PR referenced above to complete the review process.

stuartmorgan-g · 2023-05-30T20:07:39Z

@PROGrand The sub-issue was closed due to lack of updates. Have you decided not to move forward with this?

stuartmorgan-g · 2023-06-13T19:57:36Z

Update from triage: the sub-PR has been re-opened, so this is once again waiting on that to complete the review process.

stuartmorgan-g · 2023-07-10T16:42:43Z

It looks like I had the ordering inverted in my comments above; this is the sub-PR, and we were waiting for the combo PR to pass review. That seems to be done; @bparrishMines it looks like this is ready for your review.

stuartmorgan-g · 2023-08-10T18:55:14Z

@PROGrand Are you still planning on updating this so that it's ready for another review?

PROGrand · 2023-08-11T22:00:52Z

@stuartmorgan

@PROGrand Are you still planning on updating this so that it's ready for another review?

Yes, i can update this branch. But should main PR be reviewed first?

bparrishMines

LGTM with a couple nits

@stuartmorgan / @camsim99 for secondary review

…tial implementation

stuartmorgan-g

LGTM, thanks!

…kages#3615)

flutter/packages@be915be...4bf5114 2023-10-23 PROGrand@users.noreply.github.com [camera] CameraPlatform.createCameraWithSettings (flutter/packages#3615) 2023-10-23 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.3 to 2.22.4 (flutter/packages#5201) 2023-10-22 engine-flutter-autoroll@skia.org Roll Flutter from 6f4850d to 823e083 (3 revisions) (flutter/packages#5198) 2023-10-21 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.0 to 4.1.1 (flutter/packages#5167) 2023-10-21 engine-flutter-autoroll@skia.org Roll Flutter from 0883cb2 to 6f4850d (24 revisions) (flutter/packages#5196) 2023-10-21 50643541+Mairramer@users.noreply.github.com [ios_platform_images] migrate objC to swift (flutter/packages#4847) 2023-10-20 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20230618 to 20231013 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter/packages#5149) 2023-10-20 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20230618 to 20231013 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#5150) 2023-10-20 tarrinneal@gmail.com [quick_actions] convert to pigeon (flutter/packages#5159) 2023-10-20 737941+loic-sharma@users.noreply.github.com [ci] Add build-only Windows Arm64 tests (flutter/packages#5142) 2023-10-20 43759233+kenzieschmoll@users.noreply.github.com Add '--no-tree-shake-icons' option to `BenchmarkServer` (flutter/packages#5186) 2023-10-20 engine-flutter-autoroll@skia.org Roll Flutter from c2bd2c1 to 0883cb2 (24 revisions) (flutter/packages#5192) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* main: (139 commits) Change firebase device tests from Android api 30 to 33 (flutter#5185) [url_launcher] Add an `inAppBrowserView` mode (flutter#5205) [ci] Remove device_type property from Windows Arm64 properties (flutter#5193) [url_launcher_web] Disallows launching "javascript:" URLs. (flutter#5180) [local_auth]: Bump androidx.fragment:fragment from 1.6.0 to 1.6.1 in /packages/local_auth/local_auth_android/android (flutter#4600) Roll Flutter from 823e083 to 5e8b5f4 (13 revisions) (flutter#5208) [tool] Add optional swift-format support (flutter#5204) [camera] CameraPlatform.createCameraWithSettings (flutter#3615) Bump github/codeql-action from 2.22.3 to 2.22.4 (flutter#5201) Roll Flutter from 6f4850d to 823e083 (3 revisions) (flutter#5198) Bump actions/checkout from 4.1.0 to 4.1.1 (flutter#5167) Roll Flutter from 0883cb2 to 6f4850d (24 revisions) (flutter#5196) [ios_platform_images] migrate objC to swift (flutter#4847) [in_app_pur]: Bump org.json:json from 20230618 to 20231013 in /packages/in_app_purchase/in_app_purchase_android/example/android/app (flutter#5149) [in_app_pur]: Bump org.json:json from 20230618 to 20231013 in /packages/in_app_purchase/in_app_purchase_android/android (flutter#5150) [quick_actions] convert to pigeon (flutter#5159) [ci] Add build-only Windows Arm64 tests (flutter#5142) Add '--no-tree-shake-icons' option to `BenchmarkServer` (flutter#5186) Roll Flutter from c2bd2c1 to 0883cb2 (24 revisions) (flutter#5192) [ci] Finalize migration to x64 specific Windows platform (flutter#5174) ...

…ed) (#5223) ## Platform implementations of federated plugin This is the `platform implementations` part of `camera` PR #3586. `camera_platform_interface: 2.6.0` merged and published in PR #3615. Now repeating steps 3,4 (see [Changing federated plugins](https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins)), because `camera/camera` depends on implementations `camera/camera_android`, `camera/camera_web` etc.

PROGrand · 2024-04-17T11:33:00Z

how to use this pr in my camera

You should wait for #3586, or import camera from https://github.com/mtbo-org/packages

…ed) (flutter#5223) This is the `platform implementations` part of `camera` PR flutter#3586. `camera_platform_interface: 2.6.0` merged and published in PR flutter#3615. Now repeating steps 3,4 (see [Changing federated plugins](https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins)), because `camera/camera` depends on implementations `camera/camera_android`, `camera/camera_web` etc.

## Platform interface of federated plugin This is the `platform-interface` part of `camera` PR flutter#3586. ## App-facing change Previously, CameraController was unable to setup fps and bitrates, allowing only resolution settings like this: ```dart controller = CameraController(_cameras[0], ResolutionPreset.max); ``` This PR gives additional functionality to set `fps` and `bitrates` via `withSettings`: ```dart controller = CameraController.withSettings( _cameras[0], mediaSettings: const MediaSettings( resolutionPreset: ResolutionPreset.low, fps: 15, videoBitrate: 200000, audioBitrate: 32000, enableAudio: true, ), ); ``` ## Android, iOS, etc. All platforms must implement `CameraPlatform.createCameraWithSettings` in addition to `CameraPlatform.createCamera`, providing platform specific code for `fps` and `bitrate' platform: ```dart Future<int> createCamera( CameraDescription cameraDescription, CameraDescription cameraDescription, ResolutionPreset? resolutionPreset, { ResolutionPreset? resolutionPreset, { bool enableAudio = false, bool enableAudio = false, }) { }) => throw UnimplementedError('createCamera() is not implemented.'); createCameraWithSettings( cameraDescription, MediaSettings( resolutionPreset: resolutionPreset, enableAudio: enableAudio, ), ); /// Creates an uninitialized camera instance and returns the cameraId. Future<int> createCameraWithSettings( CameraDescription cameraDescription, MediaSettings? mediaSettings, ) { throw UnimplementedError('createCameraWithSettings() is not implemented.'); } } ```

…ed) (flutter#5223) ## Platform implementations of federated plugin This is the `platform implementations` part of `camera` PR flutter#3586. `camera_platform_interface: 2.6.0` merged and published in PR flutter#3615. Now repeating steps 3,4 (see [Changing federated plugins](https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins)), because `camera/camera` depends on implementations `camera/camera_android`, `camera/camera_web` etc.

## Platform interface of federated plugin This is the `platform-interface` part of `camera` PR flutter#3586. ## App-facing change Previously, CameraController was unable to setup fps and bitrates, allowing only resolution settings like this: ```dart controller = CameraController(_cameras[0], ResolutionPreset.max); ``` This PR gives additional functionality to set `fps` and `bitrates` via `withSettings`: ```dart controller = CameraController.withSettings( _cameras[0], mediaSettings: const MediaSettings( resolutionPreset: ResolutionPreset.low, fps: 15, videoBitrate: 200000, audioBitrate: 32000, enableAudio: true, ), ); ``` ## Android, iOS, etc. All platforms must implement `CameraPlatform.createCameraWithSettings` in addition to `CameraPlatform.createCamera`, providing platform specific code for `fps` and `bitrate' platform: ```dart Future<int> createCamera( CameraDescription cameraDescription, CameraDescription cameraDescription, ResolutionPreset? resolutionPreset, { ResolutionPreset? resolutionPreset, { bool enableAudio = false, bool enableAudio = false, }) { }) => throw UnimplementedError('createCamera() is not implemented.'); createCameraWithSettings( cameraDescription, MediaSettings( resolutionPreset: resolutionPreset, enableAudio: enableAudio, ), ); /// Creates an uninitialized camera instance and returns the cameraId. Future<int> createCameraWithSettings( CameraDescription cameraDescription, MediaSettings? mediaSettings, ) { throw UnimplementedError('createCameraWithSettings() is not implemented.'); } } ```

…ed) (flutter#5223) ## Platform implementations of federated plugin This is the `platform implementations` part of `camera` PR flutter#3586. `camera_platform_interface: 2.6.0` merged and published in PR flutter#3615. Now repeating steps 3,4 (see [Changing federated plugins](https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins)), because `camera/camera` depends on implementations `camera/camera_android`, `camera/camera_web` etc.

PROGrand requested a review from bparrishMines as a code owner April 1, 2023 09:26

github-actionsBot added the p: camera label Apr 1, 2023

PROGrand mentioned this pull request Apr 1, 2023
[camera] MediaSettings parameter for createCameraWithSettings #3586
Merged

charlesluzar mentioned this pull request Apr 7, 2023
[camera] Support custom frame rate and bit rate flutter/flutter#54339
Closed

bparrishMines reviewed Jul 11, 2023
View reviewed changes

Comment threadpackages/camera/camera_platform_interface/lib/src/types/media_settings.dart Outdated

PROGrand force-pushed the camera-platform-interface branch from 367bf52 to 1659383Compare August 14, 2023 09:18

PROGrand force-pushed the camera-platform-interface branch from 1659383 to c2b214dCompare September 4, 2023 08:42

PROGrand requested a review from bparrishMines September 6, 2023 08:05

bparrishMines approved these changes Sep 15, 2023
View reviewed changes

Comment threadpackages/camera/camera_platform_interface/pubspec.yaml Outdated
Comment threadpackages/camera/camera_platform_interface/CHANGELOG.md Outdated

bparrishMines added the federated: partial_changes PR that contains changes for only a single package of a federated plugin change label Sep 15, 2023

stuartmorgan-g requested changes Sep 20, 2023
View reviewed changes

PROGrand requested a review from stuartmorgan-g September 21, 2023 10:51

PROGrand force-pushed the camera-platform-interface branch from c77fbec to 9cf640cCompare September 21, 2023 16:40

PROGrand force-pushed the camera-platform-interface branch from 9cf640c to 393b579Compare September 22, 2023 18:07

PROGrand force-pushed the camera-platform-interface branch 2 times, most recently from cf15472 to ce4bed7Compare September 30, 2023 05:42

tests are simplified
afed7bc

PROGrand requested a review from stuartmorgan-g October 18, 2023 09:24

PROGrand added 2 commits October 19, 2023 01:12

Merge branch 'main' into camera-platform-interface
bb01c48

Merge branch 'main' into camera-platform-interface
a3a35a7

stuartmorgan-g requested changes Oct 20, 2023
View reviewed changes

Comment threadpackages/camera/camera_platform_interface/test/camera_platform_interface_test.dart Outdated

PROGrandand others added 2 commits October 23, 2023 09:58

Merge branch 'main' into camera-platform-interface
21967bc

test: createCameraWithSettings() should call createCamera() using par…
7af349c
…tial implementation

PROGrand requested a review from stuartmorgan-g October 23, 2023 08:49

stuartmorgan-g approved these changes Oct 23, 2023
View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 23, 2023

auto-submitBot merged commit 4bf5114 into flutter:mainOct 23, 2023

engine-flutter-autoroll mentioned this pull request Oct 23, 2023
Roll Packages from be915be92708 to 4bf51144c295 (12 revisions) flutter/flutter#137062
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 23, 2023
4bf5114[camera] CameraPlatform.createCameraWithSettings (flutter/pac…
19080d7
…kages#3615)

PROGrand deleted the camera-platform-interface branch October 24, 2023 23:09

PROGrand mentioned this pull request Oct 24, 2023
[camera] Camera with MediaSettings: platform implementations (federated) #5223
Merged

reidbaker mentioned this pull request Jan 12, 2024
Dialog Debug #5881
Closed

reidbaker mentioned this pull request Jan 19, 2024
[in_app_purchase] Add play country code api #5941
Merged
12 tasks

reidbaker mentioned this pull request Feb 19, 2024
[in_app_purchase_android] Add UserChoiceBilling mode. #6162
Merged
16 tasks

This comment was marked as off-topic.
Sign in to view

Uh oh!

Conversation

PROGrand commented Apr 1, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Platform interface of federated plugin

App-facing change

Android, iOS, etc.

Uh oh!

bparrishMines commented Apr 5, 2023

Uh oh!

PROGrand commented Apr 5, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xjosk commented Apr 21, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stuartmorgan-g commented May 16, 2023

Uh oh!

stuartmorgan-g commented May 30, 2023

Uh oh!

stuartmorgan-g commented Jun 13, 2023

Uh oh!

stuartmorgan-g commented Jul 10, 2023

Uh oh!

Uh oh!

stuartmorgan-g commented Aug 10, 2023

Uh oh!

PROGrand commented Aug 11, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as off-topic.

PROGrand commented Apr 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

PROGrand commented Apr 1, 2023•
edited
Loading

PROGrand commented Apr 5, 2023•
edited
Loading

xjosk commented Apr 21, 2023•
edited
Loading

PROGrand commented Aug 11, 2023•
edited
Loading