Skip to content

[google_maps] Endorses package:google_maps_flutter_web. - #4124

Merged
auto-submit[bot] merged 8 commits into
flutter:mainfrom
ditman:maps_endorse_web
Jun 5, 2023
Merged

[google_maps] Endorses package:google_maps_flutter_web.#4124
auto-submit[bot] merged 8 commits into
flutter:mainfrom
ditman:maps_endorse_web

Conversation

@ditman

@ditmanditman commented May 31, 2023

Copy link
Copy Markdown
Member

This PR endorses package:google_maps_flutter_web as the implementation of google_maps_flutter for the web platform, and updates the relevant documentation.

Issues

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard

flutter-dashboardBot commented May 31, 2023

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@ditman

ditman commented May 31, 2023

Copy link
Copy Markdown
MemberAuthor

This PR should cause that the integration tests of google_maps run on platform:web. AFAIK we don't have specific tests for package endorsement.

@ditman

This comment was marked as resolved.

Sign in to view
@ditman
ditmanforce-pushed the maps_endorse_web branch from 857b5f5 to dc74737CompareJune 1, 2023 03:55
@stuartmorgan-g

stuartmorgan-g commented Jun 2, 2023

Copy link
Copy Markdown
Collaborator

This PR should cause that the integration tests of google_maps run on platform:web.

And it does!

Huh, do web integration tests run by flutter drive just not output anything about the tests being run? I'd never looked closely at the web output before, but I see that everything is that way.

Is there a way to get flutter drive to list the tests that are run?

AFAIK we don't have specific tests for package endorsement.

Yes, adding web support to the example is the test.

stuartmorgan-g
stuartmorgan-g approved these changes Jun 2, 2023
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits!

Comment threadpackages/google_maps_flutter/google_maps_flutter/CHANGELOG.md Outdated
Comment threadpackages/google_maps_flutter/google_maps_flutter/README.md Outdated
@ditman

ditman commented Jun 2, 2023

Copy link
Copy Markdown
MemberAuthor

I'll address the nits before landing this, thanks for the review!

Huh, do web integration tests run by flutter drive just not output anything about the tests being run? I'd never looked closely at the web output before, but I see that everything is that way.

@stuartmorgan They normally only output some information about the compilation, and the "All Tests Passed" line. If there's an error, they'll spit the failing test and the stack trace.

I've only seen the normal "progress" that other tests have when running the tests manually in the browser (by flutter running the test file), but I suspect flutter drive is eating the browser console output (maybe?).

@ditman
ditmanforce-pushed the maps_endorse_web branch from bf2fc45 to 10abebfCompareJune 2, 2023 22:53
@ditmanditman added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Jun 5, 2023
@ditman
ditmanforce-pushed the maps_endorse_web branch from 10abebf to d553462CompareJune 5, 2023 21:11
@ditmanditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 5, 2023
@auto-submit
auto-submitBot merged commit 3c3c980 into flutter:mainJun 5, 2023
@ditman
ditman deleted the maps_endorse_web branch June 5, 2023 22:08
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jun 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 6, 2023
@engine-flutter-autoroll
3c3c980[google_maps] Endorses package:google_maps_flutter_web. (flut…
e07e91b
…ter/packages#4124)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jun 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 6, 2023
@engine-flutter-autoroll
3c3c980[google_maps] Endorses package:google_maps_flutter_web. (flut…
b2c6057
…ter/packages#4124)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jun 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 6, 2023
@engine-flutter-autoroll
3c3c980[google_maps] Endorses package:google_maps_flutter_web. (flut…
b7c8926
…ter/packages#4124)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jun 6, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 6, 2023
@engine-flutter-autoroll
3c3c980[google_maps] Endorses package:google_maps_flutter_web. (flut…
231cea8
…ter/packages#4124)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Jun 6, 2023
@engine-flutter-autoroll
Roll Packages fromdb4e5c2toda72219(10 revisions) (#128348)
7e87650
flutter/packages@db4e5c2...da72219
2023-06-06 42692766+dimabran@users.noreply.github.com remove unnecessary typed_data imports (flutter/packages#4136)
2023-06-06 43054281+camsim99@users.noreply.github.com [local_auth_android] Bump androidx.fragment to 1.5.7 and androidx.core to 1.10.1 (flutter/packages#4142)
2023-06-05 ditman@gmail.com [google_maps] Endorses package:google_maps_flutter_web. (flutter/packages#4124)
2023-06-05 ditman@gmail.com [ci] Removes bespoke web scripts. (flutter/packages#4129)
2023-06-05 arteevraina@gmail.com [webview_flutter]: fix typo (flutter/packages#4070)
2023-06-05 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump com.google.guava:guava from 31.1-android to 32.0.0-android in /packages/camera/camera_android_camerax/android (flutter/packages#4116)
2023-06-05 stuartmorgan@google.com [tools] Fix OOB test error (flutter/packages#4144)
2023-06-05 46547604+dsambuk@users.noreply.github.com [path_provider] Allow win32 up to version 5.x (flutter/packages#4125)
2023-06-05 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.guava:guava from 31.1-android to 32.0.0-android in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#4112)
2023-06-05 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump exoplayer_version from 2.18.6 to 2.18.7 in /packages/video_player/video_player_android/android (flutter/packages#4053)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
@reidbakerreidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbakerreidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@ditman
[google_maps] Endorses package:google_maps_flutter_web. (flutter#4124)
ec71fb7
This PR endorses `package:google_maps_flutter_web` as the implementation of `google_maps_flutter` for the web platform, and updates the relevant documentation.
### Issues
* Fixesflutter/flutter#80688
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@ditman
[google_maps] Endorses package:google_maps_flutter_web. (flutter#4124)
577a7ea
This PR endorses `package:google_maps_flutter_web` as the implementation of `google_maps_flutter` for the web platform, and updates the relevant documentation.
### Issues
* Fixesflutter/flutter#80688
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: google_maps_flutterplatform-web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[google_maps_flutter_web] Endorse Google Maps plugin for Web

2 participants

@ditman@stuartmorgan-g