Skip to content

remove unnecessary typed_data imports - #4136

Merged
auto-submit[bot] merged 10 commits into
flutter:mainfrom
dimabran:remove_unnecessary_imports
Jun 6, 2023
Merged

remove unnecessary typed_data imports#4136
auto-submit[bot] merged 10 commits into
flutter:mainfrom
dimabran:remove_unnecessary_imports

Conversation

@dimabran

@dimabrandimabran commented Jun 4, 2023

Copy link
Copy Markdown
Contributor

Removed all the unnecessary commented out typed_data import ignore

FixesIssue #128140

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@dimabran
dimabranforce-pushed the remove_unnecessary_imports branch 2 times, most recently from ba4ca4f to 98b6ba5CompareJune 5, 2023 07:35
@dimabran
dimabranforce-pushed the remove_unnecessary_imports branch from 98b6ba5 to d8a6728CompareJune 5, 2023 07:44
stuartmorgan-g
stuartmorgan-g requested changes Jun 5, 2023
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Comment threadpackages/camera/camera_android/test/type_conversion_test.dart
Comment threadpackages/camera/camera/CHANGELOG.md Outdated
tarrinneal
tarrinneal approved these changes Jun 5, 2023
View reviewed changes

@tarrinnealtarrinneal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once @stuartmorgan's requests are addressed.

stuartmorgan-g
stuartmorgan-g reviewed Jun 6, 2023
View reviewed changes
Comment threadsite-shared
@stuartmorgan-gstuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Jun 6, 2023
@stuartmorgan-g

stuartmorgan-g commented Jun 6, 2023

Copy link
Copy Markdown
Collaborator

Overriding version and changelog checks; import changes are dev-only.

@stuartmorgan-g

stuartmorgan-g commented Jun 6, 2023

Copy link
Copy Markdown
Collaborator

For some reason the Cirrus checks didn't start for the last commit, but since everything but the version check was green in the previous commit, and the last commit only reverted the submodule, it's fine to land.

stuartmorgan-g
stuartmorgan-g approved these changes Jun 6, 2023
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g

stuartmorgan-g commented Jun 6, 2023

Copy link
Copy Markdown
Collaborator

Hm, @tarrinneal could you re-approve? Your approval was cleared somehow.

@tarrinnealtarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2023
@auto-submit
auto-submitBot merged commit da72219 into flutter:mainJun 6, 2023
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jun 6, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 6, 2023
@engine-flutter-autoroll
da72219remove unnecessary typed_data imports (flutter/packages#4136)
6e67249
@dimabran
dimabran deleted the remove_unnecessary_imports branch June 6, 2023 19:10
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Jun 6, 2023
@engine-flutter-autoroll
Roll Packages fromdb4e5c2toda72219(10 revisions) (#128348)
7e87650
flutter/packages@db4e5c2...da72219
2023-06-06 42692766+dimabran@users.noreply.github.com remove unnecessary typed_data imports (flutter/packages#4136)
2023-06-06 43054281+camsim99@users.noreply.github.com [local_auth_android] Bump androidx.fragment to 1.5.7 and androidx.core to 1.10.1 (flutter/packages#4142)
2023-06-05 ditman@gmail.com [google_maps] Endorses package:google_maps_flutter_web. (flutter/packages#4124)
2023-06-05 ditman@gmail.com [ci] Removes bespoke web scripts. (flutter/packages#4129)
2023-06-05 arteevraina@gmail.com [webview_flutter]: fix typo (flutter/packages#4070)
2023-06-05 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump com.google.guava:guava from 31.1-android to 32.0.0-android in /packages/camera/camera_android_camerax/android (flutter/packages#4116)
2023-06-05 stuartmorgan@google.com [tools] Fix OOB test error (flutter/packages#4144)
2023-06-05 46547604+dsambuk@users.noreply.github.com [path_provider] Allow win32 up to version 5.x (flutter/packages#4125)
2023-06-05 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.guava:guava from 31.1-android to 32.0.0-android in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#4112)
2023-06-05 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump exoplayer_version from 2.18.6 to 2.18.7 in /packages/video_player/video_player_android/android (flutter/packages#4053)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
Merged
@reidbakerreidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbakerreidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@dimabran
remove unnecessary typed_data imports (flutter#4136)
e4ec308
Removed all the unnecessary commented out typed_data import ignore
Fixes [Issue #128140](flutter/flutter#128140)
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@dimabran
remove unnecessary typed_data imports (flutter#4136)
2be05f5
Removed all the unnecessary commented out typed_data import ignore
Fixes [Issue #128140](flutter/flutter#128140)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@tarrinnealtarrinnealtarrinneal approved these changes
@cyanglazcyanglazAwaiting requested review from cyanglaz
@hellohuanlinhellohuanlinAwaiting requested review from hellohuanlin
@reidbakerreidbakerAwaiting requested review from reidbaker
@camsim99camsim99Awaiting requested review from camsim99
@ditmanditmanAwaiting requested review from ditman
@bparrishMinesbparrishMinesAwaiting requested review from bparrishMines
@gspencergooggspencergoogAwaiting requested review from gspencergoog

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appoverride: no changelog neededOverride the check requiring CHANGELOG updates for most changesoverride: no versioning neededOverride the check requiring version bumps for most changesp: camerap: file_selectorp: flutter_imagep: google_maps_flutterp: palette_generatorp: video_playerp: webview_flutterplatform-androidplatform-iosplatform-web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove unnecessary typed_data imports from flutter/packages

3 participants

@dimabran@stuartmorgan-g@tarrinneal