Skip to content

[web] Use new APIs from dart:ui_web - #4168

Merged
auto-submit[bot] merged 9 commits into
flutter:mainfrom
mdebbar:dart_ui_web
Aug 30, 2023
Merged

[web] Use new APIs from dart:ui_web#4168
auto-submit[bot] merged 9 commits into
flutter:mainfrom
mdebbar:dart_ui_web

Conversation

@mdebbar

@mdebbarmdebbar commented Jun 8, 2023•
edited by ditman
Loading

Copy link
Copy Markdown
Contributor

The following APIs are now exposed through dart:ui_web which eliminates the need for shims:

  • platformViewRegistry
  • webOnlyAssetManager
  • urlStrategy

Issues

Minimal stable version

THIS PR CANNOT LAND UNTIL THE NEW dart:ui_web APIS MAKE IT INTO A STABLE FLUTTER RELEASE.

@mdebbar
mdebbar requested a review from ditmanJune 8, 2023 18:44
@stuartmorgan-g

stuartmorgan-g commented Jul 13, 2023

Copy link
Copy Markdown
Collaborator

Update from triage: still waiting on a new stable release.

@ditman

ditman commented Aug 1, 2023

Copy link
Copy Markdown
Member

@stuartmorgan can we have the waiting for stable update label in this repo as well?

@stuartmorgan-g

stuartmorgan-g commented Aug 2, 2023

Copy link
Copy Markdown
Collaborator

Done!

@stuartmorgan-gstuartmorgan-g added the waiting for stable update Can't be landed until functionality reaches the stable channel label Aug 2, 2023
@stuartmorgan-g

stuartmorgan-g commented Aug 2, 2023

Copy link
Copy Markdown
Collaborator

@mdebbar Could you add a link to the landed PR (or its commit) that this is waiting for, so that we can easily check its release labels when scanning PRs?

@ditman

ditman commented Aug 3, 2023

Copy link
Copy Markdown
Member

@stuartmorgan

This is the engine roll into flutter that has the changes that this needs: flutter/flutter@5a7ab5a

@mdebbar

mdebbar commented Aug 7, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks @ditman 🙏

@stuartmorgan-g

stuartmorgan-g commented Aug 24, 2023

Copy link
Copy Markdown
Collaborator

It looks like 3.13 has this commit, unless I read the commit tags wrong; trying tests again.

kevmoo
kevmoo reviewed Aug 29, 2023
View reviewed changes
Comment threadpackages/camera/camera_web/CHANGELOG.md Outdated
kevmoo
kevmoo reviewed Aug 29, 2023
View reviewed changes
Comment threadpackages/camera/camera_web/pubspec.yaml Outdated
kevmoo
kevmoo reviewed Aug 29, 2023
View reviewed changes
Comment threadpackages/google_maps_flutter/google_maps_flutter_web/pubspec.yaml Outdated
@mdebbar

mdebbar commented Aug 29, 2023

Copy link
Copy Markdown
ContributorAuthor

@stuartmorgan mind taking a look to make sure I'm doing things right? Specifically:

  • I only updated versions of the *_web packages. Should I also update the version of the root package?
  • I only bumped the flutter sdk version inside *_web packages. Should I do the same in root packages?

@stuartmorgan-g

stuartmorgan-g commented Aug 29, 2023

Copy link
Copy Markdown
Collaborator
  • I only updated versions of the *_web packages. Should I also update the version of the root package?

No, we only bump constraints in the app-facing package when it's actually necessary (e.g., when exposing a new feature in the app-facing package).

  • I only bumped the flutter sdk version inside *_web packages. Should I do the same in root packages?

No; the resolver will do the right thing. At some future point when the constraint in the app-facing package is updated (for whatever reason) that will have to happen, but CI will flag that because resolving will fail in the legacy tests.

@mdebbar
mdebbar marked this pull request as ready for review August 29, 2023 18:44
stuartmorgan-g
stuartmorgan-g approved these changes Aug 29, 2023
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I am sure not going to miss those shims.

@mdebbarmdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2023
@auto-submit
auto-submitBot merged commit bd97d29 into flutter:mainAug 30, 2023
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Aug 31, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 31, 2023
@engine-flutter-autoroll
bd97d29[web] Use new APIs fromdart:ui_web(flutter/packages#4168)
d72f4e2
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Aug 31, 2023
@engine-flutter-autoroll
Roll Packages from64af59etoe7d812c(6 revisions) (#133765)
28ec737
flutter/packages@64af59e...e7d812c
2023-08-30 50271102+talhakhan1297@users.noreply.github.com [path_provider] Fix93198: Added getDownloadsDirectory() for Android (flutter/packages#4708)
2023-08-30 stuartmorgan@google.com [in_app_purchase] Minor lint cleanup (flutter/packages#4818)
2023-08-30 tarrinneal@gmail.com [local_auth] Update to pigeon 11 and remove enum wrappers (flutter/packages#4809)
2023-08-30 vital@hey.com [image_picker] Fix link in README file. (flutter/packages#4775)
2023-08-30 mouad.debbar@gmail.com [web] Use new APIs from `dart:ui_web` (flutter/packages#4168)
2023-08-30 engine-flutter-autoroll@skia.org Roll Flutter from 6c95737 to 1fe2495 (24 revisions) (flutter/packages#4817)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@ditmanditman mentioned this pull request Sep 5, 2023
Closed
2 tasks
@reidbakerreidbaker mentioned this pull request Sep 15, 2023
Merged
11 tasks
@mdebbar
mdebbar deleted the dart_ui_web branch April 3, 2024 14:46
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@mdebbar
[web] Use new APIs fromdart:ui_web(flutter#4168)
c5e3661
The following APIs are now exposed through `dart:ui_web` which eliminates the need for shims:
- `platformViewRegistry`
- `webOnlyAssetManager`
- `urlStrategy`
## Issues
* Fixesflutter/flutter#55000
## Minimal `stable` version
THIS PR CANNOT LAND UNTIL THE NEW `dart:ui_web` APIS MAKE IT INTO A STABLE FLUTTER RELEASE.
* Needs flutter/flutter@5a7ab5a
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@mdebbar
[web] Use new APIs fromdart:ui_web(flutter#4168)
20559fa
The following APIs are now exposed through `dart:ui_web` which eliminates the need for shims:
- `platformViewRegistry`
- `webOnlyAssetManager`
- `urlStrategy`
## Issues
* Fixesflutter/flutter#55000
## Minimal `stable` version
THIS PR CANNOT LAND UNTIL THE NEW `dart:ui_web` APIS MAKE IT INTO A STABLE FLUTTER RELEASE.
* Needs flutter/flutter@5a7ab5a
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevmookevmookevmoo left review comments
@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@ditmanditmanAwaiting requested review from ditman

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: camerap: google_maps_flutterp: google_sign_inp: pointer_interceptorp: url_launcherp: video_playerp: webview_flutterplatform-webwaiting for stable updateCan't be landed until functionality reaches the stable channel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cleanup dart:ui shim for web-only APIs in web plugins.

4 participants

@mdebbar@stuartmorgan-g@ditman@kevmoo