Skip to content

[in_app_purchase] Minor lint cleanup - #4818

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
stuartmorgan-g:iap-cruft-cleanup
Aug 30, 2023
Merged

[in_app_purchase] Minor lint cleanup#4818
auto-submit[bot] merged 2 commits into
flutter:mainfrom
stuartmorgan-g:iap-cruft-cleanup

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Updates some lints for current versions of Flutter, reducing the need for // ignores.

Fixesflutter/flutter#131792

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@gmackallgmackall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android LGTM

@cyanglazcyanglaz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 30, 2023
@auto-submit
auto-submitBot merged commit 1f208aa into flutter:mainAug 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 31, 2023
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Aug 31, 2023
flutter/packages@64af59e...e7d812c
2023-08-30 50271102+talhakhan1297@users.noreply.github.com [path_provider] Fix93198: Added getDownloadsDirectory() for Android (flutter/packages#4708)
2023-08-30 stuartmorgan@google.com [in_app_purchase] Minor lint cleanup (flutter/packages#4818)
2023-08-30 tarrinneal@gmail.com [local_auth] Update to pigeon 11 and remove enum wrappers (flutter/packages#4809)
2023-08-30 vital@hey.com [image_picker] Fix link in README file. (flutter/packages#4775)
2023-08-30 mouad.debbar@gmail.com [web] Use new APIs from `dart:ui_web` (flutter/packages#4168)
2023-08-30 engine-flutter-autoroll@skia.org Roll Flutter from 6c95737 to 1fe2495 (24 revisions) (flutter/packages#4817)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbakerreidbaker mentioned this pull request Sep 15, 2023
11 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
Updates some lints for current versions of Flutter, reducing the need for `// ignore`s.
Fixesflutter/flutter#131792
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
Updates some lints for current versions of Flutter, reducing the need for `// ignore`s.
Fixesflutter/flutter#131792
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: in_app_purchaseplatform-androidplatform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[in_app_purchase] Remove cruft to support old versions of Flutter

3 participants

@stuartmorgan-g@cyanglaz@gmackall