Skip to content

[shared_preferences] Adds new clearWithParameters and getAllWithParameters methods to all platforms. - #4262

Merged
tarrinneal merged 2 commits into
flutter:mainfrom
tarrinneal:AL-P
Jun 29, 2023
Merged

[shared_preferences] Adds new clearWithParameters and getAllWithParameters methods to all platforms.#4262
tarrinneal merged 2 commits into
flutter:mainfrom
tarrinneal:AL-P

Conversation

@tarrinneal

@tarrinnealtarrinneal commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

Adds new clearWithParameters and getAllWithParameters methods.

part of flutter/flutter#128948

precursor to #3794

awaiting #4261

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@tarrinneal
tarrinneal marked this pull request as ready for review June 27, 2023 05:09
stuartmorgan-g
stuartmorgan-g requested changes Jun 27, 2023
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed the removals of the previous methods in the main review; see comments below.

Comment thread...ages/shared_preferences/shared_preferences_foundation/lib/shared_preferences_foundation.dart Outdated
Comment threadpackages/shared_preferences/shared_preferences_android/lib/shared_preferences_android.dart Outdated
Comment threadpackages/shared_preferences/shared_preferences_android/lib/shared_preferences_android.dart Outdated
Comment thread...ages/shared_preferences/shared_preferences_foundation/lib/shared_preferences_foundation.dart Outdated
Comment thread...hared_preferences/shared_preferences_foundation/test/shared_preferences_foundation_test.dart Outdated
Comment threadpackages/shared_preferences/shared_preferences_linux/lib/shared_preferences_linux.dart Outdated
@tarrinneal

tarrinneal commented Jun 27, 2023

Copy link
Copy Markdown
ContributorAuthor

Sorry, I missed the removals of the previous methods in the main review; see comments below.

I reverted those changes, I also caught a mistake in one of the ios implementations returning void instead of bool.

Sorry about the git reset, nothing else has changed besides that.

@tarrinneal
tarrinneal removed the request for review from stuartmorgan-gJune 28, 2023 01:57
stuartmorgan-g
stuartmorgan-g approved these changes Jun 28, 2023
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of small comments.

Comment threadpackages/shared_preferences/shared_preferences_foundation/pigeons/messages.dart Outdated
Comment thread...ages/shared_preferences/shared_preferences_windows/test/shared_preferences_windows_test.dart Outdated
Comment threadpackages/shared_preferences/shared_preferences_android/pigeons/messages.dart Outdated
@tarrinneal
tarrinneal merged commit d615371 into flutter:mainJun 29, 2023
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jun 30, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 30, 2023
@engine-flutter-autoroll
d615371[shared_preferences] Adds new clearWithParameters and getAllW…
01a5602
…ithParameters methods to all platforms. (flutter/packages#4262)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Jun 30, 2023
@engine-flutter-autoroll
Roll Packages fromd4752c4to53ed5a0(5 revisions) (#129837)
b1aa0d9
flutter/packages@d4752c4...53ed5a0
2023-06-30 me@jxstxn.dev [google_maps_flutter_web] Add padding to newLatLngBounds implementation (flutter/packages#3452)
2023-06-29 stuartmorgan@google.com [various] Remove unused flutter_driver dependencies (flutter/packages#4347)
2023-06-29 stuartmorgan@google.com [ci] Add LUCI version of dart unit tests (flutter/packages#4265)
2023-06-29 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.8.21 to 1.8.22 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4189)
2023-06-29 tarrinneal@gmail.com [shared_preferences] Adds new clearWithParameters and getAllWithParameters methods to all platforms. (flutter/packages#4262)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
Merged
Closed
@reidbakerreidbaker mentioned this pull request Jul 14, 2023
Merged
11 tasks
@reidbakerreidbaker mentioned this pull request Jul 26, 2023
Merged
11 tasks
@reidbakerreidbaker mentioned this pull request Aug 4, 2023
Merged
11 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@tarrinneal
[shared_preferences] Adds new clearWithParameters and getAllWithParam…
233ccb6
…eters methods to all platforms. (flutter#4262)
Adds new `clearWithParameters` and `getAllWithParameters` methods.
part of flutter/flutter#128948
precursor to flutter#3794
awaiting flutter#4261
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [relevant style guides] and ran the
auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
repo does use `dart format`.)
- [x] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated `pubspec.yaml` with an appropriate new version according
to the [pub versioning philosophy], or this PR is [exempt from version
changes].
- [x] I updated `CHANGELOG.md` to add a description of the change,
[following repository CHANGELOG style].
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[relevant style guides]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[pub versioning philosophy]: https://dart.dev/tools/pub/versioning
[exempt from version changes]:
https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version-and-changelog-updates
[following repository CHANGELOG style]:
https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@tarrinneal
[shared_preferences] Adds new clearWithParameters and getAllWithParam…
7180760
…eters methods to all platforms. (flutter#4262)
Adds new `clearWithParameters` and `getAllWithParameters` methods.
part of flutter/flutter#128948
precursor to flutter#3794
awaiting flutter#4261
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [relevant style guides] and ran the
auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
repo does use `dart format`.)
- [x] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated `pubspec.yaml` with an appropriate new version according
to the [pub versioning philosophy], or this PR is [exempt from version
changes].
- [x] I updated `CHANGELOG.md` to add a description of the change,
[following repository CHANGELOG style].
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[relevant style guides]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[pub versioning philosophy]: https://dart.dev/tools/pub/versioning
[exempt from version changes]:
https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version-and-changelog-updates
[following repository CHANGELOG style]:
https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@cbrackencbrackenAwaiting requested review from cbracken
@cyanglazcyanglazAwaiting requested review from cyanglaz
@reidbakerreidbakerAwaiting requested review from reidbaker
@ditmanditmanAwaiting requested review from ditman

Assignees

No one assigned

Labels

p: shared_preferencesplatform-androidplatform-linuxplatform-webplatform-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tarrinneal@stuartmorgan-g