Uh oh!
There was an error while loading. Please reload this page.
[various] Remove unused flutter_driver dependencies - #4347
Merged
auto-submit[bot] merged 4 commits intoJun 29, 2023
Conversation
stuartmorgan-g
requested review from
LouiseHsu, bparrishMines, camsim99, cbracken, cyanglaz, ditman, gmackall, hellohuanlin, reidbaker, tarrinneal and vashworth
as code ownersJune 29, 2023 19:08
hellohuanlin
approved these changes
Jun 29, 2023
stuartmorgan-g
commented
Jun 29, 2023
CollaboratorAuthor
Overrides: these are dev dependencies, so don't need to be versioned or mentioned in the changelog. |
ditman
approved these changes
Jun 29, 2023
ditman
left a comment
Member
There was a problem hiding this comment.
Yikes, big offender on this one. Thanks for the cleanup! LGTM!
stuartmorgan-g
commented
Jun 29, 2023
CollaboratorAuthor
I think I'm the offender; IIRC I did a bunch of the switch of the driver files to |
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 30, 2023
auto-submitBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 30, 2023
flutter/packages@d4752c4...53ed5a0 2023-06-30 me@jxstxn.dev [google_maps_flutter_web] Add padding to newLatLngBounds implementation (flutter/packages#3452) 2023-06-29 stuartmorgan@google.com [various] Remove unused flutter_driver dependencies (flutter/packages#4347) 2023-06-29 stuartmorgan@google.com [ci] Add LUCI version of dart unit tests (flutter/packages#4265) 2023-06-29 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.8.21 to 1.8.22 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4189) 2023-06-29 tarrinneal@gmail.com [shared_preferences] Adds new clearWithParameters and getAllWithParameters methods to all platforms. (flutter/packages#4262) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
11 tasks
11 tasks
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
`flutter_driver` has been mostly replaced by `integration_test`, but we still have a lot of remaining dependencies on the package. This removes the dependency from pubspec.yaml for all plugins that aren't actually `import`ing it. It also removes an old video_player test that has been disabled for years that was never updated from flutter_driver to integration_test; we've since added a lot more testing to video_player, so in practice this is cruft that we can just remove. Closesflutter/flutter#85224
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
`flutter_driver` has been mostly replaced by `integration_test`, but we still have a lot of remaining dependencies on the package. This removes the dependency from pubspec.yaml for all plugins that aren't actually `import`ing it. It also removes an old video_player test that has been disabled for years that was never updated from flutter_driver to integration_test; we've since added a lot more testing to video_player, so in practice this is cruft that we can just remove. Closesflutter/flutter#85224
JSUYA added a commit
to JSUYA/plugins
that referenced
this pull request
Aug 14, 2026
Reformat with dart format from Flutter 3.47.0 (Dart 3.13.0), and remove unused flutter_driver test files in sync with flutter/packages#4347.
JSUYA added a commit
to JSUYA/plugins
that referenced
this pull request
Aug 14, 2026
Reformat with dart format from Flutter 3.47.0 (Dart 3.13.0), and remove unused flutter_driver test files in sync with flutter/packages#4347.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter_driverhas been mostly replaced byintegration_test, but we still have a lot of remaining dependencies on the package. This removes the dependency from pubspec.yaml for all plugins that aren't actuallyimporting it.It also removes an old video_player test that has been disabled for years that was never updated from flutter_driver to integration_test; we've since added a lot more testing to video_player, so in practice this is cruft that we can just remove.
Closesflutter/flutter#85224
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).