Skip to content

[webview_flutter] Add a method for getting the user agent - #4472

Merged
auto-submit[bot] merged 17 commits into
flutter:mainfrom
bparrishMines:getUAS
Sep 30, 2023
Merged

[webview_flutter] Add a method for getting the user agent#4472
auto-submit[bot] merged 17 commits into
flutter:mainfrom
bparrishMines:getUAS

Conversation

@bparrishMines

@bparrishMinesbparrishMines commented Jul 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Aggregate PR for adding a method for retrieving the user agent.

Internal: b/272582342

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMinesbparrishMines added the federated: all_changes PR that contains changes for all packages for a federated plugin change label Jul 14, 2023
@bparrishMinesbparrishMines changed the title Get uas[webview_flutter] Add a method for getting the user agentJul 14, 2023
@bparrishMines
bparrishMines marked this pull request as ready for review July 14, 2023 19:09
@bparrishMines
bparrishMines requested review from stuartmorgan-g and removed request for ditmanJuly 14, 2023 19:12
stuartmorgan-g
stuartmorgan-g requested changes Jul 17, 2023
View reviewed changes
Comment threadpackages/webview_flutter/webview_flutter_android/test/android_webview_controller_test.dart Outdated
Comment threadpackages/webview_flutter/webview_flutter_wkwebview/test/src/web_kit/web_kit_test.dart Outdated
Comment threadpackages/webview_flutter/webview_flutter_wkwebview/test/webkit_webview_controller_test.dart Outdated
Comment threadpackages/webview_flutter/webview_flutter_wkwebview/test/webkit_webview_controller_test.dart Outdated
Comment threadpackages/webview_flutter/webview_flutter/test/webview_controller_test.dart Outdated
Comment thread..._android/android/src/main/java/io/flutter/plugins/webviewflutter/WebSettingsHostApiImpl.java Outdated
webSettings.setTextZoom(textZoom.intValue());
}

@Nullable

@stuartmorgan-gstuartmorgan-gJul 17, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the underlying API really return a nullable string?

@bparrishMinesbparrishMinesJul 25, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out and it looks like it is always nonnull. Updated.

Comment thread...flutter_android/android/src/test/java/io/flutter/plugins/webviewflutter/WebSettingsTest.java Outdated
Comment thread...s/webview_flutter/webview_flutter_wkwebview/example/ios/RunnerTests/FWFWebViewHostApiTests.m Outdated
Comment threadpackages/webview_flutter/webview_flutter_wkwebview/pigeons/web_kit.dart Outdated
Comment threadpackages/webview_flutter/webview_flutter_wkwebview/lib/src/webkit_webview_controller.dart Outdated
@ditman

ditman commented Jul 19, 2023

Copy link
Copy Markdown
Member

I'll keep an eye out for when this lands, the _web version of this should be very simple to add!

stuartmorgan-g
stuartmorgan-g approved these changes Jul 25, 2023
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMinesbparrishMines mentioned this pull request Jul 25, 2023
Merged
11 tasks
auto-submitBot pushed a commit that referenced this pull request Aug 15, 2023
@bparrishMines
[webview_flutter_platform_interface] Adds support for retrieving user…
93455e0
… agent (#4563)
Platform interface portion of #4472
@bparrishMinesbparrishMines mentioned this pull request Sep 14, 2023
Merged
11 tasks
auto-submitBot pushed a commit that referenced this pull request Sep 29, 2023
@bparrishMines
[webview_flutter_android][webview_flutter_wkwebview] Adds support for…
b3138a6
… `getUserAgent` for `webview_flutter` platform implementations (#4927)
Platform implementations for #4472
@bparrishMinesbparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 30, 2023
@auto-submit
auto-submitBot merged commit f68661d into flutter:mainSep 30, 2023
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Oct 2, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2023
@engine-flutter-autoroll
f68661d[webview_flutter] Add a method for getting the user agent (fl…
7f46b71
…utter/packages#4472)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Oct 2, 2023
@engine-flutter-autoroll
Roll Packages fromd0e9a0etoe2ac440(12 revisions) (#135859)
0562f72
flutter/packages@d0e9a0e...e2ac440
2023-10-01 engine-flutter-autoroll@skia.org Roll Flutter from d3df8f6 to d42313c (4 revisions) (flutter/packages#5044)
2023-10-01 maurits@vnbskm.nl [webview_flutter] Adds app facing implementation to override console log (flutter/packages#4705)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter from 57b5c3c to d3df8f6 (24 revisions) (flutter/packages#5043)
2023-09-30 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Add a method for getting the user agent (flutter/packages#4472)
2023-09-29 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Fix race condition in flaky test (flutter/packages#5037)
2023-09-29 stuartmorgan@google.com [ci] Wait for LUCI test checkin in `release` (flutter/packages#4911)
2023-09-29 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Adds support for `getUserAgent` for `webview_flutter` platform implementations (flutter/packages#4927)
2023-09-29 stuartmorgan@google.com [ci] Disable maps tests in Android emulator (flutter/packages#5003)
2023-09-29 33461698+BradenBagby@users.noreply.github.com [camera] Dispose resources correctly on setDescription (flutter/packages#4003)
2023-09-29 maurits@vnbskm.nl [webview_flutter_android] Adds Android implementation to override console log (flutter/packages#4702)
2023-09-29 stuartmorgan@google.com [camera] Remove `@throw` from iOS implementation (flutter/packages#5034)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter from ff4a0f6 to 57b5c3c (47 revisions) (flutter/packages#5036)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@bparrishMines
bparrishMines deleted the getUAS branch October 2, 2023 17:30
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll@Mairramer
Roll Packages fromd0e9a0etoe2ac440(12 revisions) (flutter#135859)
3a11781
flutter/packages@d0e9a0e...e2ac440
2023-10-01 engine-flutter-autoroll@skia.org Roll Flutter from d3df8f6 to d42313c (4 revisions) (flutter/packages#5044)
2023-10-01 maurits@vnbskm.nl [webview_flutter] Adds app facing implementation to override console log (flutter/packages#4705)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter from 57b5c3c to d3df8f6 (24 revisions) (flutter/packages#5043)
2023-09-30 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Add a method for getting the user agent (flutter/packages#4472)
2023-09-29 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Fix race condition in flaky test (flutter/packages#5037)
2023-09-29 stuartmorgan@google.com [ci] Wait for LUCI test checkin in `release` (flutter/packages#4911)
2023-09-29 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Adds support for `getUserAgent` for `webview_flutter` platform implementations (flutter/packages#4927)
2023-09-29 stuartmorgan@google.com [ci] Disable maps tests in Android emulator (flutter/packages#5003)
2023-09-29 33461698+BradenBagby@users.noreply.github.com [camera] Dispose resources correctly on setDescription (flutter/packages#4003)
2023-09-29 maurits@vnbskm.nl [webview_flutter_android] Adds Android implementation to override console log (flutter/packages#4702)
2023-09-29 stuartmorgan@google.com [camera] Remove `@throw` from iOS implementation (flutter/packages#5034)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter from ff4a0f6 to 57b5c3c (47 revisions) (flutter/packages#5036)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Jyndigo pushed a commit to uesp/webview_flutter_x that referenced this pull request Jun 24, 2025
@bparrishMines
[webview_flutter_android][webview_flutter_wkwebview] Adds support for…
c394ea7
… `getUserAgent` for `webview_flutter` platform implementations (#4927)
Platform implementations for flutter/packages#4472
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@bparrishMines
[webview_flutter_platform_interface] Adds support for retrieving user…
4770a8d
… agent (flutter#4563)
Platform interface portion of flutter#4472
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@bparrishMines
[webview_flutter_android][webview_flutter_wkwebview] Adds support for…
182230d
… `getUserAgent` for `webview_flutter` platform implementations (flutter#4927)
Platform implementations for flutter#4472
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@bparrishMines
[webview_flutter] Add a method for getting the user agent (flutter#4472)
8b6fbf8
Aggregate PR for adding a method for retrieving the user agent. Internal: b/272582342
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@bparrishMines
[webview_flutter_platform_interface] Adds support for retrieving user…
bae6c10
… agent (flutter#4563)
Platform interface portion of flutter#4472
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@bparrishMines
[webview_flutter_android][webview_flutter_wkwebview] Adds support for…
0ea0938
… `getUserAgent` for `webview_flutter` platform implementations (flutter#4927)
Platform implementations for flutter#4472
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@bparrishMines
[webview_flutter] Add a method for getting the user agent (flutter#4472)
bcf3d03
Aggregate PR for adding a method for retrieving the user agent. Internal: b/272582342
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@cyanglazcyanglazAwaiting requested review from cyanglaz

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appfederated: all_changesPR that contains changes for all packages for a federated plugin changep: webview_flutter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bparrishMines@ditman@stuartmorgan-g