Skip to content

[webview_flutter_android][webview_flutter_wkwebview] Adds support for getUserAgent for webview_flutter platform implementations - #4927

Merged
auto-submit[bot] merged 9 commits into
flutter:mainfrom
bparrishMines:getUAS_impls
Sep 29, 2023
Merged

[webview_flutter_android][webview_flutter_wkwebview] Adds support for getUserAgent for webview_flutter platform implementations#4927
auto-submit[bot] merged 9 commits into
flutter:mainfrom
bparrishMines:getUAS_impls

Conversation

@bparrishMines

@bparrishMinesbparrishMines commented Sep 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Platform implementations for #4472

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMinesbparrishMines added the federated: partial_changes PR that contains changes for only a single package of a federated plugin change label Sep 14, 2023
stuartmorgan-g
stuartmorgan-g approved these changes Sep 14, 2023
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMinesbparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 25, 2023
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 25, 2023
@auto-submit

auto-submitBot commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages/4927, due to - The status or check suite Linux_android android_build_all_packages stable has failed. Please fix the issues identified (or deflake) before re-applying this label.

@bparrishMinesbparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 29, 2023
@auto-submit
auto-submitBot merged commit b3138a6 into flutter:mainSep 29, 2023
@bparrishMines
bparrishMines deleted the getUAS_impls branch September 29, 2023 23:08
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Oct 2, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2023
@engine-flutter-autoroll
b3138a6[webview_flutter_android][webview_flutter_wkwebview] Adds sup…
8f6018f
…port for `getUserAgent` for `webview_flutter` platform implementations (flutter/packages#4927)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Oct 2, 2023
@engine-flutter-autoroll
Roll Packages fromd0e9a0etoe2ac440(12 revisions) (#135859)
0562f72
flutter/packages@d0e9a0e...e2ac440
2023-10-01 engine-flutter-autoroll@skia.org Roll Flutter from d3df8f6 to d42313c (4 revisions) (flutter/packages#5044)
2023-10-01 maurits@vnbskm.nl [webview_flutter] Adds app facing implementation to override console log (flutter/packages#4705)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter from 57b5c3c to d3df8f6 (24 revisions) (flutter/packages#5043)
2023-09-30 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Add a method for getting the user agent (flutter/packages#4472)
2023-09-29 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Fix race condition in flaky test (flutter/packages#5037)
2023-09-29 stuartmorgan@google.com [ci] Wait for LUCI test checkin in `release` (flutter/packages#4911)
2023-09-29 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Adds support for `getUserAgent` for `webview_flutter` platform implementations (flutter/packages#4927)
2023-09-29 stuartmorgan@google.com [ci] Disable maps tests in Android emulator (flutter/packages#5003)
2023-09-29 33461698+BradenBagby@users.noreply.github.com [camera] Dispose resources correctly on setDescription (flutter/packages#4003)
2023-09-29 maurits@vnbskm.nl [webview_flutter_android] Adds Android implementation to override console log (flutter/packages#4702)
2023-09-29 stuartmorgan@google.com [camera] Remove `@throw` from iOS implementation (flutter/packages#5034)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter from ff4a0f6 to 57b5c3c (47 revisions) (flutter/packages#5036)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@engine-flutter-autoroll@Mairramer
Roll Packages fromd0e9a0etoe2ac440(12 revisions) (flutter#135859)
3a11781
flutter/packages@d0e9a0e...e2ac440
2023-10-01 engine-flutter-autoroll@skia.org Roll Flutter from d3df8f6 to d42313c (4 revisions) (flutter/packages#5044)
2023-10-01 maurits@vnbskm.nl [webview_flutter] Adds app facing implementation to override console log (flutter/packages#4705)
2023-09-30 engine-flutter-autoroll@skia.org Roll Flutter from 57b5c3c to d3df8f6 (24 revisions) (flutter/packages#5043)
2023-09-30 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Add a method for getting the user agent (flutter/packages#4472)
2023-09-29 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Fix race condition in flaky test (flutter/packages#5037)
2023-09-29 stuartmorgan@google.com [ci] Wait for LUCI test checkin in `release` (flutter/packages#4911)
2023-09-29 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Adds support for `getUserAgent` for `webview_flutter` platform implementations (flutter/packages#4927)
2023-09-29 stuartmorgan@google.com [ci] Disable maps tests in Android emulator (flutter/packages#5003)
2023-09-29 33461698+BradenBagby@users.noreply.github.com [camera] Dispose resources correctly on setDescription (flutter/packages#4003)
2023-09-29 maurits@vnbskm.nl [webview_flutter_android] Adds Android implementation to override console log (flutter/packages#4702)
2023-09-29 stuartmorgan@google.com [camera] Remove `@throw` from iOS implementation (flutter/packages#5034)
2023-09-29 engine-flutter-autoroll@skia.org Roll Flutter from ff4a0f6 to 57b5c3c (47 revisions) (flutter/packages#5036)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@bparrishMines
[webview_flutter_android][webview_flutter_wkwebview] Adds support for…
182230d
… `getUserAgent` for `webview_flutter` platform implementations (flutter#4927)
Platform implementations for flutter#4472
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@bparrishMines
[webview_flutter_android][webview_flutter_wkwebview] Adds support for…
0ea0938
… `getUserAgent` for `webview_flutter` platform implementations (flutter#4927)
Platform implementations for flutter#4472
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@cyanglazcyanglazAwaiting requested review from cyanglaz

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appfederated: partial_changesPR that contains changes for only a single package of a federated plugin changep: webview_flutterplatform-androidplatform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bparrishMines@stuartmorgan-g