Migrate Material curves to new names by guidezpl · Pull Request #4898 · flutter/packages

guidezpl · 2023-09-11T11:15:19Z

Cleanup following flutter/flutter#129942, which will allow the landing of the deprecation in flutter/flutter#134417.

flutter-dashboard · 2023-09-11T11:15:21Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

goderbauer

LGTM

goderbauer · 2023-09-11T17:42:57Z

Oh, but looks like this hasn't landed in stable yet (see failing checks)?

Hixie · 2023-09-11T18:11:52Z

test-exempt: refactor with no semantic change

guidezpl · 2023-09-12T06:41:18Z

Yes, and after reading up on https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#supported-flutter-versions, I'll hold off on landing this until the next stable release

ditman · 2023-12-06T23:30:35Z

This merge is breaking the tree:

Linux analyze_legacy N-1

I think this is signaling that the minimum version of the sdk constraint of the package was not updated to the current stable.

Bumps minimum Fluter version to fix#4898 (comment).

guidezpl · 2023-12-07T11:45:34Z

Ah thank you, I missed this instruction in https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#supported-flutter-versions

stuartmorgan-g · 2023-12-07T12:45:16Z

@guidezpl Please do not ever merge a PR that has a failing presubmit test in this repository unless the PR is fixing tree breakage.

guidezpl · 2023-12-07T14:08:45Z

Can the repository rules be updated to make this clear? Otherwise, this check just looks advisory

stuartmorgan-g · 2023-12-07T15:24:38Z

Can the repository rules be updated to make this clear?

As far as I know the configuration of this repository is the same as the other Flutter repositories. I don't have the ability to check as I'm not an admin, so if you want to see repo configuration change you would need to file an infra issue. (I'm not sure that setting would allow for fixing tree breakage though?)

Otherwise, this check just looks advisory

Our documented process for all Flutter repos is to use autosubmit, which would not have landed your PR, and would have left a comment saying it couldn't be landed with that failure. If you are bypassing the documented process, you are responsible for following documented policies (in this case "Make sure your PR passes all the pre-commit tests.")

flutter/packages@ca16173...15584a3 2023-12-07 ditman@gmail.com [gis_web] Migrate to package:web. (flutter/packages#5581) 2023-12-07 kevmoo@users.noreply.github.com Drop quiver usage in several packages (flutter/packages#5595) 2023-12-07 stuartmorgan@google.com [video_player] Unfork publish: for macOS (flutter/packages#5578) 2023-12-07 kevmoo@users.noreply.github.com [web_benchmarks] migrate to pkg:web (flutter/packages#5592) 2023-12-07 43054281+camsim99@users.noreply.github.com [animations] Bump minimum supported Dart version to 3.2 (flutter/packages#5598) 2023-12-06 43054281+camsim99@users.noreply.github.com [animations] Bump minimum Flutter version (flutter/packages#5596) 2023-12-06 6655696+guidezpl@users.noreply.github.com Migrate Material curves to new names (flutter/packages#4898) 2023-12-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[pointer_interceptor] Add ios implementation and move web implementation to federated structure" (flutter/packages#5591) 2023-12-06 louisehsu@google.com [pointer_interceptor] Add ios implementation and move web implementation to federated structure (flutter/packages#5500) 2023-12-06 stuartmorgan@google.com [pigeon] Use dart:io output inheritance for tooling (flutter/packages#5536) 2023-12-06 43759233+kenzieschmoll@users.noreply.github.com Fix benchmark reload bug and migrate away from deprecated `js_util` APIs (flutter/packages#5577) 2023-12-06 stuartmorgan@google.com [google_sign_in] Add macOS support (flutter/packages#4962) 2023-12-06 ian@hixie.ch [rfw,flutter_markdown] Apparently you need a comma to end an //ignore (flutter/packages#5582) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

guidezpl · 2023-12-12T15:14:19Z

Fair enough. Regarding repository rules, I'll file a separate issue. I like the way GitHub lets you bypass the rules for cases such as fixing the tree

These have 1:1 replacements with a new name, introduced in #129942 Land after flutter/packages#4898 Part of #116525 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

Cleanup following flutter/flutter#129942, which will allow the landing of the deprecation in flutter/flutter#134417. Part of flutter/flutter#116525

Bumps minimum Fluter version to fixflutter#4898 (comment).

These have 1:1 replacements with a new name, introduced in flutter/flutter#129942 Land after flutter#4898 Part of flutter/flutter#116525 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

Cleanup following flutter/flutter#129942, which will allow the landing of the deprecation in flutter/flutter#134417. Part of flutter/flutter#116525

Bumps minimum Fluter version to fixflutter#4898 (comment).

Migrate Material curves
7104ef3

guidezpl requested a review from goderbauer as a code owner September 11, 2023 11:15

github-actionsBot added the p: animations label Sep 11, 2023

guidezpl mentioned this pull request Sep 11, 2023
Deprecate M2 curves flutter/flutter#134417
Merged
8 tasks

guidezpland others added 3 commits September 11, 2023 15:13

bump package and flutter versions
8387f6b

fix dart sdk lower bound
64c3ef7

Update CHANGELOG.md
d51986d

goderbauer approved these changes Sep 11, 2023
View reviewed changes

stuartmorgan-g added the waiting for stable update Can't be landed until functionality reaches the stable channel label Sep 21, 2023

guidezpl added 3 commits December 5, 2023 15:15

Merge branch 'main' into m3-motion
63c3c24

Update CHANGELOG.md
45d40f7

bump SDK, update changelog title
7800765

guidezpl added waiting for tree to go green and removed waiting for stable update Can't be landed until functionality reaches the stable channel labels Dec 5, 2023

Merge branch 'main' into m3-motion
9ba1502

guidezpl merged commit 74b0892 into mainDec 6, 2023

guidezpl deleted the m3-motion branch December 6, 2023 21:07

camsim99 mentioned this pull request Dec 6, 2023
[animations] Bump minimum Flutter version #5596
Merged
11 tasks

auto-submitBot pushed a commit that referenced this pull request Dec 6, 2023
[animations] Bump minimum Flutter version (#5596)
c704824
Bumps minimum Fluter version to fix#4898 (comment).

engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Roll Packages from ca16173e67e4 to 15584a394d36 (13 revisions) flutter/flutter#139736
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 7, 2023
74b0892Migrate Material curves to new names (flutter/packages#4898)
d658508

reidbaker mentioned this pull request Jan 12, 2024
Dialog Debug #5881
Closed

reidbaker mentioned this pull request Jan 19, 2024
[in_app_purchase] Add play country code api #5941
Merged
12 tasks

reidbaker mentioned this pull request Feb 19, 2024
[in_app_purchase_android] Add UserChoiceBilling mode. #6162
Merged
16 tasks

creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
[animations] Bump minimum Flutter version (flutter#5596)
d5aeec7
Bumps minimum Fluter version to fixflutter#4898 (comment).

bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
[animations] Bump minimum Flutter version (flutter#5596)
9e1d8b9
Bumps minimum Fluter version to fixflutter#4898 (comment).

Navigation Menu

Uh oh!

Migrate Material curves to new names - #4898

Migrate Material curves to new names#4898
guidezpl merged 8 commits into
mainfrom
m3-motion

guidezpl commented Sep 11, 2023•
edited
Loading

Uh oh!

flutter-dashboardBot commented Sep 11, 2023

Uh oh!

goderbauer left a comment

Uh oh!

goderbauer commented Sep 11, 2023

Uh oh!

Hixie commented Sep 11, 2023

Uh oh!

guidezpl commented Sep 12, 2023

Uh oh!

ditman commented Dec 6, 2023

Uh oh!

guidezpl commented Dec 7, 2023

Uh oh!

stuartmorgan-g commented Dec 7, 2023•
edited
Loading

Uh oh!

guidezpl commented Dec 7, 2023

Uh oh!

stuartmorgan-g commented Dec 7, 2023

Uh oh!

guidezpl commented Dec 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

guidezpl commented Sep 11, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboardBot commented Sep 11, 2023

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

goderbauer commented Sep 11, 2023

Uh oh!

Hixie commented Sep 11, 2023

Uh oh!

guidezpl commented Sep 12, 2023

Uh oh!

ditman commented Dec 6, 2023

Uh oh!

guidezpl commented Dec 7, 2023

Uh oh!

stuartmorgan-g commented Dec 7, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guidezpl commented Dec 7, 2023

Uh oh!

stuartmorgan-g commented Dec 7, 2023

Uh oh!

guidezpl commented Dec 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

guidezpl commented Sep 11, 2023•
edited
Loading

stuartmorgan-g commented Dec 7, 2023•
edited
Loading