Uh oh!
There was an error while loading. Please reload this page.
Fix benchmark reload bug and migrate away from deprecated js_util APIs - #5577
Merged
Conversation
initialPagejs_util APIs
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 7, 2023
auto-submitBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 7, 2023
flutter/packages@ca16173...15584a3 2023-12-07 ditman@gmail.com [gis_web] Migrate to package:web. (flutter/packages#5581) 2023-12-07 kevmoo@users.noreply.github.com Drop quiver usage in several packages (flutter/packages#5595) 2023-12-07 stuartmorgan@google.com [video_player] Unfork publish: for macOS (flutter/packages#5578) 2023-12-07 kevmoo@users.noreply.github.com [web_benchmarks] migrate to pkg:web (flutter/packages#5592) 2023-12-07 43054281+camsim99@users.noreply.github.com [animations] Bump minimum supported Dart version to 3.2 (flutter/packages#5598) 2023-12-06 43054281+camsim99@users.noreply.github.com [animations] Bump minimum Flutter version (flutter/packages#5596) 2023-12-06 6655696+guidezpl@users.noreply.github.com Migrate Material curves to new names (flutter/packages#4898) 2023-12-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[pointer_interceptor] Add ios implementation and move web implementation to federated structure" (flutter/packages#5591) 2023-12-06 louisehsu@google.com [pointer_interceptor] Add ios implementation and move web implementation to federated structure (flutter/packages#5500) 2023-12-06 stuartmorgan@google.com [pigeon] Use dart:io output inheritance for tooling (flutter/packages#5536) 2023-12-06 43759233+kenzieschmoll@users.noreply.github.com Fix benchmark reload bug and migrate away from deprecated `js_util` APIs (flutter/packages#5577) 2023-12-06 stuartmorgan@google.com [google_sign_in] Add macOS support (flutter/packages#4962) 2023-12-06 ian@hixie.ch [rfw,flutter_markdown] Apparently you need a comma to end an //ignore (flutter/packages#5582) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…PIs (flutter#5577) This PR: - Ensures the benchmark client reloads with the proper `initialPage`. Without this change, the benchmark app may not reload properly, which causes a hang on the server. - Migrates away from `js_util` APIs to `dart:ui_web`. This was causing spurious deprecation warnings. The changes in this PR are test covered by existing tests.
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…PIs (flutter#5577) This PR: - Ensures the benchmark client reloads with the proper `initialPage`. Without this change, the benchmark app may not reload properly, which causes a hang on the server. - Migrates away from `js_util` APIs to `dart:ui_web`. This was causing spurious deprecation warnings. The changes in this PR are test covered by existing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
initialPage. Without this change, the benchmark app may not reload properly, which causes a hang on the server.js_utilAPIs todart:ui_web. This was causing spurious deprecation warnings.The changes in this PR are test covered by existing tests.