Skip to content

[cupertino_icons] Add example to cupertino icons - #5312

Merged
auto-submit[bot] merged 14 commits into
flutter:mainfrom
foxtrotravi:add_example_to_cupertino_icons
Feb 12, 2024
Merged

[cupertino_icons] Add example to cupertino icons#5312
auto-submit[bot] merged 14 commits into
flutter:mainfrom
foxtrotravi:add_example_to_cupertino_icons

Conversation

@foxtrotravi

@foxtrotravifoxtrotravi commented Nov 3, 2023•
edited by stuartmorgan-g
Loading

Copy link
Copy Markdown
Contributor

Description of PR:

Adding an example app to showcase the usage of cupertino_icons. This addition will also increase the pub points of the package and will be helpful for other developers to quickly find relevant examples.

Fixesflutter/flutter#137682

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

stuartmorgan-g
stuartmorgan-g requested changes Nov 4, 2023
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds a large amount of boilerplate, and doesn't appear to offer any benefits that https://api.flutter.dev/flutter/cupertino/CupertinoIcons-class.html doesn't. An example/example.md file that links to https://api.flutter.dev/flutter/cupertino/CupertinoIcons-class.html seems like it would achieve the goals of the linked issue in a much simpler way.

@foxtrotravi

foxtrotravi commented Nov 5, 2023

Copy link
Copy Markdown
ContributorAuthor

Okay @stuartmorgan I will update this PR to remove the app & add an example.md file which links to the documentation.

@foxtrotravi
foxtrotraviforce-pushed the add_example_to_cupertino_icons branch from 86a6c9f to fb8daf3CompareNovember 5, 2023 06:33
@foxtrotravi

foxtrotravi commented Nov 5, 2023

Copy link
Copy Markdown
ContributorAuthor

@stuartmorgan I have updated the PR. Please review.

stuartmorgan-g
stuartmorgan-g requested changes Nov 6, 2023
View reviewed changes
Comment threadthird_party/packages/cupertino_icons/CHANGELOG.md Outdated
Comment threadthird_party/packages/cupertino_icons/example/example.md Outdated
Comment threadthird_party/packages/cupertino_icons/example/example.md Outdated
@foxtrotravi
foxtrotraviforce-pushed the add_example_to_cupertino_icons branch 3 times, most recently from 46cedc2 to a365fd4CompareNovember 24, 2023 16:52
stuartmorgan-g
stuartmorgan-g requested changes Nov 29, 2023
View reviewed changes
Comment threadthird_party/packages/cupertino_icons/example/example.md Outdated
@foxtrotravi
foxtrotraviforce-pushed the add_example_to_cupertino_icons branch 2 times, most recently from 787b811 to 3a76ff3CompareDecember 2, 2023 05:18
@foxtrotravi
foxtrotraviforce-pushed the add_example_to_cupertino_icons branch 2 times, most recently from 0a2746d to d779fa6CompareDecember 14, 2023 09:15
stuartmorgan-g
stuartmorgan-g requested changes Dec 14, 2023
View reviewed changes
Comment threadthird_party/packages/cupertino_icons/CHANGELOG.md Outdated
Comment threadthird_party/packages/cupertino_icons/example/example.md Outdated
Comment threadthird_party/packages/cupertino_icons/example/example.md Outdated
Comment threadthird_party/packages/cupertino_icons/pubspec.yaml Outdated
Comment threadthird_party/packages/cupertino_icons/test/cupertino_icons_test.dart Outdated
@foxtrotravi
foxtrotraviforce-pushed the add_example_to_cupertino_icons branch from d779fa6 to f977c41CompareDecember 25, 2023 04:21
@stuartmorgan-gstuartmorgan-g mentioned this pull request Jan 2, 2024
Merged
@stuartmorgan-g

stuartmorgan-g commented Jan 2, 2024

Copy link
Copy Markdown
Collaborator

Once #5775 is reviewed and landed, merge main into this PR should fix the CI failures.

@MitchellGoodwinMitchellGoodwin mentioned this pull request Jan 2, 2024
Closed
@foxtrotravi

foxtrotravi commented Jan 26, 2024

Copy link
Copy Markdown
ContributorAuthor

Once #5775 is reviewed and landed, merge main into this PR should fix the CI failures.

Okay @stuartmorgan

@stuartmorgan-g

stuartmorgan-g commented Jan 26, 2024

Copy link
Copy Markdown
Collaborator

The failure this time is something that needs to be fixed in the PR due to a recently enabled lint; see https://github.com/flutter/packages/pull/5717/files#diff-86bbf9121116e918f9f79ccbb484b1d77358f1a30f092129f30333542f614c75 for an example of a fix for the same lint.

@foxtrotravi
foxtrotraviforce-pushed the add_example_to_cupertino_icons branch from 6a2025b to 3f24c60CompareJanuary 28, 2024 09:42
@foxtrotravi

foxtrotravi commented Feb 7, 2024

Copy link
Copy Markdown
ContributorAuthor

@stuartmorgan please review

stuartmorgan-g
stuartmorgan-g approved these changes Feb 12, 2024
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit. To @MitchellGoodwin for secondary review.

Comment threadthird_party/packages/cupertino_icons/test/cupertino_icons_test.dart
MitchellGoodwin
MitchellGoodwin approved these changes Feb 12, 2024
View reviewed changes

@MitchellGoodwinMitchellGoodwin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 12, 2024
@auto-submit
auto-submitBot merged commit d1f1f0f into flutter:mainFeb 12, 2024
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Feb 13, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 13, 2024
@engine-flutter-autoroll
d1f1f0f[cupertino_icons] Add example to cupertino icons (flutter/pac…
4b41554
…kages#5312)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Feb 13, 2024
@engine-flutter-autoroll
Roll Packages from0a69259to9385bbb(7 revisions) (#143366)
634fcc7
flutter/packages@0a69259...9385bbb
2024-02-13 louisehsu@google.com Convert startProductRequest(), finishTransaction(), restoreTransactions(), presentCodeRedemptionSheet() to pigeon (flutter/packages#6032)
2024-02-13 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20231013 to 20240205 in /packages/in_app_purchase/in_app_purchase/example/android/app (flutter/packages#6096)
2024-02-12 stuartmorgan@google.com [local_auth] Rename iOS classes (flutter/packages#6108)
2024-02-12 jakubwalusiak@gmail.com [video_player_android] Handle BehindLiveWindowException (flutter/packages#5869)
2024-02-12 reidbaker@google.com [in_app_purchase] Add alternative billing apis for android (flutter/packages#6056)
2024-02-12 stuartmorgan@google.com [webview_flutter] Update compileSdk to 34 (flutter/packages#6106)
2024-02-12 37270954+foxtrotravi@users.noreply.github.com [cupertino_icons] Add example to cupertino icons (flutter/packages#5312)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbakerreidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@foxtrotravi
[cupertino_icons] Add example to cupertino icons (flutter#5312)
75d384f
## Description of PR:
Adding an example app to showcase the usage of `cupertino_icons`. This addition will also increase the pub points of the package and will be helpful for other developers to quickly find relevant examples.
Fixesflutter/flutter#137682
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@foxtrotravi
[cupertino_icons] Add example to cupertino icons (flutter#5312)
43d719b
## Description of PR:
Adding an example app to showcase the usage of `cupertino_icons`. This addition will also increase the pub points of the package and will be helpful for other developers to quickly find relevant examples.
Fixesflutter/flutter#137682
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
+1 more reviewer
@MitchellGoodwinMitchellGoodwinMitchellGoodwin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: cupertino_icons

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[cupertino_icons] Add example

3 participants

@foxtrotravi@stuartmorgan-g@MitchellGoodwin