Uh oh!
There was an error while loading. Please reload this page.
Updated sample icons image - #5725
Conversation
updated sample icons image
already uploaded updated image
updated icons sample image path with the updated image path
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
MitchellGoodwin
commented
Jan 2, 2024
Just to be clear, besides the highlight on "alt" being removed, and the text for |
Musaddiq625
commented
Jan 2, 2024
@MitchellGoodwin while I was finding the new icon, this was keep irritating me 😑 |
MitchellGoodwin
commented
Jan 2, 2024
Image LGTM. @stuartmorgan looks like check fails because it needs the "override: no versioning needed" label, because the NEXT label is at the top of the changelog, though it looks like #5312 fixes that. Should this PR wait on #5312? They are somewhat related. |
stuartmorgan-g
commented
Jan 2, 2024
The check fails because this needs a version change. @Musaddiq625 in the future, please don't delete the checklist from the PR template; it's there for a reason. The checklist entry about versioning links to the docs that explain that this needs a version change, and why. |
stuartmorgan-g
commented
Jan 2, 2024
For reference: https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version and especially the first entry in https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#faq |
stuartmorgan-g
commented
Jan 30, 2024
@Musaddiq625 Are you still planning on updating this PR to add the version and changelog? See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version-and-changelog-updates for a link to tooling that will handle the details of doing that update. |
stuartmorgan-g
commented
Mar 5, 2024
Thank you for your contribution. I'm going to close this PR for now since there are outstanding comments, just to get this off our PR review queue. Please don't hesitate to submit a new PR if you have the time to address the review comments. Thanks! |
Updated sample icons image
gallery_preview_1.0.0 --> gallery_preview_1.0.1
Old

New:
