Skip to content

[image_picker] Remove input element after completion - #5654

Merged
auto-submit[bot] merged 5 commits into
flutter:mainfrom
Taskulu:fix/remove_input_element_after_complete
Jan 5, 2024
Merged

[image_picker] Remove input element after completion#5654
auto-submit[bot] merged 5 commits into
flutter:mainfrom
Taskulu:fix/remove_input_element_after_complete

Conversation

@Amir-P

@Amir-PAmir-P commented Dec 12, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR attempts to remove the input element added to the DOM after image selection is completed.

Fixesflutter/flutter#139442

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Amir-P
Amir-P requested a review from ditman as a code ownerDecember 12, 2023 17:06
@Amir-P
Amir-P marked this pull request as draft December 12, 2023 17:08
@Amir-P
Amir-Pforce-pushed the fix/remove_input_element_after_complete branch from 6b346ff to be60909CompareDecember 12, 2023 17:45
@Amir-P
Amir-P marked this pull request as ready for review December 12, 2023 17:45
@Amir-P
Amir-Pforce-pushed the fix/remove_input_element_after_complete branch from be60909 to 9a0fcd6CompareDecember 12, 2023 17:45
ditman
ditman requested changes Dec 13, 2023
View reviewed changes

@ditmanditman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small simplification of the fix.

Comment threadpackages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart Outdated
Comment threadpackages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart Outdated
@Amir-P

Amir-P commented Dec 14, 2023

Copy link
Copy Markdown
ContributorAuthor

Done. At first I wanted to just remove the input like you said but I saw that _target.children.clear() is called before injecting input element and thought you prefer that. @ditman

@Amir-P
Amir-P requested a review from ditmanDecember 14, 2023 20:09
@Amir-P

Amir-P commented Dec 21, 2023

Copy link
Copy Markdown
ContributorAuthor

@ditman could you review the PR please? This bug affects the usage of this plugin in our Web app.

ditman
ditman approved these changes Jan 3, 2024
View reviewed changes

@ditmanditman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning this up!

@ditmanditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024
@auto-submit

auto-submitBot commented Jan 3, 2024

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages/5654, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2024
@ditman

ditman commented Jan 3, 2024

Copy link
Copy Markdown
Member

Ah, we need two reviewers for this one!

/cc @mdebbar can you PTAL? (I think you commented in the OG issue!)

@ditman
ditman requested a review from mdebbarJanuary 3, 2024 23:53
mdebbar
mdebbar approved these changes Jan 4, 2024
View reviewed changes

@mdebbarmdebbar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ditmanditman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 5, 2024
@auto-submit
auto-submitBot merged commit 15115f3 into flutter:mainJan 5, 2024
@Amir-P
Amir-P deleted the fix/remove_input_element_after_complete branch January 5, 2024 06:28
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Jan 5, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 5, 2024
@engine-flutter-autoroll
15115f3[image_picker] Remove input element after completion (flutter…
3ae9904
…/packages#5654)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Jan 5, 2024
@engine-flutter-autoroll
Roll Packages from31fc7b5tob9b6d38(8 revisions) (#141021)
1fb12a1
flutter/packages@31fc7b5...b9b6d38
2024-01-05 engine-flutter-autoroll@skia.org Manual roll Flutter from 11def8e to cc40425 (118 revisions) (flutter/packages#5806)
2024-01-05 magder@google.com [ci] Run 'flutter build --config-only for iOS and macOS during fetch deps (flutter/packages#5804)
2024-01-05 amirpanahandeh@yahoo.com [image_picker] Remove input element after completion (flutter/packages#5654)
2024-01-05 stuartmorgan@google.com [video_player] Fix initial frame on macOS (flutter/packages#5781)
2024-01-05 tarrinneal@gmail.com [pigeon] java non null void (flutter/packages#5786)
2024-01-04 10687576+bparrishMines@users.noreply.github.com [file_selector_android] Attempt to close system dialogs before integration tests run (flutter/packages#5805)
2024-01-04 stuartmorgan@google.com [tool] Handle Flutter dev dependencies (flutter/packages#5775)
2024-01-04 40719830+Alex-Usmanov@users.noreply.github.com [url_launcher] Add `InAppBrowserConfiguration` parameter (flutter/packages#5758)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbakerreidbaker mentioned this pull request Jan 12, 2024
Closed
@reidbakerreidbaker mentioned this pull request Jan 19, 2024
Merged
12 tasks
@reidbakerreidbaker mentioned this pull request Feb 19, 2024
Merged
16 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@Amir-P
[image_picker] Remove input element after completion (flutter#5654)
3ca8b41
This PR attempts to remove the input element added to the DOM after image selection is completed.
Fixesflutter/flutter#139442
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@Amir-P
[image_picker] Remove input element after completion (flutter#5654)
f333aba
This PR attempts to remove the input element added to the DOM after image selection is completed.
Fixesflutter/flutter#139442
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ditmanditmanditman approved these changes
@mdebbarmdebbarmdebbar approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: image_pickerplatform-web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

image_picker shows an html input file button on web browser

3 participants

@Amir-P@ditman@mdebbar