Uh oh!
There was an error while loading. Please reload this page.
[video_player] Fix initial frame on macOS - #5781
Merged
auto-submit[bot] merged 6 commits intoJan 5, 2024
Merged
Conversation
As with seeking while paused, initing a video and not playing it should show the first frame as soon as it is available, but it currently doesn't because the display link isn't running. This uses the same mechanism added for seek to ensure that a video reports a frame to the engine (thus populating the initially-blank textture) as soon as one is available after the player is created, even if it's not played. Fixesflutter/flutter#140782
hellohuanlin
approved these changes
Jan 4, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Contributor
auto label is removed for flutter/packages/5781, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
auto label is removed for flutter/packages/5781, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
auto label is removed for flutter/packages/5781, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 5, 2024
auto-submitBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 5, 2024
flutter/packages@31fc7b5...b9b6d38 2024-01-05 engine-flutter-autoroll@skia.org Manual roll Flutter from 11def8e to cc40425 (118 revisions) (flutter/packages#5806) 2024-01-05 magder@google.com [ci] Run 'flutter build --config-only for iOS and macOS during fetch deps (flutter/packages#5804) 2024-01-05 amirpanahandeh@yahoo.com [image_picker] Remove input element after completion (flutter/packages#5654) 2024-01-05 stuartmorgan@google.com [video_player] Fix initial frame on macOS (flutter/packages#5781) 2024-01-05 tarrinneal@gmail.com [pigeon] java non null void (flutter/packages#5786) 2024-01-04 10687576+bparrishMines@users.noreply.github.com [file_selector_android] Attempt to close system dialogs before integration tests run (flutter/packages#5805) 2024-01-04 stuartmorgan@google.com [tool] Handle Flutter dev dependencies (flutter/packages#5775) 2024-01-04 40719830+Alex-Usmanov@users.noreply.github.com [url_launcher] Add `InAppBrowserConfiguration` parameter (flutter/packages#5758) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
As with seeking while paused, initing a video and not playing it should show the first frame as soon as it is available, but it currently doesn't because the display link isn't running. This uses the same mechanism added for seek to ensure that a video reports a frame to the engine (thus populating the initially-blank textture) as soon as one is available after the player is created, even if it's not played. Fixesflutter/flutter#140782
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
As with seeking while paused, initing a video and not playing it should show the first frame as soon as it is available, but it currently doesn't because the display link isn't running. This uses the same mechanism added for seek to ensure that a video reports a frame to the engine (thus populating the initially-blank textture) as soon as one is available after the player is created, even if it's not played. Fixesflutter/flutter#140782
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with seeking while paused, initing a video and not playing it should show the first frame as soon as it is available, but it currently doesn't because the display link isn't running. This uses the same mechanism added for seek to ensure that a video reports a frame to the engine (thus populating the initially-blank textture) as soon as one is available after the player is created, even if it's not played.
Fixesflutter/flutter#140782
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).