Skip to content

[url_launcher] Add InAppBrowserConfiguration parameter in implementations - #5759

Merged
auto-submit[bot] merged 37 commits into
flutter:mainfrom
Alex-Usmanov:show-title-implementations
Feb 13, 2024
Merged

[url_launcher] Add InAppBrowserConfiguration parameter in implementations#5759
auto-submit[bot] merged 37 commits into
flutter:mainfrom
Alex-Usmanov:show-title-implementations

Conversation

@Alex-Usmanov

@Alex-UsmanovAlex-Usmanov commented Dec 26, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Platform implementation portion of #5166. Implements InAppBrowserConfiguration support on Android, as well as support for InAppBrowserConfiguration.showTitle parameter for hiding/showing webpage title in Android Custom Tabs.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Alex-Usmanovand others added 29 commits October 17, 2023 11:50
@Alex-Usmanov
add android show title customization functionality
e41ea0e
@Alex-Usmanov
Pass the parameter
fb67692
@Alex-Usmanov
Dependency overrides
21cd06f
@Alex-Usmanov
Add tests for native side
276c08b
@Alex-Usmanov
Cover dart side with tests
1897451
@Alex-Usmanov
Format
5cd1709
@Alex-Usmanov
Reduce code repetition
bc943c5
@Alex-Usmanov
Revert todo change
d6306ba
@Alex-Usmanov
Wrap browser customization values in another configuration object
f59475b
@Alex-Usmanov
Remove deps overrides
157343b
@Alex-Usmanov
Revert more deps overrides
ae20b08
@Alex-Usmanov
Revert web as well
214b0a9
@Alex-Usmanov
Revert go_router
cd7dfc9
@Alex-Usmanov
Merge branch 'main' into main
d205c7c
@Alex-Usmanov
Merge remote-tracking branch 'upstream/main'
5eef662
@Alex-Usmanov
Format files
c86ff6e
@Alex-Usmanov
Fix tests
92b2197
@Alex-Usmanov
Add browseroptions to launchUrlString & add more tests
425617e
@Alex-Usmanov
Fix docstrings
ece2b78
@Alex-Usmanov
Revert test format change
3ddd644
@Alex-Usmanov
Fix tests
cd361d0
@Alex-Usmanov
Version bumps and changelogs
f0017b7
@Alex-Usmanov
Merge remote-tracking branch 'upstream/main'
6105671
@Alex-Usmanov
Return path-based dependencies
a50be0f
@Alex-Usmanov
Add licences
ef9c154
@Alex-Usmanov
Merge remote-tracking branch 'upstream/main'
f4b08cb
@Alex-Usmanov
Fix documentation & changelog
80d439b
@Alex-Usmanov
Merge remote-tracking branch 'upstream/main'
992d38e
@Alex-Usmanov
Revert everything except for android implementation
fd6f0f2
@Alex-Usmanov

Alex-Usmanov commented Dec 26, 2023

Copy link
Copy Markdown
ContributorAuthor

This is #5166 but only with android implementation changes

@stuartmorgan-g

stuartmorgan-g commented Jan 3, 2024

Copy link
Copy Markdown
Collaborator

Marking as a draft for now; the sub-PRs can't proceed without the dependencies landing first. The overall pre-review is done in the main PR.

@stuartmorgan-g
stuartmorgan-g marked this pull request as draft January 3, 2024 16:08
@Alex-Usmanov
Alex-Usmanov marked this pull request as ready for review January 25, 2024 12:41
@Alex-Usmanov

Alex-Usmanov commented Jan 25, 2024

Copy link
Copy Markdown
ContributorAuthor

@stuartmorgan sorry for tagging. could you please review this PR? it seems to have slipped through the cracks.
the dependencies are landed as far as I understand.

thanks!

@stuartmorgan-g

stuartmorgan-g commented Jan 29, 2024

Copy link
Copy Markdown
Collaborator

it seems to have slipped through the cracks.

You only marked it as ready for review at the end of last week; it often takes more than two working days for a PR to be reviewed.

@Alex-Usmanov

Alex-Usmanov commented Jan 29, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Sorry, did not mean to be pushy. I am just quite unaware of the process and assumed that once the child prs are going to be taken care of once the main one was approved (perhaps a silly assumption to make, you guys have a lot of responsibilities without this)

Since this one was in drafts for a month, I thought this one got lost.

Once again sorry for misunderstanding and disturbance!

@stuartmorgan-g

stuartmorgan-g commented Jan 29, 2024

Copy link
Copy Markdown
Collaborator

I am just quite unaware of the process

We follow the process described at https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins

Since this one was in drafts for a month, I thought this one got lost.

We don't generally look at draft PRs, we wait for the author of the PR to mark it as ready for review.

@stuartmorgan-gstuartmorgan-g mentioned this pull request Jan 30, 2024
Closed
11 tasks
stuartmorgan-g
stuartmorgan-g requested changes Feb 1, 2024
View reviewed changes
Comment threadpackages/url_launcher/url_launcher_android/CHANGELOG.md Outdated
Comment threadpackages/url_launcher/url_launcher_android/example/pubspec.yaml Outdated
Comment threadpackages/url_launcher/url_launcher_android/pigeons/messages.dart Outdated
Comment threadpackages/url_launcher/url_launcher_android/pubspec.yaml Outdated
@Alex-UsmanovAlex-Usmanov mentioned this pull request Feb 12, 2024
Merged
11 tasks
stuartmorgan-g
stuartmorgan-g approved these changes Feb 12, 2024
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @gmackall for secondary review.

gmackall
gmackall approved these changes Feb 13, 2024
View reviewed changes

@gmackallgmackall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2024
@auto-submit
auto-submitBot merged commit 1bc9fee into flutter:mainFeb 13, 2024
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Feb 14, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
1bc9fee[url_launcher] AddInAppBrowserConfigurationparameter in i…
86d192f
…mplementations (flutter/packages#5759)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
Roll Packages from9385bbbtoa864254(6 revisions) (#143454)
ee63848
flutter/packages@9385bbb...a864254
2024-02-14 matanlurey@users.noreply.github.com Allow deprecated members from the Dart SDK/Flutter Framework to roll in (flutter/packages#6111)
2024-02-14 43054281+camsim99@users.noreply.github.com [google_maps_flutter][iOS 12] Skip `testTakeSnapshot` (flutter/packages#6120)
2024-02-13 stuartmorgan@google.com [ci] Allow dependencies on local_auth_ios (flutter/packages#6116)
2024-02-13 40719830+Alex-Usmanov@users.noreply.github.com [url_launcher] Add `InAppBrowserConfiguration` parameter in implementations (flutter/packages#5759)
2024-02-13 16229121+leiatfly@users.noreply.github.com [flutter_markdown] Use Text.rich to replace RichText in Flutter Markdown (flutter/packages#6062)
2024-02-13 97943118+GavrielRosendorn74@users.noreply.github.com [google_maps_flutter][iOS 17] takeSnapshot FIX (flutter/packages#5823)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@Alex-Usmanov
[url_launcher] Add InAppBrowserConfiguration parameter in implement…
acbe410
…ations (flutter#5759)
Platform implementation portion of flutter#5166. Implements `InAppBrowserConfiguration` support on Android, as well as support for `InAppBrowserConfiguration.showTitle` parameter for hiding/showing webpage title in Android Custom Tabs.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@Alex-Usmanov
[url_launcher] Add InAppBrowserConfiguration parameter in implement…
5318953
…ations (flutter#5759)
Platform implementation portion of flutter#5166. Implements `InAppBrowserConfiguration` support on Android, as well as support for `InAppBrowserConfiguration.showTitle` parameter for hiding/showing webpage title in Android Custom Tabs.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@gmackallgmackallgmackall approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: url_launcherplatform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Alex-Usmanov@stuartmorgan-g@gmackall