Skip to content

[google_maps_flutter][iOS 17] takeSnapshot FIX - #5823

Merged
auto-submit[bot] merged 28 commits into
flutter:mainfrom
GavrielRosendorn74:google_maps_flutter_ios_17_snapshot_fix
Feb 13, 2024
Merged

[google_maps_flutter][iOS 17] takeSnapshot FIX#5823
auto-submit[bot] merged 28 commits into
flutter:mainfrom
GavrielRosendorn74:google_maps_flutter_ios_17_snapshot_fix

Conversation

@GavrielRosendorn74

@GavrielRosendorn74GavrielRosendorn74 commented Jan 7, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

I have fixed the function takeSnapShot for IOS17.

Here you got some screenshots of before now :

Before :

289014755-4e6787c3-c7c0-454a-9c3f-89730a846302

Now :

289014438-4bc5a965-08e0-4520-984d-e5c054c1f370

This issue was fixed by this PR : #139733

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@GavrielRosendorn74GavrielRosendorn74 changed the title Google maps flutter ios 17 snapshot fix[google_maps_flutter][iOS 17] takeSnapshot FIXJan 7, 2024
hellohuanlin
hellohuanlin reviewed Jan 8, 2024
View reviewed changes
Comment threadpackages/google_maps_flutter/google_maps_flutter_ios/CHANGELOG.md Outdated
Comment threadpackages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m
@GavrielRosendorn74

GavrielRosendorn74 commented Jan 9, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Now i just changed 2.3.5 to 2.3.6 for the package version. @hellohuanlin

hellohuanlin
hellohuanlin reviewed Jan 16, 2024
View reviewed changes

@hellohuanlinhellohuanlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing. Can you add the comment as we discussed in my previous review?

Comment threadpackages/google_maps_flutter/google_maps_flutter_ios/CHANGELOG.md Outdated
@GavrielRosendorn74

GavrielRosendorn74 commented Jan 31, 2024

Copy link
Copy Markdown
ContributorAuthor

Sorry for being inactive here for weeks. I am solving all these points today :)

hellohuanlin
hellohuanlin reviewed Feb 1, 2024
View reviewed changes
Comment threadpackages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m Outdated
@GavrielRosendorn74

GavrielRosendorn74 commented Feb 7, 2024

Copy link
Copy Markdown
ContributorAuthor

Hi @stuartmorgan ! How are you ? Is there some changes to add to this PR ?

I won't know that until I have reviewed it, which I have not done in the one working day I've had since I marked it for review. Please see https://github.com/flutter/flutter/wiki/Tree-hygiene for expectations around review turnaround time.

Got it ! Thanks ! :)

stuartmorgan-g
stuartmorgan-g requested changes Feb 9, 2024
View reviewed changes
Comment threadpackages/google_maps_flutter/google_maps_flutter_ios/CHANGELOG.md Outdated
Comment threadpackages/google_maps_flutter/google_maps_flutter_ios/CHANGELOG.md Outdated
Comment threadpackages/google_maps_flutter/google_maps_flutter_ios/ios/Classes/GoogleMapController.m Outdated
@GavrielRosendorn74

GavrielRosendorn74 commented Feb 9, 2024

Copy link
Copy Markdown
ContributorAuthor

Hi @stuartmorgan. All the fixes you have asked for are done :)

stuartmorgan-g
stuartmorgan-g requested changes Feb 12, 2024
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM, but the CI failures here need to be fixed before this can land.

@GavrielRosendorn74

GavrielRosendorn74 commented Feb 13, 2024

Copy link
Copy Markdown
ContributorAuthor

@stuartmorgan that's it i think on this time ! 🚀

stuartmorgan-g
stuartmorgan-g approved these changes Feb 13, 2024
View reviewed changes

@stuartmorgan-gstuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2024
@auto-submit
auto-submitBot merged commit 8d1a5c9 into flutter:mainFeb 13, 2024
@camsim99camsim99 mentioned this pull request Feb 13, 2024
Merged
11 tasks
auto-submitBot pushed a commit that referenced this pull request Feb 14, 2024
@camsim99
[google_maps_flutter][iOS 12] SkiptestTakeSnapshot(#6120)
8c263ef
Skips `testTakeSnapshot` test re-enabeld by #5823, but causing failures and blocking the `flutter/packages` tree, e.g. https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20ios_platform_tests_shard_2%20master/1697/overview.
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Feb 14, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
8d1a5c9[google_maps_flutter][iOS 17] takeSnapshot FIX (flutter/packa…
e1e2b59
…ges#5823)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
Roll Packages from9385bbbtoa864254(6 revisions) (#143454)
ee63848
flutter/packages@9385bbb...a864254
2024-02-14 matanlurey@users.noreply.github.com Allow deprecated members from the Dart SDK/Flutter Framework to roll in (flutter/packages#6111)
2024-02-14 43054281+camsim99@users.noreply.github.com [google_maps_flutter][iOS 12] Skip `testTakeSnapshot` (flutter/packages#6120)
2024-02-13 stuartmorgan@google.com [ci] Allow dependencies on local_auth_ios (flutter/packages#6116)
2024-02-13 40719830+Alex-Usmanov@users.noreply.github.com [url_launcher] Add `InAppBrowserConfiguration` parameter in implementations (flutter/packages#5759)
2024-02-13 16229121+leiatfly@users.noreply.github.com [flutter_markdown] Use Text.rich to replace RichText in Flutter Markdown (flutter/packages#6062)
2024-02-13 97943118+GavrielRosendorn74@users.noreply.github.com [google_maps_flutter][iOS 17] takeSnapshot FIX (flutter/packages#5823)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@jmagmanjmagman mentioned this pull request Feb 16, 2024
Closed
2 tasks
dko5ki23t pushed a commit to dko5ki23t/google_maps_flutter_improved that referenced this pull request May 24, 2025
@camsim99
[google_maps_flutter][iOS 12] Skip testTakeSnapshot (#6120)
d4707be
Skips `testTakeSnapshot` test re-enabeld by flutter/packages#5823, but causing failures and blocking the `flutter/packages` tree, e.g. https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20ios_platform_tests_shard_2%20master/1697/overview.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@GavrielRosendorn74
[google_maps_flutter][iOS 17] takeSnapshot FIX (flutter#5823)
3072691
I have fixed the function takeSnapShot for IOS17.
Here you got some screenshots of before now : Before : ![289014755-4e6787c3-c7c0-454a-9c3f-89730a846302](https://github.com/flutter/packages/assets/97943118/e812f71e-3d31-49d5-975f-74bc28aaaad1)
Now : ![289014438-4bc5a965-08e0-4520-984d-e5c054c1f370](https://github.com/flutter/packages/assets/97943118/16e71558-2d18-4eda-91d8-f639365b88e3)
This issue was fixed by this PR :[ #139733 ](flutter/flutter#139733)
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@camsim99
[google_maps_flutter][iOS 12] SkiptestTakeSnapshot(flutter#6120)
ed1f5b2
Skips `testTakeSnapshot` test re-enabeld by flutter#5823, but causing failures and blocking the `flutter/packages` tree, e.g. https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20ios_platform_tests_shard_2%20master/1697/overview.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@GavrielRosendorn74
[google_maps_flutter][iOS 17] takeSnapshot FIX (flutter#5823)
66aff90
I have fixed the function takeSnapShot for IOS17.
Here you got some screenshots of before now : Before : ![289014755-4e6787c3-c7c0-454a-9c3f-89730a846302](https://github.com/flutter/packages/assets/97943118/e812f71e-3d31-49d5-975f-74bc28aaaad1)
Now : ![289014438-4bc5a965-08e0-4520-984d-e5c054c1f370](https://github.com/flutter/packages/assets/97943118/16e71558-2d18-4eda-91d8-f639365b88e3)
This issue was fixed by this PR :[ #139733 ](flutter/flutter#139733)
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@camsim99
[google_maps_flutter][iOS 12] SkiptestTakeSnapshot(flutter#6120)
dc6f5d5
Skips `testTakeSnapshot` test re-enabeld by flutter#5823, but causing failures and blocking the `flutter/packages` tree, e.g. https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20ios_platform_tests_shard_2%20master/1697/overview.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-gstuartmorgan-gstuartmorgan-g approved these changes
@hellohuanlinhellohuanlinhellohuanlin approved these changes

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: google_maps_flutterplatform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GavrielRosendorn74@stuartmorgan-g@hellohuanlin