Skip to content

[ci] Revert #5793 + Manual flutter roll to c6ddb73f971edd8210893db9f26ae665906cd6be - #5812

Merged
tarrinneal merged 4 commits into
flutter:mainfrom
ditman:revert-bump-main
Jan 6, 2024
Merged

[ci] Revert #5793 + Manual flutter roll to c6ddb73f971edd8210893db9f26ae665906cd6be#5812
tarrinneal merged 4 commits into
flutter:mainfrom
ditman:revert-bump-main

Conversation

@ditman

Copy link
Copy Markdown
Member

This PR reverts #5793 and rolls flutter master version to the latest d97fafa6f.

#5793 should be re-landed on top of the newest master, so all the packages it touches can be published automatically.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@tarrinneal

Copy link
Copy Markdown
Contributor

Seems like there's a new issue here with a video player test, I'll look into it

@tarrinneal

Copy link
Copy Markdown
Contributor

Seems like there's a new issue here with a video player test, I'll look into it

Can't replicate it locally :(

@tarrinnealtarrinneal changed the title [ci] Revert #5793 + Manual flutter roll to d97fafa6f[ci] Revert #5793 + Manual flutter roll to 1fb12a1361211a4dd93bc07213ffd2a20c4802a1Jan 6, 2024
@tarrinnealtarrinneal changed the title [ci] Revert #5793 + Manual flutter roll to 1fb12a1361211a4dd93bc07213ffd2a20c4802a1[ci] Revert #5793 + Manual flutter roll to c6ddb73f971edd8210893db9f26ae665906cd6beJan 6, 2024
@tarrinnealtarrinneal added the emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. label Jan 6, 2024
@tarrinneal

Copy link
Copy Markdown
Contributor

Merging to fix that dang ol Tree!

@tarrinneal
tarrinneal merged commit 5aef49b into flutter:mainJan 6, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 8, 2024
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Jan 8, 2024
flutter/packages@b9b6d38...5aef49b
2024-01-06 ditman@gmail.com [ci] Revert #5793 + Manual flutter roll to c6ddb73 (flutter/packages#5812)
2024-01-05 goderbauer@google.com Enable prefer_mixin and bump plugin_platform_interface to 2.1.7 (flutter/packages#5793)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@ditman
ditman deleted the revert-bump-main branch January 9, 2024 18:34
@reidbakerreidbaker mentioned this pull request Jan 12, 2024
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
This PR reverts flutter#5793 and rolls flutter `master` version to the latest
`d97fafa6f`.
flutter#5793 should be re-landed on top of the newest master, so all the
packages it touches can be published automatically.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [relevant style guides] and ran the
auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
repo does use `dart format`.)
- [x] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated `pubspec.yaml` with an appropriate new version according
to the [pub versioning philosophy], or this PR is [exempt from version
changes].
- [ ] I updated `CHANGELOG.md` to add a description of the change,
[following repository CHANGELOG style].
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[relevant style guides]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[pub versioning philosophy]: https://dart.dev/tools/pub/versioning
[exempt from version changes]:
https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version-and-changelog-updates
[following repository CHANGELOG style]:
https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
---------
Co-authored-by: Tarrin Neal <tarrinneal@gmail.com>
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
This PR reverts flutter#5793 and rolls flutter `master` version to the latest
`d97fafa6f`.
flutter#5793 should be re-landed on top of the newest master, so all the
packages it touches can be published automatically.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [relevant style guides] and ran the
auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages
repo does use `dart format`.)
- [x] I signed the [CLA].
- [x] The title of the PR starts with the name of the package surrounded
by square brackets, e.g. `[shared_preferences]`
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated `pubspec.yaml` with an appropriate new version according
to the [pub versioning philosophy], or this PR is [exempt from version
changes].
- [ ] I updated `CHANGELOG.md` to add a description of the change,
[following repository CHANGELOG style].
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[relevant style guides]:
https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[pub versioning philosophy]: https://dart.dev/tools/pub/versioning
[exempt from version changes]:
https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version-and-changelog-updates
[following repository CHANGELOG style]:
https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
---------
Co-authored-by: Tarrin Neal <tarrinneal@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ditman@tarrinneal@jmagman