Uh oh!
There was an error while loading. Please reload this page.
Enable prefer_mixin and bump plugin_platform_interface to 2.1.7 - #5793
Merged
Conversation
goderbauer
marked this pull request as ready for review
January 4, 2024 00:29
goderbauer
requested review from
bparrishMines, camsim99, ditman, gmackall, hellohuanlin, jmagman, reidbaker, stuartmorgan-g and tarrinneal
as code ownersJanuary 4, 2024 00:29
goderbauer
commented
Jan 4, 2024
MemberAuthor
@stuartmorgan This is the follow-up we discussed. |
tarrinneal
approved these changes
Jan 4, 2024
Contributor
auto label is removed for flutter/packages/5793, due to - The status or check suite Linux_android android_platform_tests_shard_6 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan-g
commented
Jan 5, 2024
Collaborator
This is still hitting the bad new |
goderbauer
commented
Jan 5, 2024
MemberAuthor
🥳 |
goderbauer
commented
Jan 5, 2024
MemberAuthor
The tree turned red on this commit, but that's because of flutter/flutter#141032 unrelated to this commit. |
ditman added a commit
to ditman/flutter-packages
that referenced
this pull request
Jan 6, 2024
….7 (flutter#5793)" This reverts commit 24a12a4.
11 tasks
tarrinneal added a commit
that referenced
this pull request
Jan 6, 2024
This PR reverts #5793 and rolls flutter `master` version to the latest `d97fafa6f`. #5793 should be re-landed on top of the newest master, so all the packages it touches can be published automatically. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [x] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [ ] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style]. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat [pub versioning philosophy]: https://dart.dev/tools/pub/versioning [exempt from version changes]: https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version-and-changelog-updates [following repository CHANGELOG style]: https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests --------- Co-authored-by: Tarrin Neal <tarrinneal@gmail.com>
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 8, 2024
auto-submitBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 8, 2024
flutter/packages@b9b6d38...5aef49b 2024-01-06 ditman@gmail.com [ci] Revert #5793 + Manual flutter roll to c6ddb73 (flutter/packages#5812) 2024-01-05 goderbauer@google.com Enable prefer_mixin and bump plugin_platform_interface to 2.1.7 (flutter/packages#5793) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closed
12 tasks
16 tasks
zhouyuanbo pushed a commit
to zhouyuanbo/video_player_platform_interface_6.2.2
that referenced
this pull request
May 24, 2024
…1.7 (#5841) This reverts commit flutter/packages@5aef49b, except for the Flutter version pin, thus re-landing flutter/packages#5793. Now that the tree is fixed, it can be re-landed for auto-publishing.
dko5ki23t pushed a commit
to dko5ki23t/google_maps_flutter_improved
that referenced
this pull request
May 24, 2025
…1.7 (#5841) This reverts commit flutter/packages@ed6ced2, except for the Flutter version pin, thus re-landing flutter/packages#5793. Now that the tree is fixed, it can be re-landed for auto-publishing.
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…ter#5793) Follow-up to flutter#5717 (comment). --------- Co-authored-by: Tarrin Neal <tarrinneal@gmail.com>
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
This PR reverts flutter#5793 and rolls flutter `master` version to the latest `d97fafa6f`. flutter#5793 should be re-landed on top of the newest master, so all the packages it touches can be published automatically. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.) - [x] I signed the [CLA]. - [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [ ] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style]. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [relevant style guides]: https://github.com/flutter/packages/blob/main/CONTRIBUTING.md#style [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat [pub versioning philosophy]: https://dart.dev/tools/pub/versioning [exempt from version changes]: https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#version-and-changelog-updates [following repository CHANGELOG style]: https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests --------- Co-authored-by: Tarrin Neal <tarrinneal@gmail.com>
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…1.7 (flutter#5841) This reverts commit flutter@5aef49b, except for the Flutter version pin, thus re-landing flutter#5793. Now that the tree is fixed, it can be re-landed for auto-publishing.
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…ter#5793) Follow-up to flutter#5717 (comment). --------- Co-authored-by: Tarrin Neal <tarrinneal@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5717 (comment).