Skip to content

Re-land: Enable prefer_mixin and bump plugin_platform_interface to 2.1.7 - #5841

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
stuartmorgan-g:prefer-mixin-reland
Jan 9, 2024
Merged

Re-land: Enable prefer_mixin and bump plugin_platform_interface to 2.1.7#5841
auto-submit[bot] merged 2 commits into
flutter:mainfrom
stuartmorgan-g:prefer-mixin-reland

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

This reverts commit 5aef49b, except for the Flutter version pin, thus re-landing #5793. Now that the tree is fixed, it can be re-landed for auto-publishing.

This reverts commit 5aef49b, except for
the Flutter version pin. Now that the tree is fixed, this can be
re-landed for auto-publishing.
@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 8, 2024

@goderbauergoderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 8, 2024
@auto-submit

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages/5841, due to - The status or check suite Linux_android android_platform_tests_shard_6 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 8, 2024
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 8, 2024
@auto-submit

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages/5841, due to - The status or check suite Linux_android android_platform_tests_shard_6 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@camsim99camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 8, 2024
@auto-submit
auto-submitBot merged commit 09205ca into flutter:mainJan 9, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 9, 2024
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Jan 9, 2024
flutter/packages@5aef49b...09205ca
2024-01-09 stuartmorgan@google.com Re-land: Enable prefer_mixin and bump plugin_platform_interface to 2.1.7 (flutter/packages#5841)
2024-01-09 stuartmorgan@google.com [ci] Exclude quick_actions from Android emulators (flutter/packages#5847)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@ditman

Copy link
Copy Markdown
Member

Thanks for relanding this! I took a sick day off monday and couldn't complete the reland!

@reidbakerreidbaker mentioned this pull request Jan 12, 2024
sybrands-place pushed a commit to sybrands-place/packages that referenced this pull request Jan 16, 2024
* main: (186 commits)
Roll Flutter from 7dc856a to 1a2c315 (23 revisions) (flutter#5895)
[webview_flutter_android] Add test that `onReceivedHttpAuthRequest` is cancelled by default (flutter#5723)
Roll Flutter (stable) from 46787ee to ef1af02 (1 revision) (flutter#5887)
[google_maps_flutter] Drop iOS 11 support (flutter#5873)
Roll Flutter from 9f2e681 to 7dc856a (15 revisions) (flutter#5882)
[ci] Check repo-level package metadata (flutter#5811)
[various] Add iOS privacy manifests (flutter#5846)
[video_player] Skip flaky tests in certain circumstances on Android (flutter#5872)
Roll Flutter (stable) from 78666c8 to 46787ee (5 revisions) (flutter#5870)
Roll Flutter from b840a60 to 9f2e681 (24 revisions) (flutter#5871)
[quick_actions_android] Close system dialogs for integration test (flutter#5853)
[file_selector]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/file_selector/file_selector_android/android (flutter#5712)
[in_app_pur]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter#5713)
[url_launcher]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/url_launcher/url_launcher_android/android (flutter#5708)
[image_picker]: Bump androidx.annotation:annotation from 1.7.0 to 1.7.1 in /packages/image_picker/image_picker_android/android (flutter#5703)
Roll Flutter from 126302d to b840a60 (29 revisions) (flutter#5855)
Roll Flutter from c6ddb73 to 126302d (32 revisions) (flutter#5852)
Bump github/codeql-action from 3.22.12 to 3.23.0 (flutter#5849)
Re-land: Enable prefer_mixin and bump plugin_platform_interface to 2.1.7 (flutter#5841)
[ci] Exclude quick_actions from Android emulators (flutter#5847)
...
# Conflicts:
#	packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FWFNavigationDelegateHostApi.m
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…1.7 (flutter#5841)
This reverts commit flutter@5aef49b, except for the Flutter version pin, thus re-landing flutter#5793. Now that the tree is fixed, it can be re-landed for auto-publishing.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
…1.7 (flutter#5841)
This reverts commit flutter@458ed70, except for the Flutter version pin, thus re-landing flutter#5793. Now that the tree is fixed, it can be re-landed for auto-publishing.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@stuartmorgan-g@ditman@goderbauer@camsim99@tarrinneal