Uh oh!
There was an error while loading. Please reload this page.
[camera_avfoundation] fix sample times not being numeric after pause/resume. - #6897
Merged
Merged
Conversation
misos1force-pushed
the
pause_resume_numeric
branch
2 times, most recently
from
June 10, 2024 19:35
6969f5b to
9d07477Comparemisos1force-pushed
the
pause_resume_numeric
branch
from
June 10, 2024 19:53
9d07477 to
76e4f1aCompareUh oh!
There was an error while loading. Please reload this page.
misos1force-pushed
the
pause_resume_numeric
branch
from
June 11, 2024 21:00
bd5d485 to
b066729Comparehellohuanlin
approved these changes
Jun 12, 2024
stuartmorgan-g
commented
Jul 6, 2024
Collaborator
@hellohuanlin Please request a second review when reviewing a PR that needs two approvals. |
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 10, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 10, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 10, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 10, 2024
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 10, 2024
auto-submitBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 10, 2024
flutter/packages@14341d1...ea35fc6 2024-07-10 737941+loic-sharma@users.noreply.github.com [camera_avfoundation] Adds Swift Package Manager compatibility (flutter/packages#7080) 2024-07-10 737941+loic-sharma@users.noreply.github.com [webview_flutter_wkwebview] Adds Swift Package Manager compatibility (flutter/packages#7091) 2024-07-10 contact@thaun.dev [webview_flutter_web] Migrate to package:web. (flutter/packages#6792) 2024-07-10 stuartmorgan@google.com [camera] Clean up `maxDuration` code (flutter/packages#7039) 2024-07-10 reidbaker@google.com Update espresso dependencies (flutter/packages#7048) 2024-07-09 stuartmorgan@google.com [camera] Fix iOS torch mode regression (flutter/packages#7085) 2024-07-09 stuartmorgan@google.com [google_maps_flutter] Convert Obj-C->Dart calls to Pigeon (flutter/packages#7086) 2024-07-09 engine-flutter-autoroll@skia.org Roll Flutter from fafd67d to 5103d75 (27 revisions) (flutter/packages#7084) 2024-07-09 30872003+misos1@users.noreply.github.com [camera_avfoundation] fix sample times not being numeric after pause/resume. (flutter/packages#6897) 2024-07-09 stuartmorgan@google.com [camera] Convert Windows to Pigeon (flutter/packages#6925) 2024-07-09 stuartmorgan@google.com [camera] Deprecate `maxDuration` in platform interface (flutter/packages#7078) 2024-07-09 stuartmorgan@google.com [google_maps_flutter] Semi-convert remaining iOS host API calls to Pigeon (flutter/packages#7079) 2024-07-09 stuartmorgan@google.com [path_provider] Remove `win32` (flutter/packages#7073) 2024-07-08 stuartmorgan@google.com [google_maps_flutter] Move iOS inspector to Pigeon (flutter/packages#6937) 2024-07-08 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.0 in /packages/camera/camera_android_camerax/android (flutter/packages#7072) 2024-07-08 49699333+dependabot[bot]@users.noreply.github.com [local_auth]: Bump com.android.tools.build:gradle from 7.3.1 to 8.5.0 in /packages/local_auth/local_auth_android/android (flutter/packages#7069) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…resume. (flutter#6897) Correctly initialise `_lastVideoSampleTime` and `_lastAudioSampleTime` before first use to avoid propagating invalid (non-numeric) values into methods like `appendPixelBuffer`. Fixesflutter/flutter#132014
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…resume. (flutter#6897) Correctly initialise `_lastVideoSampleTime` and `_lastAudioSampleTime` before first use to avoid propagating invalid (non-numeric) values into methods like `appendPixelBuffer`. Fixesflutter/flutter#132014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctly initialise
_lastVideoSampleTimeand_lastAudioSampleTimebefore first use to avoid propagating invalid (non-numeric) values into methods likeappendPixelBuffer.Fixesflutter/flutter#132014
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.