Skip to content

[google_maps_flutter] Convert Obj-C->Dart calls to Pigeon - #7086

Merged
auto-submit[bot] merged 6 commits into
flutter:mainfrom
stuartmorgan-g:maps-pigeon-ios-flutter-api
Jul 9, 2024
Merged

[google_maps_flutter] Convert Obj-C->Dart calls to Pigeon#7086
auto-submit[bot] merged 6 commits into
flutter:mainfrom
stuartmorgan-g:maps-pigeon-ios-flutter-api

Conversation

@stuartmorgan-g

@stuartmorgan-gstuartmorgan-g commented Jul 9, 2024

Copy link
Copy Markdown
Collaborator

Converts all of the Obj-C->Dart calls from raw method channels to Pigeon. This finishes conversion of all of the invocations in google_maps_flutter_ios

This is the iOS equivalent of #7040, and much of the Dart code is based on that PR.

Part of flutter/flutter#117907

Pre-launch Checklist

@stuartmorgan-gstuartmorgan-g changed the title Maps pigeon ios flutter api[google_maps_flutter] Convert Obj-C->Dart calls to PigeonJul 9, 2024

@cbrackencbracken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

Nice -- much more readable.

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 9, 2024
@auto-submit
auto-submitBot merged commit 4063b20 into flutter:mainJul 9, 2024
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Jul 10, 2024
flutter/packages@14341d1...ea35fc6
2024-07-10 737941+loic-sharma@users.noreply.github.com [camera_avfoundation] Adds Swift Package Manager compatibility (flutter/packages#7080)
2024-07-10 737941+loic-sharma@users.noreply.github.com [webview_flutter_wkwebview] Adds Swift Package Manager compatibility (flutter/packages#7091)
2024-07-10 contact@thaun.dev [webview_flutter_web] Migrate to package:web. (flutter/packages#6792)
2024-07-10 stuartmorgan@google.com [camera] Clean up `maxDuration` code (flutter/packages#7039)
2024-07-10 reidbaker@google.com Update espresso dependencies (flutter/packages#7048)
2024-07-09 stuartmorgan@google.com [camera] Fix iOS torch mode regression (flutter/packages#7085)
2024-07-09 stuartmorgan@google.com [google_maps_flutter] Convert Obj-C->Dart calls to Pigeon (flutter/packages#7086)
2024-07-09 engine-flutter-autoroll@skia.org Roll Flutter from fafd67d to 5103d75 (27 revisions) (flutter/packages#7084)
2024-07-09 30872003+misos1@users.noreply.github.com [camera_avfoundation] fix sample times not being numeric after pause/resume. (flutter/packages#6897)
2024-07-09 stuartmorgan@google.com [camera] Convert Windows to Pigeon (flutter/packages#6925)
2024-07-09 stuartmorgan@google.com [camera] Deprecate `maxDuration` in platform interface (flutter/packages#7078)
2024-07-09 stuartmorgan@google.com [google_maps_flutter] Semi-convert remaining iOS host API calls to Pigeon (flutter/packages#7079)
2024-07-09 stuartmorgan@google.com [path_provider] Remove `win32` (flutter/packages#7073)
2024-07-08 stuartmorgan@google.com [google_maps_flutter] Move iOS inspector to Pigeon (flutter/packages#6937)
2024-07-08 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.0 in /packages/camera/camera_android_camerax/android (flutter/packages#7072)
2024-07-08 49699333+dependabot[bot]@users.noreply.github.com [local_auth]: Bump com.android.tools.build:gradle from 7.3.1 to 8.5.0 in /packages/local_auth/local_auth_android/android (flutter/packages#7069)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
Converts all of the Obj-C->Dart calls from raw method channels to Pigeon. This finishes conversion of all of the invocations in `google_maps_flutter_ios`
This is the iOS equivalent of flutter#7040, and much of the Dart code is based on that PR.
Part of flutter/flutter#117907
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
Converts all of the Obj-C->Dart calls from raw method channels to Pigeon. This finishes conversion of all of the invocations in `google_maps_flutter_ios`
This is the iOS equivalent of flutter#7040, and much of the Dart code is based on that PR.
Part of flutter/flutter#117907
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: google_maps_flutterplatform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@stuartmorgan-g@cbracken