Skip to content

[pointer_interceptor] Add performance warning on using pointer interceptor on iOS - #7288

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
hellohuanlin:pointer_interceptor_add_performance_warning
Aug 5, 2024
Merged

[pointer_interceptor] Add performance warning on using pointer interceptor on iOS#7288
auto-submit[bot] merged 2 commits into
flutter:mainfrom
hellohuanlin:pointer_interceptor_add_performance_warning

Conversation

@hellohuanlin

@hellohuanlinhellohuanlin commented Aug 2, 2024

Copy link
Copy Markdown
Contributor

Add performance warning to package README on using pointer interceptor on iOS.

Issues

Fixesflutter/flutter#151535

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.


`PointerInterceptor` is a widget that prevents mouse events from being captured by an underlying [`HtmlElementView`](https://api.flutter.dev/flutter/widgets/HtmlElementView-class.html) in web, or an underlying [`PlatformView`](https://api.flutter.dev/flutter/widgets/PlatformViewLink-class.html) on iOS.

Using multiple `PointerInterceptor` on iOS can be slow with increased memory usage, due to performance overhead of the underlying platform view.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny microscopic nit:
"Using multiple PointerInterceptor instances* on iOS can be slow and increases memory usage due to the performance overhead of the underlying platform view."

@ditman

Copy link
Copy Markdown
Member

IMO this small detail in the README is important enough to warrant publishing a patch version of the package (0.10.1+2).

(I also tweaked the pre-launch checklist to reflect reality :P)

@ditmanditman changed the title [pointer_interceptor]add performance warning on using pointer interceptor on iOS[pointer_interceptor] Add performance warning on using pointer interceptor on iOSAug 3, 2024
@hellohuanlin

Copy link
Copy Markdown
ContributorAuthor

Bumped version and rephrased.

@hellohuanlinhellohuanlin added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2024
@auto-submit
auto-submitBot merged commit c451af7 into flutter:mainAug 5, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 6, 2024
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Aug 6, 2024
flutter/packages@82e8d1e...551bde5
2024-08-06 engine-flutter-autoroll@skia.org Manual roll Flutter from 3832823 to 1dd7141 (21 revisions) (flutter/packages#7317)
2024-08-06 rexios@rexios.dev [google_maps_flutter_web] Web changes to support heatmaps (flutter/packages#7315)
2024-08-06 rexios@rexios.dev [google_maps_flutter_ios] iOS changes to support heatmaps (flutter/packages#7314)
2024-08-06 rexios@rexios.dev [google_maps_flutter_android] Android changes to support heatmaps (flutter/packages#7313)
2024-08-06 rexios@rexios.dev [camera_web] Migrate to `package:web` (flutter/packages#7012)
2024-08-06 47866232+chunhtai@users.noreply.github.com [go_router_builder] Fixes readme typos and uses code excerpts. (flutter/packages#7280)
2024-08-05 pateltirth454@gmail.com [go_router] redirect example signature fix (flutter/packages#7278)
2024-08-05 rexios@rexios.dev [google_maps_flutter_platform_interface] Platform interface changes to support heatmaps (flutter/packages#7312)
2024-08-05 41930132+hellohuanlin@users.noreply.github.com [pointer_interceptor] Add performance warning on using pointer interceptor on iOS (flutter/packages#7288)
2024-08-05 engine-flutter-autoroll@skia.org Roll Flutter from cbfb222 to 3832823 (4 revisions) (flutter/packages#7316)
2024-08-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.4 to 4.3.5 (flutter/packages#7308)
2024-08-05 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7302)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
flutter/packages@82e8d1e...551bde5
2024-08-06 engine-flutter-autoroll@skia.org Manual roll Flutter from 3832823 to 1dd7141 (21 revisions) (flutter/packages#7317)
2024-08-06 rexios@rexios.dev [google_maps_flutter_web] Web changes to support heatmaps (flutter/packages#7315)
2024-08-06 rexios@rexios.dev [google_maps_flutter_ios] iOS changes to support heatmaps (flutter/packages#7314)
2024-08-06 rexios@rexios.dev [google_maps_flutter_android] Android changes to support heatmaps (flutter/packages#7313)
2024-08-06 rexios@rexios.dev [camera_web] Migrate to `package:web` (flutter/packages#7012)
2024-08-06 47866232+chunhtai@users.noreply.github.com [go_router_builder] Fixes readme typos and uses code excerpts. (flutter/packages#7280)
2024-08-05 pateltirth454@gmail.com [go_router] redirect example signature fix (flutter/packages#7278)
2024-08-05 rexios@rexios.dev [google_maps_flutter_platform_interface] Platform interface changes to support heatmaps (flutter/packages#7312)
2024-08-05 41930132+hellohuanlin@users.noreply.github.com [pointer_interceptor] Add performance warning on using pointer interceptor on iOS (flutter/packages#7288)
2024-08-05 engine-flutter-autoroll@skia.org Roll Flutter from cbfb222 to 3832823 (4 revisions) (flutter/packages#7316)
2024-08-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.4 to 4.3.5 (flutter/packages#7308)
2024-08-05 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7302)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
flutter/packages@82e8d1e...551bde5
2024-08-06 engine-flutter-autoroll@skia.org Manual roll Flutter from 3832823 to 1dd7141 (21 revisions) (flutter/packages#7317)
2024-08-06 rexios@rexios.dev [google_maps_flutter_web] Web changes to support heatmaps (flutter/packages#7315)
2024-08-06 rexios@rexios.dev [google_maps_flutter_ios] iOS changes to support heatmaps (flutter/packages#7314)
2024-08-06 rexios@rexios.dev [google_maps_flutter_android] Android changes to support heatmaps (flutter/packages#7313)
2024-08-06 rexios@rexios.dev [camera_web] Migrate to `package:web` (flutter/packages#7012)
2024-08-06 47866232+chunhtai@users.noreply.github.com [go_router_builder] Fixes readme typos and uses code excerpts. (flutter/packages#7280)
2024-08-05 pateltirth454@gmail.com [go_router] redirect example signature fix (flutter/packages#7278)
2024-08-05 rexios@rexios.dev [google_maps_flutter_platform_interface] Platform interface changes to support heatmaps (flutter/packages#7312)
2024-08-05 41930132+hellohuanlin@users.noreply.github.com [pointer_interceptor] Add performance warning on using pointer interceptor on iOS (flutter/packages#7288)
2024-08-05 engine-flutter-autoroll@skia.org Roll Flutter from cbfb222 to 3832823 (4 revisions) (flutter/packages#7316)
2024-08-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.4 to 4.3.5 (flutter/packages#7308)
2024-08-05 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7302)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…eptor on iOS (flutter#7288)
Add performance warning to package README on using pointer interceptor on iOS.
## Issues
Fixesflutter/flutter#151535
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
…eptor on iOS (flutter#7288)
Add performance warning to package README on using pointer interceptor on iOS.
## Issues
Fixesflutter/flutter#151535
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: pointer_interceptor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nesting PointerInterceptor platform views with Dropdown will cause crash on iOS

3 participants

@hellohuanlin@ditman@LouiseHsu