[google_maps_flutter_platform_interface] Platform interface changes to support heatmaps by Rexios80 · Pull Request #7312 · flutter/packages

Rexios80 · 2024-08-05T15:53:49Z

Prequel to:

Rexios80 · 2024-08-05T16:28:03Z

@stuartmorgan How can I make the CI not do this?

Finding changed packages relative to "e411afe3fd269001295b19e71856075e624827f5"...Rewriting references to: google_maps_flutter_platform_interface... Modified packages/google_maps_flutter/google_maps_flutter_android/pubspec.yaml Modified packages/google_maps_flutter/google_maps_flutter_android/example/pubspec.yaml Modified packages/google_maps_flutter/google_maps_flutter/pubspec.yaml Modified packages/google_maps_flutter/google_maps_flutter/example/pubspec.yaml Modified packages/google_maps_flutter/google_maps_flutter_ios/pubspec.yaml Modified packages/google_maps_flutter/google_maps_flutter_ios/example/ios14/pubspec.yaml Modified packages/google_maps_flutter/google_maps_flutter_ios/example/shared/maps_example_dart/pubspec.yaml Modified packages/google_maps_flutter/google_maps_flutter_ios/example/ios15/pubspec.yaml Modified packages/google_maps_flutter/google_maps_flutter_web/pubspec.yaml Modified packages/google_maps_flutter/google_maps_flutter_web/example/pubspec.yamlRunning for all packages that have uncommitted changes

Rexios80 · 2024-08-05T16:30:21Z

Oh this is supposed to be a breaking change isn't it

Rexios80 · 2024-08-05T16:40:07Z

Ugh that causes other CI issues. @stuartmorgan please advise on how to resolve this. I see the wiki info about platform interface breaking changes. How do we want to handle this?

stuartmorgan-g · 2024-08-05T16:45:25Z

Sorry, I missed that in review due to diff collapsing. You don't edit any of the buildView* methods, they are legacy for this reason. The platform implementations just add heatmap support in buildViewWithConfiguration.

Rexios80 · 2024-08-05T19:32:11Z

Should those methods be marked as @Deprecated by now?

stuartmorgan-g · 2024-08-05T19:34:42Z

Yes, you could add those here if you want.

Now that our settings for deprecation analysis have changed we add them as we go; that used to break us, so it required a second pass after everything else was updated, and we often didn't remember to do that in practice (as here).

Rexios80 · 2024-08-05T20:06:11Z

@stuartmorgan checks pass! Let's review this again.

stuartmorgan-g

LGTM! Two very small comment nits; no need to request another review for those changes, you can just add the autosubmit label once you upload those diffs.

) Sequel to: - #7312 Prequel to: - #3257

Sequel to: - #7312 Prequel to: - #3257

…hanges to support heatmaps (flutter/packages#7312)

flutter/packages@82e8d1e...551bde5 2024-08-06 engine-flutter-autoroll@skia.org Manual roll Flutter from 3832823 to 1dd7141 (21 revisions) (flutter/packages#7317) 2024-08-06 rexios@rexios.dev [google_maps_flutter_web] Web changes to support heatmaps (flutter/packages#7315) 2024-08-06 rexios@rexios.dev [google_maps_flutter_ios] iOS changes to support heatmaps (flutter/packages#7314) 2024-08-06 rexios@rexios.dev [google_maps_flutter_android] Android changes to support heatmaps (flutter/packages#7313) 2024-08-06 rexios@rexios.dev [camera_web] Migrate to `package:web` (flutter/packages#7012) 2024-08-06 47866232+chunhtai@users.noreply.github.com [go_router_builder] Fixes readme typos and uses code excerpts. (flutter/packages#7280) 2024-08-05 pateltirth454@gmail.com [go_router] redirect example signature fix (flutter/packages#7278) 2024-08-05 rexios@rexios.dev [google_maps_flutter_platform_interface] Platform interface changes to support heatmaps (flutter/packages#7312) 2024-08-05 41930132+hellohuanlin@users.noreply.github.com [pointer_interceptor] Add performance warning on using pointer interceptor on iOS (flutter/packages#7288) 2024-08-05 engine-flutter-autoroll@skia.org Roll Flutter from cbfb222 to 3832823 (4 revisions) (flutter/packages#7316) 2024-08-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.4 to 4.3.5 (flutter/packages#7308) 2024-08-05 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.annotation:annotation from 1.8.0 to 1.8.1 in /packages/image_picker/image_picker_android/android (flutter/packages#7302) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…o support heatmaps (flutter#7312) Prequel to: - flutter#7313 - flutter#7314 - flutter#7315 - flutter#3257

…313) Sequel to: - flutter/packages#7312 Prequel to: - flutter/packages#3257

Sequel to: - flutter/packages#7312 Prequel to: - flutter/packages#3257

…o support heatmaps (flutter#7312) Prequel to: - flutter#7313 - flutter#7314 - flutter#7315 - flutter#3257

…utter#7313) Sequel to: - flutter#7312 Prequel to: - flutter#3257

Sequel to: - flutter#7312 Prequel to: - flutter#3257

…o support heatmaps (flutter#7312) Prequel to: - flutter#7313 - flutter#7314 - flutter#7315 - flutter#3257

…utter#7313) Sequel to: - flutter#7312 Prequel to: - flutter#3257

Sequel to: - flutter#7312 Prequel to: - flutter#3257

Platform interface changes to support heatmaps
6875cee

Rexios80 requested a review from stuartmorgan-g as a code owner August 5, 2024 15:53

Rexios80 changed the title ~~[google_maps_platform_interface] Platform interface changes to support heatmaps~~[google_maps_flutter_platform_interface] Platform interface changes to support heatmapsAug 5, 2024

github-actionsBot added the p: google_maps_flutter label Aug 5, 2024

This was referenced Aug 5, 2024
[google_maps_flutter_android] Android changes to support heatmaps #7313
Merged
[google_maps_flutter_ios] iOS changes to support heatmaps #7314
Merged
[google_maps_flutter_web] Web changes to support heatmaps #7315
Merged

Merge branch 'main' into feature/heatmaps-platform-interface
17433ea

Make this a major version change
bff33a2

Rexios80 added 4 commits August 5, 2024 15:40

Remove extraneous heatmaps parameters
252d050

Revert major version change
6edb095

Add deprecation annotations
cac2a4b

Merge branch 'main' into feature/heatmaps-platform-interface
9bca29b

stuartmorgan-g approved these changes Aug 5, 2024
View reviewed changes

Comment thread...maps_flutter_platform_interface/lib/src/platform_interface/google_maps_flutter_platform.dart Outdated
Comment thread...maps_flutter_platform_interface/lib/src/platform_interface/google_maps_flutter_platform.dart

Remove deprecation comments
51232da

Rexios80 added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2024

auto-submitBot merged commit 9308857 into flutter:mainAug 5, 2024

auto-submitBot pushed a commit that referenced this pull request Aug 6, 2024
[google_maps_flutter_android] Android changes to support heatmaps (#7313
89d28fd
) Sequel to: - #7312 Prequel to: - #3257

auto-submitBot pushed a commit that referenced this pull request Aug 6, 2024
[google_maps_flutter_ios] iOS changes to support heatmaps (#7314)
c6a30bc
Sequel to: - #7312 Prequel to: - #3257

auto-submitBot pushed a commit that referenced this pull request Aug 6, 2024
[google_maps_flutter_web] Web changes to support heatmaps (#7315)
57fcda0
Sequel to: - #7312 Prequel to: - #3257

engine-flutter-autoroll mentioned this pull request Aug 6, 2024
Roll Packages from 82e8d1eecb45 to 551bde53f6ea (12 revisions) flutter/flutter#152930
Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 6, 2024
9308857[google_maps_flutter_platform_interface] Platform interface c…
5248ca2
…hanges to support heatmaps (flutter/packages#7312)

iandis pushed a commit to iandis/flutter-packages that referenced this pull request May 23, 2025
[google_maps_flutter_platform_interface] Platform interface changes t…
430be0d
…o support heatmaps (flutter#7312) Prequel to: - flutter#7313 - flutter#7314 - flutter#7315 - flutter#3257

dko5ki23t pushed a commit to dko5ki23t/google_maps_flutter_improved that referenced this pull request May 24, 2025
[google_maps_flutter_android] Android changes to support heatmaps (#7…
b5d70ae
…313) Sequel to: - flutter/packages#7312 Prequel to: - flutter/packages#3257

dko5ki23t pushed a commit to dko5ki23t/google_maps_flutter_improved that referenced this pull request May 24, 2025
[google_maps_flutter_ios] iOS changes to support heatmaps (#7314)
c33bfc5
Sequel to: - flutter/packages#7312 Prequel to: - flutter/packages#3257

dko5ki23t pushed a commit to dko5ki23t/google_maps_flutter_improved that referenced this pull request May 24, 2025
[google_maps_flutter_web] Web changes to support heatmaps (#7315)
845b173
Sequel to: - flutter/packages#7312 Prequel to: - flutter/packages#3257

creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
[google_maps_flutter_platform_interface] Platform interface changes t…
320db70
…o support heatmaps (flutter#7312) Prequel to: - flutter#7313 - flutter#7314 - flutter#7315 - flutter#3257

creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
[google_maps_flutter_android] Android changes to support heatmaps (fl…
1b339d6
…utter#7313) Sequel to: - flutter#7312 Prequel to: - flutter#3257

creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
[google_maps_flutter_ios] iOS changes to support heatmaps (flutter#7314)
1d03f61
Sequel to: - flutter#7312 Prequel to: - flutter#3257

creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
[google_maps_flutter_web] Web changes to support heatmaps (flutter#7315)
266413a
Sequel to: - flutter#7312 Prequel to: - flutter#3257

bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
[google_maps_flutter_platform_interface] Platform interface changes t…
ac940f2
…o support heatmaps (flutter#7312) Prequel to: - flutter#7313 - flutter#7314 - flutter#7315 - flutter#3257

bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
[google_maps_flutter_android] Android changes to support heatmaps (fl…
846b2a8
…utter#7313) Sequel to: - flutter#7312 Prequel to: - flutter#3257

bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
[google_maps_flutter_ios] iOS changes to support heatmaps (flutter#7314)
77e849b
Sequel to: - flutter#7312 Prequel to: - flutter#3257

bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
[google_maps_flutter_web] Web changes to support heatmaps (flutter#7315)
3d0c6b9
Sequel to: - flutter#7312 Prequel to: - flutter#3257

Navigation Menu

Uh oh!

[google_maps_flutter_platform_interface] Platform interface changes to support heatmaps - #7312

[google_maps_flutter_platform_interface] Platform interface changes to support heatmaps#7312
auto-submit[bot] merged 8 commits into
flutter:mainfrom
Rexios80:feature/heatmaps-platform-interface

Rexios80 commented Aug 5, 2024•
edited
Loading

Uh oh!

Rexios80 commented Aug 5, 2024•
edited
Loading

Uh oh!

Rexios80 commented Aug 5, 2024

Uh oh!

Rexios80 commented Aug 5, 2024

Uh oh!

stuartmorgan-g commented Aug 5, 2024

Uh oh!

Rexios80 commented Aug 5, 2024

Uh oh!

stuartmorgan-g commented Aug 5, 2024

Uh oh!

Rexios80 commented Aug 5, 2024

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Rexios80 commented Aug 5, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rexios80 commented Aug 5, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rexios80 commented Aug 5, 2024

Uh oh!

Rexios80 commented Aug 5, 2024

Uh oh!

stuartmorgan-g commented Aug 5, 2024

Uh oh!

Rexios80 commented Aug 5, 2024

Uh oh!

stuartmorgan-g commented Aug 5, 2024

Uh oh!

Rexios80 commented Aug 5, 2024

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Rexios80 commented Aug 5, 2024•
edited
Loading

Rexios80 commented Aug 5, 2024•
edited
Loading