[flutter_adaptive_scaffold] Map NavigationsRails destinations and use group and labelType by martijn00 · Pull Request #7310 · flutter/packages

martijn00 · 2024-08-05T14:56:26Z

List which issues are fixed by this PR. You must list at least one issue.

flutter/flutter#141060
flutter/flutter#115235

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2024-08-05T14:56:30Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

gspencergoog

martijn00 · 2024-08-07T20:00:04Z

@Renzo-Olivares @gspencergoog Done

Renzo-Olivares

LGTM, thank you for the contribution and the quick changes!

gspencergoog · 2024-08-08T00:18:59Z

Looks like there are some changes needed to the CHANGELOG:

 ERROR: Package validation found the following potential issue:
* /b/s/w/ir/x/w/packages/packages/flutter_adaptive_scaffold/CHANGELOG.md doesn't mention current version (0.1.11+2).
Consider updating it with notes on this version prior to publication.
Package validation found the following hint:
* The previous version is 0.1.11+1.
It seems you are not publishing an incremental update.
ERROR: Consider one of:
* 1.0.0 for a first major release.
* 0.2.0 for a breaking release.
* 0.1.12 for a minor release.

auto-submit · 2024-08-08T00:19:11Z

auto label is removed for flutter/packages/7310, due to - The status or check suite Linux repo_checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

martijn00 · 2024-08-08T09:23:41Z

@gspencergoog changelog and version are done now.

… and use group and labelType (flutter/packages#7310)

flutter/packages@bb797b9...f7b1256 2024-08-09 engine-flutter-autoroll@skia.org Manual roll Flutter from b6cd31e to 76107bd (14 revisions) (flutter/packages#7349) 2024-08-09 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for all `AdEventType`s and ad data (flutter/packages#7287) 2024-08-08 jonahwilliams@google.com [google_maps] remove Impeller opt out. (flutter/packages#7346) 2024-08-08 mhvdijk@gmail.com [flutter_adaptive_scaffold] Map NavigationsRails destinations and use group and labelType (flutter/packages#7310) 2024-08-08 engine-flutter-autoroll@skia.org Manual roll Flutter from d595e98 to b6cd31e (21 revisions) (flutter/packages#7339) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

… group and labelType (flutter#7310) *List which issues are fixed by this PR. You must list at least one issue.* flutter/flutter#141060 flutter/flutter#115235

martijn00 requested a review from gspencergoog as a code owner August 5, 2024 14:56

github-actionsBot added the p: flutter_adaptive_scaffold label Aug 5, 2024

martijn00 force-pushed the expose-rail branch 4 times, most recently from ab050bd to 2489ba1Compare August 7, 2024 09:04

gspencergoog approved these changes Aug 7, 2024
View reviewed changes

Comment threadpackages/flutter_adaptive_scaffold/lib/src/adaptive_scaffold.dart Outdated