Skip to content

[google_maps] remove Impeller opt out. - #7346

Merged
auto-submit[bot] merged 1 commit into
mainfrom
remove_impeller_opt_out
Aug 8, 2024
Merged

[google_maps] remove Impeller opt out.#7346
auto-submit[bot] merged 1 commit into
mainfrom
remove_impeller_opt_out

Conversation

@jonahwilliams

Copy link
Copy Markdown
Contributor

Fixesflutter/flutter#152691

I think the engine has rolled up to latest, lets see what CI says.

@jonahwilliamsjonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2024
@auto-submit
auto-submitBot merged commit bac9841 into mainAug 8, 2024
@auto-submit
auto-submitBot deleted the remove_impeller_opt_out branch August 8, 2024 20:40
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 9, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 9, 2024
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Aug 9, 2024
flutter/packages@bb797b9...f7b1256
2024-08-09 engine-flutter-autoroll@skia.org Manual roll Flutter from b6cd31e to 76107bd (14 revisions) (flutter/packages#7349)
2024-08-09 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for all `AdEventType`s and ad data (flutter/packages#7287)
2024-08-08 jonahwilliams@google.com [google_maps] remove Impeller opt out. (flutter/packages#7346)
2024-08-08 mhvdijk@gmail.com [flutter_adaptive_scaffold] Map NavigationsRails destinations and use group and labelType (flutter/packages#7310)
2024-08-08 engine-flutter-autoroll@skia.org Manual roll Flutter from d595e98 to b6cd31e (21 revisions) (flutter/packages#7339)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Thanks for following up on this!

DBowen33 pushed a commit to DBowen33/flutter that referenced this pull request Aug 16, 2024
flutter/packages@bb797b9...f7b1256
2024-08-09 engine-flutter-autoroll@skia.org Manual roll Flutter from b6cd31e to 76107bd (14 revisions) (flutter/packages#7349)
2024-08-09 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for all `AdEventType`s and ad data (flutter/packages#7287)
2024-08-08 jonahwilliams@google.com [google_maps] remove Impeller opt out. (flutter/packages#7346)
2024-08-08 mhvdijk@gmail.com [flutter_adaptive_scaffold] Map NavigationsRails destinations and use group and labelType (flutter/packages#7310)
2024-08-08 engine-flutter-autoroll@skia.org Manual roll Flutter from d595e98 to b6cd31e (21 revisions) (flutter/packages#7339)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
flutter/packages@bb797b9...f7b1256
2024-08-09 engine-flutter-autoroll@skia.org Manual roll Flutter from b6cd31e to 76107bd (14 revisions) (flutter/packages#7349)
2024-08-09 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds support for all `AdEventType`s and ad data (flutter/packages#7287)
2024-08-08 jonahwilliams@google.com [google_maps] remove Impeller opt out. (flutter/packages#7346)
2024-08-08 mhvdijk@gmail.com [flutter_adaptive_scaffold] Map NavigationsRails destinations and use group and labelType (flutter/packages#7310)
2024-08-08 engine-flutter-autoroll@skia.org Manual roll Flutter from d595e98 to b6cd31e (21 revisions) (flutter/packages#7339)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
Fixesflutter/flutter#152691
I _think_ the engine has rolled up to latest, lets see what CI says.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
Fixesflutter/flutter#152691
I _think_ the engine has rolled up to latest, lets see what CI says.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: google_maps_flutterplatform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flutter->packages roller blocked on google_maps_flutter_android regression due to enabling Impeller

3 participants

@jonahwilliams@stuartmorgan-g@reidbaker