Skip to content

[go_router] Fixes an issue where android back button pops wrong page. - #7348

Merged
auto-submit[bot] merged 4 commits into
flutter:mainfrom
chunhtai:issues/141906
Aug 20, 2024
Merged

[go_router] Fixes an issue where android back button pops wrong page.#7348
auto-submit[bot] merged 4 commits into
flutter:mainfrom
chunhtai:issues/141906

Conversation

@chunhtai

@chunhtaichunhtai commented Aug 8, 2024

Copy link
Copy Markdown
Contributor

fixesflutter/flutter#141906

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@hannah-hyjhannah-hyj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtaichunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 20, 2024
@auto-submit
auto-submitBot merged commit 871cd47 into flutter:mainAug 20, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 21, 2024
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Aug 21, 2024
flutter/packages@4d2d2e3...4e5d47e
2024-08-21 stuartmorgan@google.com [webview_flutter] Endorse macOS (flutter/packages#7457)
2024-08-21 mhvdijk@gmail.com [flutter_adaptive_scaffold] Fix landscape not showing in andUp (flutter/packages#7425)
2024-08-20 47866232+chunhtai@users.noreply.github.com [go_router] Fixes replace and pushReplacement uri when only one route� (flutter/packages#7433)
2024-08-20 engine-flutter-autoroll@skia.org Roll Flutter from 6a28048 to e7da16d (23 revisions) (flutter/packages#7459)
2024-08-20 47866232+chunhtai@users.noreply.github.com [go_router] Fixes an issue where android back button pops wrong page. (flutter/packages#7348)
2024-08-20 34871572+gmackall@users.noreply.github.com [Many] Bump AGP to 8.5.1 and gradle to 8.7 (flutter/packages#7432)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
flutter/packages@4d2d2e3...4e5d47e
2024-08-21 stuartmorgan@google.com [webview_flutter] Endorse macOS (flutter/packages#7457)
2024-08-21 mhvdijk@gmail.com [flutter_adaptive_scaffold] Fix landscape not showing in andUp (flutter/packages#7425)
2024-08-20 47866232+chunhtai@users.noreply.github.com [go_router] Fixes replace and pushReplacement uri when only one route� (flutter/packages#7433)
2024-08-20 engine-flutter-autoroll@skia.org Roll Flutter from 6a28048 to e7da16d (23 revisions) (flutter/packages#7459)
2024-08-20 47866232+chunhtai@users.noreply.github.com [go_router] Fixes an issue where android back button pops wrong page. (flutter/packages#7348)
2024-08-20 34871572+gmackall@users.noreply.github.com [Many] Bump AGP to 8.5.1 and gradle to 8.7 (flutter/packages#7432)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@danielmessi13

danielmessi13 commented Sep 27, 2024

Copy link
Copy Markdown

Hey, this PR throws a null check exception in my code, I have a StatefulShellRoute.indexedStack as the initial route of my application and I push to a ShellRoute, and when I try to pop the error occurs

walker.navigatorKey.currentState!;
image

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: go_router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android back button pops in the wrong order that which is pushed/opened on the root navigator when using stateful shell routes in go_router 13.0.X

3 participants

@chunhtai@danielmessi13@hannah-hyj