Skip to content

[flutter_adaptive_scaffold] Fix landscape not showing in andUp - #7425

Merged
auto-submit[bot] merged 8 commits into
flutter:mainfrom
martijn00:andup
Aug 21, 2024
Merged

[flutter_adaptive_scaffold] Fix landscape not showing in andUp#7425
auto-submit[bot] merged 8 commits into
flutter:mainfrom
martijn00:andup

Conversation

@martijn00

@martijn00martijn00 commented Aug 16, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

flutter/flutter#153496

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gspencergoog
gspencergoog approved these changes Aug 16, 2024
View reviewed changes

@gspencergooggspencergoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@martijn00

martijn00 commented Aug 16, 2024

Copy link
Copy Markdown
ContributorAuthor

@Renzo-Olivares can you check and approve?

@kaboc

kaboc commented Aug 16, 2024

Copy link
Copy Markdown
Contributor

FYI: flutter/flutter#153496 (comment)

I tried running my code sample with your version, but it seems the bug still exists. I have the same result as flutter/flutter#153496 (comment).

kaboc
kaboc reviewed Aug 17, 2024
View reviewed changes
Comment threadpackages/flutter_adaptive_scaffold/lib/src/breakpoints.dart Outdated
@diegotori

diegotori commented Aug 20, 2024

Copy link
Copy Markdown

@gspencergoog looks like changes were made. Are we good to go as a result?

@martijn00

martijn00 commented Aug 20, 2024

Copy link
Copy Markdown
ContributorAuthor

@Renzo-Olivares Can you check this too?

@martijn00martijn00 mentioned this pull request Aug 20, 2024
Merged
11 tasks
Renzo-Olivares
Renzo-Olivares reviewed Aug 20, 2024
View reviewed changes
Comment threadpackages/flutter_adaptive_scaffold/lib/src/breakpoints.dart
Renzo-Olivares
Renzo-Olivares reviewed Aug 20, 2024
View reviewed changes
Comment threadpackages/flutter_adaptive_scaffold/test/breakpoint_test.dart Outdated
Renzo-Olivares
Renzo-Olivares reviewed Aug 20, 2024
View reviewed changes
Comment threadpackages/flutter_adaptive_scaffold/test/breakpoint_test.dart Outdated
Comment threadpackages/flutter_adaptive_scaffold/test/breakpoint_test.dart Outdated
@martijn00

martijn00 commented Aug 20, 2024

Copy link
Copy Markdown
ContributorAuthor

@Renzo-Olivares Done! Can you check again?

Renzo-Olivares
Renzo-Olivares reviewed Aug 20, 2024
View reviewed changes
Comment threadpackages/flutter_adaptive_scaffold/test/simulated_layout.dart
Renzo-Olivares
Renzo-Olivares reviewed Aug 20, 2024
View reviewed changes
Comment threadpackages/flutter_adaptive_scaffold/lib/src/breakpoints.dart
@martijn00

martijn00 commented Aug 20, 2024

Copy link
Copy Markdown
ContributorAuthor

@Renzo-Olivares done.

Renzo-Olivares
Renzo-Olivares reviewed Aug 20, 2024
View reviewed changes
Comment threadpackages/flutter_adaptive_scaffold/lib/src/breakpoints.dart Outdated
@martijn00

martijn00 commented Aug 20, 2024

Copy link
Copy Markdown
ContributorAuthor

@Renzo-Olivares done.

Renzo-Olivares
Renzo-Olivares approved these changes Aug 20, 2024
View reviewed changes

@Renzo-OlivaresRenzo-Olivares left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

gspencergoog
gspencergoog approved these changes Aug 21, 2024
View reviewed changes

@gspencergooggspencergoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@gspencergooggspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 21, 2024
@auto-submit
auto-submitBot merged commit 89154b3 into flutter:mainAug 21, 2024
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Aug 21, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 21, 2024
@engine-flutter-autoroll
89154b3[flutter_adaptive_scaffold] Fix landscape not showing in andUp (
25f3e61
flutter/packages#7425)
auto-submitBot pushed a commit to flutter/flutter that referenced this pull request Aug 21, 2024
@engine-flutter-autoroll
Roll Packages from4d2d2e3to4e5d47e(6 revisions) (#153848)
b74fa8a
flutter/packages@4d2d2e3...4e5d47e
2024-08-21 stuartmorgan@google.com [webview_flutter] Endorse macOS (flutter/packages#7457)
2024-08-21 mhvdijk@gmail.com [flutter_adaptive_scaffold] Fix landscape not showing in andUp (flutter/packages#7425)
2024-08-20 47866232+chunhtai@users.noreply.github.com [go_router] Fixes replace and pushReplacement uri when only one route� (flutter/packages#7433)
2024-08-20 engine-flutter-autoroll@skia.org Roll Flutter from 6a28048 to e7da16d (23 revisions) (flutter/packages#7459)
2024-08-20 47866232+chunhtai@users.noreply.github.com [go_router] Fixes an issue where android back button pops wrong page. (flutter/packages#7348)
2024-08-20 34871572+gmackall@users.noreply.github.com [Many] Bump AGP to 8.5.1 and gradle to 8.7 (flutter/packages#7432)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@gspencergooggspencergoog mentioned this pull request Aug 22, 2024
Closed
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@engine-flutter-autoroll@Buchimi
Roll Packages from4d2d2e3to4e5d47e(6 revisions) (flutter#153848)
79f4f2a
flutter/packages@4d2d2e3...4e5d47e
2024-08-21 stuartmorgan@google.com [webview_flutter] Endorse macOS (flutter/packages#7457)
2024-08-21 mhvdijk@gmail.com [flutter_adaptive_scaffold] Fix landscape not showing in andUp (flutter/packages#7425)
2024-08-20 47866232+chunhtai@users.noreply.github.com [go_router] Fixes replace and pushReplacement uri when only one route� (flutter/packages#7433)
2024-08-20 engine-flutter-autoroll@skia.org Roll Flutter from 6a28048 to e7da16d (23 revisions) (flutter/packages#7459)
2024-08-20 47866232+chunhtai@users.noreply.github.com [go_router] Fixes an issue where android back button pops wrong page. (flutter/packages#7348)
2024-08-20 34871572+gmackall@users.noreply.github.com [Many] Bump AGP to 8.5.1 and gradle to 8.7 (flutter/packages#7432)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@martijn00
[flutter_adaptive_scaffold] Fix landscape not showing in andUp (flutt…
1fd9c51
…er#7425)
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue.*
flutter/flutter#153496
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@martijn00
[flutter_adaptive_scaffold] Fix landscape not showing in andUp (flutt…
f003f3e
…er#7425)
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue.*
flutter/flutter#153496
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renzo-OlivaresRenzo-OlivaresRenzo-Olivares approved these changes
@gspencergooggspencergooggspencergoog approved these changes
@kabockabocAwaiting requested review from kaboc

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: flutter_adaptive_scaffold

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@martijn00@kaboc@diegotori@Renzo-Olivares@gspencergoog