Uh oh!
There was an error while loading. Please reload this page.
[various] Updates packages to use flutter.compileSdkVersion - #8734
Conversation
74580ef to
323fb10Compare….compileSdkVersion can be used
323fb10 to
4ab44c4Compare| repository: https://github.com/flutter/packages/tree/main/packages/camera/camera_android_camerax | ||
| issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+camera%22 | ||
| version: 0.6.14 | ||
| version: 0.6.14+1 |
There was a problem hiding this comment.
You might wonder why this plugin didnt need to update to 3.27. It is because it was already updated.
reidbaker
commented
Mar 4, 2025
Ignoring conflicts in changelog and pubspec until after approval since they will keep happening. |
reidbaker
commented
Mar 4, 2025
I think the failure that i am seeing is flutter/flutter#164132 |
tarrinneal
left a comment
There was a problem hiding this comment.
good pigeon test change!
flutter/packages@fc9d5ca...4c5a7ed 2025-03-07 stuartmorgan@google.com Update PR template for clarity (flutter/packages#8777) 2025-03-06 neilself@gmail.com [google_sign_in] Add Android account name field as optional (implementation package changes) (flutter/packages#8805) 2025-03-06 engine-flutter-autoroll@skia.org Roll Flutter from 2578d97 to 321fbc0 (29 revisions) (flutter/packages#8808) 2025-03-06 reidbaker@google.com [various] Updates packages to use flutter.compileSdkVersion (flutter/packages#8734) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ryanheise
commented
Mar 27, 2025
Maybe the plugin template should also implement this change too since it currently hardcodes Also, just a question about what you've done here. I can see in the example's flutter {
source '../..'
}But in the plugin itself, the Finally, I question whether this change might be considered as a breaking change, since other plugins or apps that depend on such a plugin that use |
reidbaker
commented
Mar 27, 2025
"I question whether this change might be considered as a breaking change, since other plugins or apps that depend on such a plugin that use compileSdk 34 might now stop during the build because the plugin requires compileSdk 35. " This change also set the minimum flutter verison to |
…8734) - **Updates compileSdk 34 to flutter.compileSdkVersion.** Related to flutter/flutter/issues/149836 Want to wait a couple of days after flutter#8700 lands before landing.
…8734) - **Updates compileSdk 34 to flutter.compileSdkVersion.** Related to flutter/flutter/issues/149836 Want to wait a couple of days after flutter#8700 lands before landing.
…8734) - **Updates compileSdk 34 to flutter.compileSdkVersion.** Related to flutter/flutter/issues/149836 Want to wait a couple of days after flutter#8700 lands before landing.
…8734) - **Updates compileSdk 34 to flutter.compileSdkVersion.** Related to flutter/flutter/issues/149836 Want to wait a couple of days after flutter#8700 lands before landing.
Related to flutter/flutter/issues/149836
Want to wait a couple of days after
#8700 lands before landing.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].///).