Skip to content

Update PR template for clarity - #8777

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
stuartmorgan-g:pr-template-update
Mar 7, 2025
Merged

Update PR template for clarity#8777
auto-submit[bot] merged 3 commits into
flutter:mainfrom
stuartmorgan-g:pr-template-update

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Attempt to make the PR checklist more clear about expectations:

  • Retitle the checklist to make it explicit that it's for review, not landing.
  • Make it explicit that the version, CHANGELOG, and test steps require some action, rather than just personally believing that a PR should be exempt.

Attempt to make the PR checklist more clear about expectations:
- Retitle the checklist to make it explicit that it's for review, not
landing.
- Make it explicit that the version, CHANGELOG, and test steps require
some action, rather than just personally believing that a PR should
be exempt.
@stuartmorgan-g

Copy link
Copy Markdown
CollaboratorAuthor

I don't expect this to prevent PR submissions that don't follow the process of course, but hopefully it will cut down on legitimate confusion about what some of the steps mean, and reduce the number of comments we need to leave.

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2025
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2025
@auto-submit

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/8777, because - The status or check suite Linux_android android_device_tests_shard_6 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2025
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2025
@auto-submit

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/8777, because - The status or check suite Linux_android android_platform_tests_shard_6 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2025
@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2025
@auto-submit

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/8777, because - The status or check suite Linux_android android_device_tests_shard_6 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 5, 2025
@auto-submit

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/8777, because - The status or check suite Linux_android android_device_tests_shard_6 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submitauto-submitBot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 5, 2025
@stuartmorgan-gstuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 7, 2025
@auto-submit
auto-submitBot merged commit 4c5a7ed into flutter:mainMar 7, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 7, 2025
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Mar 7, 2025
flutter/packages@fc9d5ca...4c5a7ed
2025-03-07 stuartmorgan@google.com Update PR template for clarity
(flutter/packages#8777)
2025-03-06 neilself@gmail.com [google_sign_in] Add Android account name
field as optional (implementation package changes)
(flutter/packages#8805)
2025-03-06 engine-flutter-autoroll@skia.org Roll Flutter from
2578d97 to 321fbc0 (29 revisions) (flutter/packages#8808)
2025-03-06 reidbaker@google.com [various] Updates packages to use
flutter.compileSdkVersion (flutter/packages#8734)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
Attempt to make the PR checklist more clear about expectations:
- Retitle the checklist to make it explicit that it's for review, not landing.
- Make it explicit that the version, CHANGELOG, and test steps require some action, rather than just personally believing that a PR should be exempt.
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
Attempt to make the PR checklist more clear about expectations:
- Retitle the checklist to make it explicit that it's for review, not landing.
- Make it explicit that the version, CHANGELOG, and test steps require some action, rather than just personally believing that a PR should be exempt.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
Attempt to make the PR checklist more clear about expectations:
- Retitle the checklist to make it explicit that it's for review, not landing.
- Make it explicit that the version, CHANGELOG, and test steps require some action, rather than just personally believing that a PR should be exempt.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
Attempt to make the PR checklist more clear about expectations:
- Retitle the checklist to make it explicit that it's for review, not landing.
- Make it explicit that the version, CHANGELOG, and test steps require some action, rather than just personally believing that a PR should be exempt.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmitMerge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@stuartmorgan-g@tarrinneal