Skip to content

[package_info_plus] Resolve package name linux and web - #817

Merged
jpnurmi merged 5 commits into
fluttercommunity:mainfrom
fabiancrx:add-packageName-linux
Apr 5, 2022
Merged

[package_info_plus] Resolve package name linux and web#817
jpnurmi merged 5 commits into
fluttercommunity:mainfrom
fabiancrx:add-packageName-linux

Conversation

@fabiancrx

Copy link
Copy Markdown
Contributor

Description

package_info_plus for linux and web returns now return the package_name contained in the version.json file (which was introduced in this PR)

See the data returned on both web and linux platforms :
image

Related Issues

Closes #203

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated the version in pubspec.yaml and CHANGELOG.md.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@jpnurmi

jpnurmi commented Apr 5, 2022

Copy link
Copy Markdown
Member

Looking good - just needs a rebase. I merged and published #818 first because it fixed a severe bug.

The package name is retrieved from the version.json file, and as the current implementation is the same as the app_name.
@fabiancrx
fabiancrx force-pushed the add-packageName-linux branch from ead4661 to f175382 Compare April 5, 2022 17:23
@fabiancrx

Copy link
Copy Markdown
Contributor Author

@jpnurmi rebase finished.

Comment thread packages/package_info_plus/package_info_plus/pubspec.yaml
Comment thread packages/package_info_plus/package_info_plus_linux/CHANGELOG.md Outdated
Comment thread packages/package_info_plus/package_info_plus_web/CHANGELOG.md Outdated
Comment thread packages/package_info_plus/package_info_plus/CHANGELOG.md

@jpnurmi jpnurmi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍

@jpnurmi
jpnurmi merged commit 08a7a35 into fluttercommunity:main Apr 5, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

package_info_plus for linux returns empty packageName

2 participants