Skip to content

[package_info_plus] fix MissingPluginException for windows and linux - #818

Merged
jpnurmi merged 4 commits into
fluttercommunity:mainfrom
fabiancrx:fix-package-info-plus-on-desktop
Apr 5, 2022
Merged

[package_info_plus] fix MissingPluginException for windows and linux#818
jpnurmi merged 4 commits into
fluttercommunity:mainfrom
fabiancrx:fix-package-info-plus-on-desktop

Conversation

@fabiancrx

Copy link
Copy Markdown
Contributor

Description

At commit 7e89867 the plugins for windows and linux had changes to auto register via static void registerWith(). But neither the plugins nor the main package versions were increased and published.

This commit fixes that by increasing the versions of the plugins and the main package.

Related Issues

Closes #806
Closes #760
Closes #747
Closes #773

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated the version in pubspec.yaml and CHANGELOG.md.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

At commit 7e89867 the plugins for windows and linux had changes to auto register via `static void registerWith()`. But neither the plugins nor the main package versions were increased and published.

This commit fixes that by increasing the versions of the plugins and the main package.

@jpnurmi jpnurmi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍 Looks otherwise good but let's keep the versions in sync.

Comment thread packages/package_info_plus/package_info_plus/pubspec.yaml

@jpnurmi jpnurmi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍

While trying to publish:
```
pubspec.yaml allows Flutter SDK version prior to 1.20.0, which does not support having no `ios/` folder.
Please consider increasing the Flutter SDK requirement to ^1.20.0 or higher (environment.sdk.flutter) or create an `ios/` folder.
```
@jpnurmi
jpnurmi force-pushed the fix-package-info-plus-on-desktop branch from af29cdb to 84dc4fa Compare April 5, 2022 08:07
While trying to publish:
```
pubspec.yaml allows Flutter SDK version prior to 1.20.0, which does not support having no `ios/` folder.
Please consider increasing the Flutter SDK requirement to ^1.20.0 or higher (environment.sdk.flutter) or create an `ios/` folder.
```
@jpnurmi
jpnurmi merged commit efeb9e6 into fluttercommunity:main Apr 5, 2022
@kerberjg

Copy link
Copy Markdown

Still an issue on macOS (only in tests), left a comment in #214

@fabiancrx
fabiancrx deleted the fix-package-info-plus-on-desktop branch June 24, 2024 14:52
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.