Add official support for python 3.9 - #687
Conversation
|
@eapolinario I just want to give a heads-up about some NamedTuple errors I have come across in Python 3.9.
|
Codecov Report
@@ Coverage Diff @@
## master #687 +/- ##
==========================================
+ Coverage 85.68% 85.74% +0.06%
==========================================
Files 355 357 +2
Lines 29684 29746 +62
Branches 2426 2428 +2
==========================================
+ Hits 25436 25507 +71
+ Misses 3606 3600 -6
+ Partials 642 639 -3
Continue to review full report at Codecov.
|
|
@samhita-alla , were you aware of any other issue that was blocking python 3.9? |
|
For those who are wondering, we can't enable |
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@apache.org> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
* no node sync Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> * add param to wait Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
* fix pandera regression Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * install plugin with pip Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * fix pandera plugin tests Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * wip Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * wip Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * wip Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * wip Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * wip Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * wip Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * add spark flytekit plugin to papermill test_requires Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * wip Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * wip Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * wip Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * wip Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * add sqlalchemy to great expectations plugin Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * wip Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * wip Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * plugins plugins plugins! Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com> * lint Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Yes, this is needed, please see https://dev.to/hugovk/the-python-3-1-problem-85g. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
This reverts commit 4d619d5. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
This reverts commit bd6d694. Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
3a2000c to
e295e6b
Compare
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Not really. The ones I sent were the blockers I had come across. |
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
…-3.9 Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario eapolinario@users.noreply.github.com
TL;DR
Support python 3.9 officially.
Type
Are all requirements met?
Complete description
Handle the case where a call to
isinstancemight raise an exception in calls toisinstance.isinstanceraises an error if the base type is not a valid type in python 3.9, so we now handle a case in the type engine where one of the registered restricted types, namelyNamedTuple, is now considered invalid (hence raisingTypeError).Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/