Skip to content

Failed to transform path string to Literal - #689

Merged
pingsutw merged 1 commit into
flyteorg:masterfrom
pingsutw:FlyteFile
Oct 7, 2021
Merged

Failed to transform path string to Literal#689
pingsutw merged 1 commit into
flyteorg:masterfrom
pingsutw:FlyteFile

Conversation

@pingsutw

@pingsutw pingsutw commented Oct 7, 2021

Copy link
Copy Markdown
Member

TL;DR

Failed to transform path string to Literal

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Return FlyteTypeException when getting TypeError from TypeEngine.to_literal

Tracking Issue

https://flyte-org.slack.com/archives/CREL4QVAQ/p1633567961295600

Follow-up issue

NA

@pingsutw
Failed to transform path string to Literal
ee615e8 
Signed-off-by: Kevin Su <pingsutw@apache.org>
@codecov

codecov Bot commented Oct 7, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #689 (cd40e8f) into master (1fb425f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head cd40e8f differs from pull request most recent head ee615e8. Consider uploading reports for the commit ee615e8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #689   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files         355      355           
  Lines       29682    29684    +2     
  Branches     2427     2426    -1     
=======================================
+ Hits        25434    25436    +2     
  Misses       3606     3606           
  Partials      642      642
Impacted Files Coverage Δ
flytekit/core/type_engine.py 88.38% <100.00%> (+0.02%) ⬆️
tests/flytekit/unit/core/test_type_engine.py 99.71% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fb425f...ee615e8. Read the comment docs.

@wild-endeavor

wild-endeavor commented Oct 7, 2021

Copy link
Copy Markdown
Contributor

Thanks @pingsutw! - Mind cutting a beta release afterwards so that @vsbus can pick it up?

@pingsutw
pingsutw merged commit 7f03137 into flyteorg:master Oct 7, 2021
eapolinario pushed a commit that referenced this pull request Oct 8, 2021
@pingsutw @eapolinario
Failed to transform path string to Literal (#689)
abb12e0 
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
AdrianoKF pushed a commit to AdrianoKF/flytekit that referenced this pull request Oct 11, 2021
@pingsutw @AdrianoKF
Failed to transform path string to Literal (flyteorg#689)
d0683f7 
Signed-off-by: Kevin Su <pingsutw@apache.org>
eapolinario added a commit that referenced this pull request Oct 19, 2021
@eapolinario @pingsutw
@wild-endeavor @cosmicbboy
Add official support for python 3.9 (#687)
ae15c4e 
* Run 3.9 in CI

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Also run 3.9 in plugins tests.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Fix tests

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Account for the different exception type raised in case of wrong types

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Exclude spark2

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Failed to load json_data to dataclass (#684)

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Remove sync singledispatch, add option for top-level only sync (#681)

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Failed to transform path string to Literal (#689)

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Don't node sync on remote wait (#690)

* no node sync

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* add param to wait

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Fix plugin regressions (#688)

* fix pandera regression

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* install plugin with pip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* fix pandera plugin tests

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* add spark flytekit plugin to papermill test_requires

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* add sqlalchemy to great expectations plugin

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* plugins plugins plugins!

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* lint

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* Exclude does not understand lists

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Invert python version check

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Invert python version check for real this time

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Enable 3.10 just for kicks

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Add quotes around python versions

Yes, this is needed, please see https://dev.to/hugovk/the-python-3-1-problem-85g.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Revert "Add quotes around python versions"

This reverts commit 4d619d5.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Revert "Enable 3.10 just for kicks"

This reverts commit bd6d694.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* wip - restricted types

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* wip - restricted types

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Comment use of restricted types in get_transformer

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Publish 3.9 image

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Add python 3.9 to the list of supported languages

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Comment RestrictedTypeTransformer and add one test case.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Review feedback

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Comment RestrictedTypeTransformer

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Handle the TypeError

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Remove breakpoint

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Kevin Su <pingsutw@gmail.com>
Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Co-authored-by: Niels Bantilan <niels.bantilan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wild-endeavor wild-endeavor wild-endeavor approved these changes
@katrogan katrogan Awaiting requested review from katrogan
@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pingsutw @wild-endeavor