Uh oh!
There was an error while loading. Please reload this page.
feat: the docker folder contains scripts and assets for creating and … - #406
feat: the docker folder contains scripts and assets for creating and …#406tomnoland wants to merge 21 commits into
Conversation
…running the chapter images with mapped volumes and for general Docker maintenance
… for docker utilities)
…land/chapter into feat/docker-mapped_volumes
…land/chapter into feat/docker-mapped_volumes
…land/chapter into feat/docker-mapped_volumes
allella
commented
Sep 24, 2020
@tomiiide@Zeko369 could you checkout @tomnoland 's suggestions on this one? I'm out of my realm with no Docker experience. |
allella
commented
Oct 26, 2020
@tomnoland does the recent 'pg' Node version fix help out with the work you've been doing on Docker? |
gh-23378
commented
Oct 26, 2020
He's using node 13 in his docker image so things should have been working for him either way, my fix was for an issue that was encountered on 14/15 |
tomnoland
commented
Oct 26, 2020
Yeah, I can switch everything to Node 14 now. |
NorthDecoder
commented
Mar 15, 2021
Hi @tomnoland ! My thought was to do some testing on this request, please pardon me for being obtuse. I am looking at https://github.com/tomnoland/chapter trying to find where the commits are for this pull request. On this pull request page however, when I hover over the from |
allella
commented
Mar 15, 2021
I think Tom started down a new thought path on #408, so perhaps that's worth a look. I haven't been too involved in the Docker stuff. However, it does seem we'll have multiple Docker configs. For instance, SchemaSpy #453 is being used manually right now and it has a Docker option that we likely would have in a different directory than the dev or other containers. |
NorthDecoder
commented
Mar 26, 2021
As noted above this pull request in now obsolete and should be closed to avoid further discussion about code that can no longer be referenced. |
allella
commented
Jul 12, 2021
@ojeytonwilliams was looking at reorganizing the some of the directories, like /server. I figured that may overlap with #406 and #408 and you may have ideas on where things should go. If you have any thoughts, in general, or specific to Docker, then please feel free to share with Oliver. |
allella
commented
Jul 12, 2021
ojeytonwilliams
commented
Aug 2, 2021
@tomnoland I didn't realise that renaming master to main would close this, sorry! Do you still have the code locally? |
…running the chapter images with mapped volumes and for general Docker maintenance
Update README.md).masterbranch of Chapter.