Skip to content
This repository was archived by the owner on Sep 25, 2025. It is now read-only.

feat: the docker folder contains scripts and assets for creating and … - #406

Closed
tomnoland wants to merge 21 commits into
freeCodeCamp:masterfrom
tomnoland:feat/docker-mapped_volumes
Closed

feat: the docker folder contains scripts and assets for creating and …#406
tomnoland wants to merge 21 commits into
freeCodeCamp:masterfrom
tomnoland:feat/docker-mapped_volumes

Conversation

@tomnoland

Copy link
Copy Markdown

…running the chapter images with mapped volumes and for general Docker maintenance

  • I have read Chapter's contributing guidelines.
  • My pull request has a descriptive title (not a vague title like Update README.md).
  • My pull request targets the master branch of Chapter.

@allella

Copy link
Copy Markdown
Contributor

@tomiiide@Zeko369 could you checkout @tomnoland 's suggestions on this one?

I'm out of my realm with no Docker experience.

@allella

Copy link
Copy Markdown
Contributor

@tomnoland does the recent 'pg' Node version fix help out with the work you've been doing on Docker?

@gh-23378

Copy link
Copy Markdown
Contributor

He's using node 13 in his docker image so things should have been working for him either way, my fix was for an issue that was encountered on 14/15

@tomnoland

Copy link
Copy Markdown
Author

Yeah, I can switch everything to Node 14 now.

@NorthDecoder

Copy link
Copy Markdown
Contributor

Hi @tomnoland ! My thought was to do some testing on this request, please pardon me for being obtuse. I am looking at https://github.com/tomnoland/chapter trying to find where the commits are for this pull request. On this pull request page however, when I hover over the from tomnoland:feat/docker-mapped_volumes icon at the top of the page it tells me This repository has been deleted. It looks like you put considerable thought into the recommendation, has there been an important change?

@allella

Copy link
Copy Markdown
Contributor

I think Tom started down a new thought path on #408, so perhaps that's worth a look. I haven't been too involved in the Docker stuff. However, it does seem we'll have multiple Docker configs. For instance, SchemaSpy #453 is being used manually right now and it has a Docker option that we likely would have in a different directory than the dev or other containers.

@NorthDecoder

Copy link
Copy Markdown
Contributor

As noted above this pull request in now obsolete and should be closed to avoid further discussion about code that can no longer be referenced.

@allella

Copy link
Copy Markdown
Contributor

@tomnoland

@ojeytonwilliams was looking at reorganizing the some of the directories, like /server.

I figured that may overlap with #406 and #408 and you may have ideas on where things should go. If you have any thoughts, in general, or specific to Docker, then please feel free to share with Oliver.

@allella

Copy link
Copy Markdown
Contributor

@ojeytonwilliams
ojeytonwilliams deleted the branch freeCodeCamp:masterAugust 2, 2021 12:45
@ojeytonwilliams

Copy link
Copy Markdown
Contributor

@tomnoland I didn't realise that renaming master to main would close this, sorry! Do you still have the code locally?

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tomnoland@allella@gh-23378@NorthDecoder@ojeytonwilliams