Skip to content
This repository was archived by the owner on Sep 25, 2025. It is now read-only.

Add initial SchemaSpy to the gh-pages branch. Remove other docs. - #453

Merged
vkWeb merged 1 commit into
freeCodeCamp:gh-pagesfrom
allella:docs/add-gh-pages-schemaspy
Mar 16, 2021
Merged

Add initial SchemaSpy to the gh-pages branch. Remove other docs.#453
vkWeb merged 1 commit into
freeCodeCamp:gh-pagesfrom
allella:docs/add-gh-pages-schemaspy

Conversation

@allella

@allellaallella commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

The other docs will still exist in the main branch of the repo, at least for now.

  • I have read Chapter's contributing guidelines.
  • My pull request has a descriptive title (not a vague title like Update README.md).
  • [] My pull request targets the master branch of Chapter. This purposely targets the gh-pages branch.

Closes#54

For now, it's easy enough to generate the schema and push updates to this gh-pages branch.

Eventually, as outlined in #54 we should be able to run a more automated solution to update the schema, like with the SchemaSpy Docker image.

@vkWeb

This comment has been minimized.

@vkWeb

Copy link
Copy Markdown
Member

@allella Ohh, I just read the comments in that issue. I see now. Running and reviewing in a minute.

@allella

allella commented Mar 16, 2021 via email

Copy link
Copy Markdown
ContributorAuthor

@vkWebvkWeb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allella All looks good. 🎉

I first ran schemaspy on my linux system to see how it renders and then I pulled your PR to see if it matches that. And it's perfect.

🍻

chapter database schemaspy render

@vkWeb
vkWeb merged commit 74ab0bf into freeCodeCamp:gh-pagesMar 16, 2021
@vkWeb

Copy link
Copy Markdown
Member

Jim, we've successfully deployed at: https://freecodecamp.github.io/chapter/index.html 🟢

@allella
allella deleted the docs/add-gh-pages-schemaspy branch March 16, 2021 14:09
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@allella@vkWeb